From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 295F94558A; Fri, 5 Jul 2024 00:43:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 134A64027E; Fri, 5 Jul 2024 00:43:36 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2067.outbound.protection.outlook.com [40.107.223.67]) by mails.dpdk.org (Postfix) with ESMTP id 43CCC40275 for ; Fri, 5 Jul 2024 00:43:34 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mtxZSy9Cponj3Nifldhmg3pJfjT+RWdQjnX4US8uEL1NyYGl4wUHTV9oQWJclCn8a3WhSWmMfDoewQwzkb7tT4A798G0MfnP5+wSaRLtM47gsTky2ywfYcszyD8S7LYqCNKLOkOQHtr8CYP0YlQU3ja+Ju3k+VL5CaHYrLc0Yjd7zyf1msRh5wp+B4bnam8xzRie8Nui/Ds90bHC4aU1FwiUjH8lLgBHezUIii7cWTmx/3MkfcItVdJFF07Yeh5yIXLRFvyllF1QxaoNYEd38wr/KupaShRb9gfCHCfdzV/F58+uwOn1SYtkC3rSwEFNWUkfxIaSonUWyIYONMZu7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=96itTcTuyr//9QAAdp0fr4P5RUEd+/yDq7MB7WlgSzc=; b=mdwaaYOq0S+iRmmoSjKODSVtgvHAvpbWUG3MJL2InO5zXGq4imDL96eqGJBRop6AXiaUzVFsQhtHJOijy/xjk7QwgWbWxaaDoH7AgViQcliYBPVOfm4AArgyTbubSuNbTt5rEBNk8ItTY0BRguuLBa2Koeu7amYq+zxjFagh54aHF4z32F+XZVVTtCarJnRe+v3Ykp/Ox52Fa6ykCKy33RU61VvytCEWSq9oFRf+BWuqU5joiKKG40HKJItv+KfgkgsfwuAQEA5H+nG0lh2Vv2KVSI4Z5+QRMib1zKHbGcw8drXAIiFpUjiw72xsw45DgglAZzllv/+bVNQYYfPMdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=96itTcTuyr//9QAAdp0fr4P5RUEd+/yDq7MB7WlgSzc=; b=sDwxbop680sqRNau5wf8PV+/oVMsmIe3x3wMunAHQinFAXFj3iLjTKNF4G1Bhc2KX7ilXXd4siiL7v47jLc1BWk5CV6MF1zJJG9H75MWQylnT9fr/+n6nB+7E74XvWSpCDGPZeqjmAllSbrjZ3J3MAZYTjVjx945NCMuLzVYQJk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB9101.namprd12.prod.outlook.com (2603:10b6:510:2f9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.33; Thu, 4 Jul 2024 22:43:28 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd%4]) with mapi id 15.20.7741.017; Thu, 4 Jul 2024 22:43:28 +0000 Message-ID: <61ecee76-caac-4850-9a4c-0267c2f0c59b@amd.com> Date: Thu, 4 Jul 2024 23:43:23 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 01/23] net/ntnic: add ethdev and makes PMD available To: Serhii Iliushyk , dev@dpdk.org Cc: mko-plv@napatech.com, ckm@napatech.com, andrew.rybchenko@oktetlabs.ru, Thomas Monjalon References: <20240530144929.4127931-1-sil-plv@napatech.com> <20240627073918.2039719-1-sil-plv@napatech.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240627073918.2039719-1-sil-plv@napatech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU7P194CA0025.EURP194.PROD.OUTLOOK.COM (2603:10a6:10:553::20) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB9101:EE_ X-MS-Office365-Filtering-Correlation-Id: 84693d11-8651-43a4-7862-08dc9c7ab8b4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?aEhCbVI4Y0RuMnFoKy9QUldpZG1oZlQxeWRCRU5CM3N3YW1BSGdCaExXWERn?= =?utf-8?B?WnRYbjRhb0VwdXBJd0pCUzArRzZxRDJyN3JtSVdYNGFCZE85K285M1QzQVd3?= =?utf-8?B?UnA4MHhhOVJnd3MzNHRQVUhjbFRNcHpocUJlL2gwak9iUlpqQ1B5d1VMalUr?= =?utf-8?B?QVo1RDBGSjdEaE9LSWswclF2Zk0zTURNMmVCOTNzblVLeTM1bzZ3djBtYkc3?= =?utf-8?B?UnFSYmdrb1NOUXNTZXVTZVBnczk4dDkvejlLNHpZcHNEczRoM2U0N0JEZVli?= =?utf-8?B?c0QyZXBzMTFXajgyZVdwSm1BQ0JqT3BvcjZoS1dpdVROSlVuaWNMdzZBSmRS?= =?utf-8?B?TzEyVmk1T3NHQVU1UitHa0NuSkFISHB6K2lMSDd6RzJ2KzF6MnZYeG9iQmlo?= =?utf-8?B?K3VSUmpHb2g4WXdGb3FBQ3I1VXVvOFZBaThWMnRkcnlHbjRnTVU0Q2k4cWk4?= =?utf-8?B?bWRraHNLemtvOEdnUWQwanhKTEtvQ0JaMW0zTC9KdmM3dFgrU21uN09HM044?= =?utf-8?B?OVRKc05QZzRYV3Q2eXFDakRvalpaK1Qzek8vNmh1MHlQZ3ptanpWZDVlK3VT?= =?utf-8?B?V0VTRUR1Mkd3SE1ONFRpU2E1T0ZVaml2d3h2OG53K09OY1ZrQ2h1YmcxdkVM?= =?utf-8?B?czc0WEI1aW8yQlR1eDBqT0xieUxXUXJwRUhpSmlWM3RaRFJpYWp3STE1OHhG?= =?utf-8?B?WndQdlJiQU12dngrRlZFenZJMXZLRlB4UFJIMHZWWEJCY3Q1TytkRnVkZ0lj?= =?utf-8?B?Zkp1ZzIwdFN2ZU1uNGVSTWU0WjdDelBOdU9BTlRCdldnb1pWZWM1UDh3dWhB?= =?utf-8?B?Z3djdFcxMlN4UlF3MS92V1BXNCszak81NENEWmQ2dExYdTdRSmlQNGMyZ0JB?= =?utf-8?B?ZXp0S1JSbTZsWUNjMHRNNTEveFlpMnA1cC9RUklwdjVrMTJ2Y094VVBqT0FM?= =?utf-8?B?ZDNJT0ZnZm40MUFoQlVmRU83T1hUZmowN2Y1L1BBTkpsdHpWa0VuSC9NRVRn?= =?utf-8?B?Y0FKV0cxU0ZJUUg4VDZTZGEvS2Y2ZHJXMFY2WkdYVFhOQ2FvSUoyTTRUZzZR?= =?utf-8?B?SkQxcUlyTytOQlZJTWdEaGt6ZnZNdXB2a3NBeTdNN05wMmlXa0VzT2xyMWln?= =?utf-8?B?eklUekxlWHErZTRrcmJlWC9KZnFsdmhEQUErQ05QOElkSmNEeW1kMmRvZFd1?= =?utf-8?B?TkQraGFuUVlmZkl1QzUrMkRpaTRTZ3c5bkt1NUlpa0pHMDI3ZDdSaUczTTgy?= =?utf-8?B?Z1laZzZHT0Z4c1pERytCaUkzZlBkZDdLOGM2bUhhNWRXemlsWDRmazNBSHVP?= =?utf-8?B?YTlBSDNTTklOSFR0YXhTZWRpWTFhWlRsMnBlMS9QckZlSU4vNjJJYlNidGtC?= =?utf-8?B?Nk9ZdWw5alc0Q1V0V3p5cGE5YXBJaVNCRVdrTUc1UnZUQjg2UVdqdlhwYjNz?= =?utf-8?B?SjdiSWxUV1UwZDRZcnB5eWVLbTZXcTcxZXRRckltQU1qWVJZY0tHVDVXNnQz?= =?utf-8?B?YVBmMisyWEhPaTREN2ozNHdxWWNIb3duZkVrYUZPdC8zbXlTVUNjUW5PdFps?= =?utf-8?B?OXJLaEdkNTJjUVJCd3NRZ2V0Z05OYi9RdGFIdTlJaWg1bUs2TEZrbmRiVGJJ?= =?utf-8?B?NzNSejAvN2xzWlNHN1pEeEgyZjNuckxiSUxJbFl2OGQ5eHQ1NDlRdGlyWmov?= =?utf-8?B?ak5tbE16K01COXM2S3ZEN3hYc0s1SDMrMlU0K2RaN3JCYmpReElOVENRakNM?= =?utf-8?B?RThqekJTTldPdk9tOWxQZjBzYmt4MVBIUUxPMG53NGd3eTNyWEJiaTc2WjdF?= =?utf-8?B?b2tYZHluWWUrZ2Q1NVJKZz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmFMWkZkUVpOZGd4dS9ldkRjZ0o5TXZLWXVNZGxaQmRjVmFNcVRyMjE3clVB?= =?utf-8?B?S2czNkJqa002NUQzRitMcWcrTkV1N0ZMTHI3bG4zeG9qOXpKOHNXUXlwM2k5?= =?utf-8?B?ZWtVSW8rcTNRSHcxUlpjVlh3N0JXTE5vNDlPaGZRbk1aQlRCSDhYdDFpR3Vm?= =?utf-8?B?UmVPZGNtMXRnNWozdWswQ2ZkVHhUdTBjbEtIVU5Vd2pRSUdvSW9zMXNHaTBz?= =?utf-8?B?MkdwcVpUdldTbmhYNWtlNmRTOGUxNVVDRFB4UzQ0bmlyKzFUQ1pwd3VCaFdy?= =?utf-8?B?MlBiNUlyRzFzczY0QXg2RzJUY2oraEFjNVRLM2RjZHQ4QWVDQ1hJMlV6cGxF?= =?utf-8?B?WGV4Q2x0MkQ0bmIwNXY1bis1Nkd6bk9GNWZuYm9yQXVWLys2V2lkR3JUa0Fx?= =?utf-8?B?TFJRRTFXMVdsWnlHaEpta2pXdXNoQlFlOEhzK3M3VWRRR3lGOG12N3VWOEpS?= =?utf-8?B?WURORXlqejEvVWhHcmtFT0VUNUFxVURqSnFnY3Vxdm82d2R1QjFxbnljVC9x?= =?utf-8?B?Z1hqMW1oTForQmJ0cTBZeDl1R3cydjc2cGMxY2xoTmsyYk9QVzVDeUYwaXJl?= =?utf-8?B?Q3U4WENDVmdZNzBOb01ka0VkVE1Qa2dBaEZLdmE0NmsyaFFjVTA0MFlaT2tS?= =?utf-8?B?OTdhMFNNUkdUbkRueDAvK2JJNndTSEVnQXYyMk5VaWhiUFp3MWVQUTArTVEz?= =?utf-8?B?ZVVoejhDZGEyZDh1Tko5TmpYRklId1BiMDJDV2lTSHIyVDJFeVZEbWdNTDJM?= =?utf-8?B?OUo0QVdFc3gxdm00TUpwZDRoNnY5RzBHUkdpeDlOMGhzc1JaVjB6RkFQOTZR?= =?utf-8?B?WjdvYk9NZmM3MTBBSzlIL0dwMU9TZFZIeCtyR3oxL3Z4Y1VjS3k1VU95Tnpt?= =?utf-8?B?dURPd0NsRy9QVDQ2RnFKdVVGVjBpUlVFZnA2QXNEOVc3OWFhWkMvMHZiSHM4?= =?utf-8?B?cXZzV2ZQK1FONWYyU09ZYzEyQlhNUkE4QjM1QWMweU1kYS9PWFhpYS9Od0lS?= =?utf-8?B?V0QvRmI1b2FOSkMxWXVvelBzSitMY1lYSVh4cWtUbVd0aGpaak1GNXpTSjN1?= =?utf-8?B?cHJWeDd1NW9PdCttV3ZPaXJleUJmanpDQlBEZXRjdFdmNDhrZU9tS2VOVE11?= =?utf-8?B?bno4RzBJN1ExZWZBRFo0eU01WTZYREozNERlOGVORHdBTjBTbmlFeEZaWktP?= =?utf-8?B?TmdCVHF5c1pNOFVuZzJXRzQvbFNPOWZOdnE2cStEU1NRWXNNNWtsanRIVDZF?= =?utf-8?B?eEMxM211YzFSSjEwaFNmN1RqUnQ3YXFBaDFsUUlzRU5Hek5HaEVza0E0N0Fy?= =?utf-8?B?bjYxOE1ER2NZVVZkaUVHNDBxbVhwdm5EODlmOGlzR0lhT24ydFpNUVpDNDhT?= =?utf-8?B?eHowVXVWN0VoVm1pVVgwK2FLalJ0NUUzQ1kwQWVSOEc2VFhvSWs2eVlRdGlL?= =?utf-8?B?dkozazZ0Y2JDUWQ0WW0rNGFXUXFlWGJxY0FWcEw5aXNZMFBQUjlmRnF1YklF?= =?utf-8?B?YlA5WTJzeFRlUll3RXVXcThFbVltUmxaSS9XMXZzb3Bvay9tVkNGMEhudGUw?= =?utf-8?B?OGRMbmpNZFBNQ2lCN3c4Vk91VHpMVHZkMkVKYWV5Rm1iczVkeW5oZTRzRnpp?= =?utf-8?B?OHZOaVljTkU2c2NVc3VMRHNPTEs4cnl3Q0NrTkZQZFE5TFBCaUpKUkg5LzMx?= =?utf-8?B?VWxWWGxSK1dBbVBFcEM5YWM1WGkyOFlBb0htWUMzWE9tYXRySE55c0ZGY0dy?= =?utf-8?B?MUhjY090eXBQYTJsWGNvTlhFRklaUXBMdFlpV0F6Zm02T0JEcHdYdkFGK09r?= =?utf-8?B?bzhXQnV4N2VKYjdtWVVKeVVhTFY2OVFBMlhFQWNQQ2FYWnpaUlc5MnB2QUNz?= =?utf-8?B?Z0dUTFJNcFpxTGFQd3VpQUw4TmFrMzVYb2lDTUoxNG5SN3pDQWRSZGNDeVVM?= =?utf-8?B?VHVQSTdjbHo1VWVBQ1NJY2p4T1FYbVF0WWFVZGkrZEVMYkx2dG5rQkVNbk4y?= =?utf-8?B?U2U1V0Vrcmswdks1VURqWVdzS2JzdThJbndQNTlrOTFIa2ttQUNzcE1SVzEz?= =?utf-8?B?dXFSUlVRN0FEVVhvOUJ4ZkUya0tpRnpDbFFzN0pRcnJvYVFsYkVnVEw3Y2k1?= =?utf-8?Q?mhNutsN5GAuuNqLU2xJyzgA+S?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84693d11-8651-43a4-7862-08dc9c7ab8b4 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2024 22:43:28.0544 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VcVou+x5t7t98TWHoHJLe3gI3utkGVzd+CjBii8Fs7PVsCnLR7KKPiWLSSoXhfTd X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9101 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/27/2024 8:38 AM, Serhii Iliushyk wrote: > Add ntnic ethdev base implementation > Hi Serhii, Thanks for the updated version, how driver constructed patch by patch is easier to grasp now. <...> > diff --git a/doc/guides/nics/ntnic.rst b/doc/guides/nics/ntnic.rst > new file mode 100644 > index 0000000000..68996eac35 > --- /dev/null > +++ b/doc/guides/nics/ntnic.rst > @@ -0,0 +1,43 @@ > +.. SPDX-License-Identifier: BSD-3-Clause > + Copyright(c) 2023 Napatech A/S > + > +NTNIC Poll Mode Driver > +====================== > + > +The NTNIC PMD provides poll mode driver support for Napatech smartNICs. > + > + > +Design > +------ > + > +The NTNIC PMD is designed as a pure user-space driver, and requires no special > +Napatech kernel modules. > + > +The Napatech smartNIC presents one control PCI device (PF0). NTNIC PMD accesses > +smartNIC PF0 via vfio-pci kernel driver. Access to PF0 for all purposes is > +exclusive, so only one process should access it. The physical ports are located > +behind PF0 as DPDK port 0 and 1. > + > + > +Supported NICs > +-------------- > + > +- NT200A02 2x100G SmartNIC > + > + - FPGA ID 9563 (Inline Flow Management) > + Can you please provide some links for the product, so that whoever interested can access to the devices easier. This is also good opportunity to advertise the product. > + > +Features > +-------- > + > +- Link state information. > + Even this feature is not available at this stage. As far as I can see it is missing now, but need to update this file, and .ini file as new features enabled in the driver. > + > +Limitations > +~~~~~~~~~~~ > + > +Kernel versions before 5.7 are not supported. Kernel version 5.7 added vfio-pci > +support for creating VFs from the PF which is required for the PMD to use > +vfio-pci on the PF. This support has been back-ported to older Linux > +distributions and they are also supported. If vfio-pci is not required kernel > +version 4.18 is supported. > diff --git a/drivers/net/meson.build b/drivers/net/meson.build > index bd38b533c5..fb6d34b782 100644 > --- a/drivers/net/meson.build > +++ b/drivers/net/meson.build > @@ -45,6 +45,7 @@ drivers = [ > 'nfb', > 'nfp', > 'ngbe', > + 'ntnic', > 'null', > 'octeontx', > 'octeon_ep', > diff --git a/drivers/net/ntnic/meson.build b/drivers/net/ntnic/meson.build > new file mode 100644 > index 0000000000..227949eacb > --- /dev/null > +++ b/drivers/net/ntnic/meson.build > @@ -0,0 +1,24 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(c) 2020-2023 Napatech A/S > + > +if not is_linux or not dpdk_conf.has('RTE_ARCH_X86_64') > + build = false > + reason = 'only supported on x86_64 Linux' > + subdir_done() > +endif > + > +# cflags > +cflags += [ > + '-std=c11', > +] > Why this flag is explicitly required? > + > +# includes > +includes = [ > + include_directories('.'), > +] > I think this include also not required at this stage. And I don't think adding current folder '.' is required at all. > + > +# all sources > +sources = files( > + 'ntnic_ethdev.c', > +) > +# END > There are EOF markers in various files, if this is part of your coding convention, it is OK to keep them in base files, but for the DPDK specific files, no need to mark the end of file. (Unless you can justify to have them.) > diff --git a/drivers/net/ntnic/ntnic_ethdev.c b/drivers/net/ntnic/ntnic_ethdev.c > new file mode 100644 > index 0000000000..9cc727ac4b > --- /dev/null > +++ b/drivers/net/ntnic/ntnic_ethdev.c > @@ -0,0 +1,53 @@ > +/* > + * SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2023 Napatech A/S > + */ > + > + > +#include > Some of the headers are not required at this stage, can you please include them when they are needed. > +#include > +#include > +#include > +#include > +#include > +#include > + > +/* Global static variables: */ > Can drop comments not meaningful at this stage. > + > +static int > +nthw_pci_dev_init(struct rte_pci_device *pci_dev __rte_unused) > +{ > + return 0; > +} > + > +static int > +nthw_pci_dev_deinit(struct rte_eth_dev *eth_dev __rte_unused) > +{ > + return 0; > +} > + > +static int > +nthw_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, > + struct rte_pci_device *pci_dev) > +{ > + int res; > + res = nthw_pci_dev_init(pci_dev); > + return res; > +} > + > +static int > +nthw_pci_remove(struct rte_pci_device *pci_dev) > +{ > + return rte_eth_dev_pci_generic_remove(pci_dev, nthw_pci_dev_deinit); > +} > + > +static struct rte_pci_driver rte_nthw_pmd = { > + .driver = { > + .name = "net_ntnic", > + }, > No need to set 'name', as this is already done by 'RTE_PMD_REGISTER_PCI' macro. > + > + .probe = nthw_pci_probe, > + .remove = nthw_pci_remove, > May need to add '.id_table', even it is empty (all zeros), otherwise I expect this cause a crash during pci probe.