From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE54241D3E; Thu, 2 Mar 2023 11:19:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A077340E2D; Thu, 2 Mar 2023 11:19:45 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 3E94440E09 for ; Thu, 2 Mar 2023 11:19:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677752383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dcgjdNi5h/37s8NDBMYrgg4noS+lCpFAueio8YwOjAg=; b=S2o6f30Mg40Hdy6rg8qaPmzrno12Dv6Uw3WEcfeiIvjkCycYItbHA+/ThyDjTeisr/gOCz /tp0mpqTM+XaNRoM7nJcpatIuUnqGvvISyviCoUAGK/70Ytqf3n2IVSg7Zaql9Ts/QMTGj SxM7N9ukDxRILQ/yUm475f/gcSClF98= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-281-Wf2AKCcWNbSwfVRe1jJ0mQ-1; Thu, 02 Mar 2023 05:19:42 -0500 X-MC-Unique: Wf2AKCcWNbSwfVRe1jJ0mQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 64104101A52E; Thu, 2 Mar 2023 10:19:42 +0000 (UTC) Received: from [10.39.208.28] (unknown [10.39.208.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1123A440D9; Thu, 2 Mar 2023 10:19:40 +0000 (UTC) Message-ID: <61f48e40-156a-f700-778e-90b93d0c7c56@redhat.com> Date: Thu, 2 Mar 2023 11:19:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3] vhost: fix madvise arguments alignment To: Mike Pattrick , dev@dpdk.org Cc: david.marchand@redhat.com, chenbo.xia@intel.com References: <20230223043551.1108541-1-mkp@redhat.com> <20230301200228.1477189-1-mkp@redhat.com> From: Maxime Coquelin In-Reply-To: <20230301200228.1477189-1-mkp@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Mike, On 3/1/23 21:02, Mike Pattrick wrote: > The arguments passed to madvise should be aligned to the alignment of > the backing memory. Now we keep track of each regions alignment and use > then when setting coredump preferences. To facilitate this, a new member > was added to rte_vhost_mem_region. A new function was added to easily The above sentence is no more valid, I can rework it while applying. > translate memory address back to region alignment. Unneeded calls to > madvise were reduced, as the cache removal case should already be > covered by the cache insertion case. The previously inline function > mem_set_dump was removed from a header file and made not inline. > > Fixes: 338ad77c9ed3 ("vhost: exclude VM hugepages from coredumps") > > Signed-off-by: Mike Pattrick > --- > Since v1: > - Corrected a cast for 32bit compiles > Since v2: > - Removed changes from rte_vhost.h > - Restored set_mem_dump in ioctl remove/evict functions > --- > lib/vhost/iotlb.c | 68 +++++++++++++++++++++++++++++++----------- > lib/vhost/iotlb.h | 5 ++-- > lib/vhost/vhost.h | 12 ++------ > lib/vhost/vhost_user.c | 68 ++++++++++++++++++++++++++++++++++-------- > 4 files changed, 110 insertions(+), 43 deletions(-) > Tested-by: Maxime Coquelin Reviewed-by: Maxime Coquelin Thanks, Maxime