From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11793A0032; Fri, 24 Jun 2022 15:54:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E38354069D; Fri, 24 Jun 2022 15:53:59 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2042.outbound.protection.outlook.com [40.107.100.42]) by mails.dpdk.org (Postfix) with ESMTP id 5A8AF400EF for ; Fri, 24 Jun 2022 15:53:58 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CHqlomci+7+OvIKfG6oLRL6w+6GH4suVeF/TptTWzH7t8BvGynPMAwSNuHcU0n8C+vLslwS9Uck2t20TkNCEbeRzZbiYUFzhrd7v4AbDHqPEa0wPjwXU8nQgWxkLTXe1fFeF9WHTr3BnkTBV7s49y/ZSazhRLxTgVzPzM7zIQizpSNSgOyKa2y0jGt7qNAV90oBztyLu0XOTR1j6VsL8AdMZEWbQPnragFlIdRG0dfOLfOXCXhPvltliWw13lWCPbWaGVAsGn1mC5mjXVPVyP6fEZ3pjdKQu8phYGoy34emkVVNNQf8QoEDfe6PxaWNX1Equ0YX1mXss0pvB0e8Lmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nNVkxpFxlW/djnjCF8bhtxEJURYGhyAdsfZj+2w1trY=; b=cycfvhVdcvshHaojICj2ImwNoOqZB29nGazLHwGKW3aC3rKX59tChAInF8PDqy74ZKAZckDaivEoYaAKcZIjWEVrJ0ZmVvkoy19tIjrFiUBImv4rXPHF9ay7Yq1nRzxcw0nmkwxPHo2oPSYKu0KvcufBaPJ1+VDUFSk20LfmRzKEd1cF8ClyF7uQCRQfoQmmACepYUUj7HZ20Ng2AMndmWz6QPXRZTSase/47X1P+WK2bj5wKFRKEwpBbu4V+on1xzBYXdEiZup0D4NbiEjCYIEDBcf8Q5nY00H5ju/bPD2EDLHmKbqZdY2gbT6C2O7PXZzBUtiLomcBAaYkEsLNaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=huawei.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nNVkxpFxlW/djnjCF8bhtxEJURYGhyAdsfZj+2w1trY=; b=oC1mjYQc9UeJiz5rW1Or8D2b82q4uidq6WYaFgGI1aeB6atg6DJF1dfWX3NjI5k0YDDcf9z/17wWWlgmv58XIjeDbmAjTz6iqeTCdC6mePw3a5233FgaSZhBKWV7RYqGHT/rqTGc8B27I409W0Tz7aDEtkw+2fGhfVd2AlE3yEM= Received: from DM6PR06CA0013.namprd06.prod.outlook.com (2603:10b6:5:120::26) by BYAPR02MB5992.namprd02.prod.outlook.com (2603:10b6:a03:127::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.16; Fri, 24 Jun 2022 13:53:55 +0000 Received: from DM3NAM02FT053.eop-nam02.prod.protection.outlook.com (2603:10b6:5:120:cafe::bf) by DM6PR06CA0013.outlook.office365.com (2603:10b6:5:120::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.17 via Frontend Transport; Fri, 24 Jun 2022 13:53:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; pr=C Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by DM3NAM02FT053.mail.protection.outlook.com (10.13.5.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5373.15 via Frontend Transport; Fri, 24 Jun 2022 13:53:54 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 24 Jun 2022 14:53:53 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 24 Jun 2022 14:53:53 +0100 Envelope-to: lihuisong@huawei.com, aman.deep.singh@intel.com, yuying.zhang@intel.com, andrew.rybchenko@oktetlabs.ru, dev@dpdk.org, thomas@monjalon.net, huangdaode@huawei.com, liudongdong3@huawei.com Received: from [10.71.119.54] (port=51264) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1o4jkv-0004Wc-2A; Fri, 24 Jun 2022 14:53:53 +0100 Message-ID: <62028c08-cec3-74f4-f91d-423b8a415705@xilinx.com> Date: Fri, 24 Jun 2022 14:53:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH V5 2/7] app/testpmd: unify the name of L2 payload offload Content-Language: en-US To: Huisong Li , , , CC: , , , References: <20220429102445.23711-1-lihuisong@huawei.com> <20220624072401.21839-1-lihuisong@huawei.com> <20220624072401.21839-3-lihuisong@huawei.com> From: Ferruh Yigit In-Reply-To: <20220624072401.21839-3-lihuisong@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bd94f300-ca3d-48b5-4f23-08da55e8fa71 X-MS-TrafficTypeDiagnostic: BYAPR02MB5992:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1SwxDe7tQA6H39lS02ONvYGWIgPLnhQ7dTf4UHCTYhitxIw8rA688dgnmle/GEniPDgKgB4LnNTH2ScGOiuS/ygoHIgnZugknWIZvVdQ9pfBA+cbRXo+l+Pqh79QvSPIC36dGUol9YCi0AySWbcj4kw8kl9IYWDSAXwME4u1cPkgLlM1QKGv8w9DMGtFDegMffKDoWS//8uNQW/uCx7J/Pz17VNe+SNCjZtXEW5PBK1Geu9KkF/LMUUTivUGYsLXmCuiijTiecG70KhvVRaAIzh0ct4nSy/qwATwADX2n5VLC3qUbVOsHKLFw2s/2ZWmQr2FAutlr7BT67jrw8xHb1dxIfkG6PFShUwJAgRzjVVcXi8vVvcd3sARHkJx1i0s+/69CcE0w8U+gEUT8s8Fwp/UXWM6eUkoOnO5GK/zqqZqeIgVPSF2j1IzeUVhehSXSsxY8L0smtkS3NNvDzw3f8rZe8cHFvRgKOxduzrK3yuLFxyaUqviGEpPlthoQWpgoiOFGpi8rrsOSl/gyZOlZlAwOx6UiQHjbqq3zay8ESxG44UBwjl7/KcUOjwN6mcPzvYHH+fGMK2tuV8zBcYYdJAOlu4VX2sle6HONbvxn+wfVsQduA8GngFoA5znZTpPTZm8gLMT5wzI0aTvTRiX1eIIN+IShbcEIbo6x4unS6Jwah5kzkzHIV18IWbhTlcZgkZfHk/WRknyAGK8Q7abV80InGoVsAJd7nxWo6innOd+ryQiccSYAZWFObo0WElYDGl4LPpDlQXDmfIVamJXqigLTOuwE0frSMv4Oq5C6EB7kyiKwTCoM7Ppe7k2BoccsP/eu+8yEjvOKnPZwEkhTjvDbKqbRPS7sq4FmHSjG6I= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(346002)(396003)(136003)(39860400002)(376002)(36840700001)(40470700004)(46966006)(4326008)(316002)(54906003)(8936002)(31696002)(8676002)(70206006)(186003)(53546011)(36756003)(356005)(2616005)(40480700001)(44832011)(41300700001)(5660300002)(478600001)(31686004)(26005)(9786002)(2906002)(110136005)(7636003)(82740400003)(82310400005)(36860700001)(70586007)(336012)(40460700003)(426003)(83380400001)(47076005)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2022 13:53:54.6506 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bd94f300-ca3d-48b5-4f23-08da55e8fa71 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT053.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR02MB5992 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/24/2022 8:23 AM, Huisong Li wrote: > Currently, the "port config all rss xx" command uses 'ether' name to match > and to set 'RTE_ETH_RSS_L2_PAYLOAD' offload. However, others RSS command, > such as, "port config rss-hash-key" and "show port > rss-hash key", use 'l2-payload' to represent this offload. So this patch > unifies the name of 'RTE_ETH_RSS_L2_PAYLOAD' offload. > > Signed-off-by: Huisong Li ack But I wonder if we should continue to support 'ether' with an exception to not break the interface, at least for a while like to next LTS. > --- > app/test-pmd/cmdline.c | 6 +++--- > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index 9a7fd5fc35..a701bac953 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -694,7 +694,7 @@ static void cmd_help_long_parsed(void *parsed_result, > "receive buffers available.\n\n" > > "port config all rss (all|default|ip|tcp|udp|sctp|" > - "ether|port|vxlan|geneve|nvgre|vxlan-gpe|ecpri|mpls|ipv4-chksum|l2tpv2|" > + "l2-payload|port|vxlan|geneve|nvgre|vxlan-gpe|ecpri|mpls|ipv4-chksum|l2tpv2|" > "none|level-default|level-outer|level-inner|)\n" > " Set the RSS mode.\n\n" > > @@ -2080,7 +2080,7 @@ cmd_config_rss_parsed(void *parsed_result, > rss_conf.rss_hf = RTE_ETH_RSS_TCP; > else if (!strcmp(res->value, "sctp")) > rss_conf.rss_hf = RTE_ETH_RSS_SCTP; > - else if (!strcmp(res->value, "ether")) > + else if (!strcmp(res->value, "l2_payload")) > rss_conf.rss_hf = RTE_ETH_RSS_L2_PAYLOAD; > else if (!strcmp(res->value, "port")) > rss_conf.rss_hf = RTE_ETH_RSS_PORT; > @@ -2203,7 +2203,7 @@ static cmdline_parse_inst_t cmd_config_rss = { > .f = cmd_config_rss_parsed, > .data = NULL, > .help_str = "port config all rss " > - "all|default|eth|vlan|ip|tcp|udp|sctp|ether|port|vxlan|geneve|" > + "all|default|eth|vlan|ip|tcp|udp|sctp|l2-payload|port|vxlan|geneve|" > "nvgre|vxlan-gpe|l2tpv3|esp|ah|pfcp|ecpri|mpls|ipv4-chksum|l2tpv2|" > "none|level-default|level-outer|level-inner|", > .tokens = { > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > index 0b7a53fdf1..cc299cff6c 100644 > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > @@ -2144,7 +2144,7 @@ port config - RSS > > Set the RSS (Receive Side Scaling) mode on or off:: > > - testpmd> port config all rss (all|default|eth|vlan|ip|tcp|udp|sctp|ether|port|vxlan|geneve|nvgre|vxlan-gpe|l2tpv3|esp|ah|pfcp|ecpri|mpls|l2tpv2|none) > + testpmd> port config all rss (all|default|eth|vlan|ip|tcp|udp|sctp|l2-payload|port|vxlan|geneve|nvgre|vxlan-gpe|l2tpv3|esp|ah|pfcp|ecpri|mpls|l2tpv2|none) > > RSS is on by default. >