From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 0FA792BC7 for ; Tue, 2 Oct 2018 12:28:32 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Oct 2018 03:28:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,331,1534834800"; d="scan'208";a="267709701" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.49]) ([10.237.221.49]) by fmsmga005.fm.intel.com with ESMTP; 02 Oct 2018 03:28:30 -0700 To: Thomas Monjalon , dev@dpdk.org Cc: gaetan.rivet@6wind.com, ophirmu@mellanox.com, qi.z.zhang@intel.com, ktraynor@redhat.com, Neil Horman References: <20180907222727.20521-1-thomas@monjalon.net> <20180928162144.1972-1-thomas@monjalon.net> <20180928162144.1972-4-thomas@monjalon.net> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <6205dfd2-e14f-94dd-c621-ed9313dc8fba@intel.com> Date: Tue, 2 Oct 2018 11:28:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180928162144.1972-4-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 3/4] eal: remove experimental flag of hotplug functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2018 10:28:33 -0000 On 9/28/2018 5:21 PM, Thomas Monjalon wrote: > These functions are quite old and are the only available replacement > for the deprecated attach/detach functions. > > Note: some new functions may (again) replace these hotplug functions, > in future, with better parameters. > > Signed-off-by: Thomas Monjalon > --- > lib/librte_eal/common/eal_common_dev.c | 7 ++++--- > lib/librte_eal/common/include/rte_dev.h | 11 ++--------- > lib/librte_eal/rte_eal_version.map | 4 ++-- Can remove "-DALLOW_EXPERIMENTAL_API" (or "allow_experimental_apis = true" for meson) from drivers/raw/ifpga_rawdev when these APIs are not experimental anymore. For reference: https://patches.dpdk.org/patch/45836/ It is easy to know when to add "-DALLOW_EXPERIMENTAL_API" but it is hard to know when to remove one, some helper should be good there.