From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CEAED42C10; Fri, 2 Jun 2023 10:52:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 66AE240ED8; Fri, 2 Jun 2023 10:52:54 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id C8D38406B8 for ; Fri, 2 Jun 2023 10:52:52 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 4142F5A; Fri, 2 Jun 2023 11:52:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 4142F5A DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1685695972; bh=OFnD5Bc0egZk3exvqIPEtPvui1WW/5Er4AXhI11csnk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=BpxOZtXH7f5WBkGu6TAYFr9FDwjDXqCEpH3Pa8ZjivgACMLTmJK/NnOnhDw3gYxpI TLFAOADs/864APnvF//K1pa7bjEQuQ49M0s3aBoZSdifsg4Hc+oVluEQ3DA6RyBzTM Ry0P8QQje6V30H09n3gRz9vdIHwuOnaAkRKJonX0= Message-ID: <620d7d0d-30d3-3f8e-5e0f-75d2df758507@oktetlabs.ru> Date: Fri, 2 Jun 2023 11:52:51 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 1/3] net/sfc: split link update function Content-Language: en-US To: Denis Pryazhennikov , dev@dpdk.org Cc: Ferruh Yigit , Ivan Malov , Andy Moreton References: <20230601222349.28965-1-denis.pryazhennikov@arknetworks.am> <20230601222349.28965-2-denis.pryazhennikov@arknetworks.am> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: <20230601222349.28965-2-denis.pryazhennikov@arknetworks.am> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/2/23 01:23, Denis Pryazhennikov wrote: > Separate the original link update function into > two functions: state retrieval and update. > This improves code clarity and maintainability. > > Signed-off-by: Denis Pryazhennikov > Reviewed-by: Ivan Malov > Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko