From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id E68901B1BB for ; Mon, 6 Nov 2017 17:00:19 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 74CCE20A59; Mon, 6 Nov 2017 11:00:19 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 06 Nov 2017 11:00:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=zYskF9fg6CDjuP+KN5SSb/QGwF 5CD4xQYKFd+lyXQOI=; b=SpVrfJDJJbaQ/6wvWB4wreVmMfpUSuUEBjh3BN4e05 73T6bL3T7Ccui51H19JaU7h+0cQdImMwaLghuoDBkx2LvsElasCc8nBhp3VAuR8a Lfww0Qw5E+E/lG7XRpd0KQT7/5O0OQdE8ZJyteP0hizim/yXxot/U+JBUog33u55 E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=zYskF9 fg6CDjuP+KN5SSb/QGwF5CD4xQYKFd+lyXQOI=; b=h8ROJmB0V2TTkztZfK1sZd wEHSTYHGnTLCIpGpjdp6ssdswDCtl7EXNtYfXpNLkAg9JGPWlWm7VJF6eaeuywpx IkmEejOdF+9GKdKUa69gs2Nyxu6miSY5bxLVPKk4IXhn/svLnCQ1s7IHpfGHWYIX TYKE4eaigyTRKwxD7aGOGDIhmfnyJ8dTJOkKhjwEduvcaDkPcAwWopZmNIx/Yv6q LI+jq2uyPXt5o8yn9eQ8wpHCW4UlGVGrLF1/08NnqrAx+d3Quuyh17HPm4UVi56C WC0nyItI7DHXZa5i5Tnw6Y4aTe6V30xDj1hg8hUqbiE31/svL6s7FAROlLqdYX3A == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1EE6624E82; Mon, 6 Nov 2017 11:00:19 -0500 (EST) From: Thomas Monjalon To: Olivier MATZ Cc: Santosh Shukla , sergio.gonzalez.monroy@intel.com, anatoly.burakov@intel.com, dev@dpdk.org, hemant.agrawal@nxp.com, shreyansh.jain@nxp.com Date: Mon, 06 Nov 2017 17:00:17 +0100 Message-ID: <6210686.83tBtOY6zu@xps> In-Reply-To: <20171106155245.fvc7toh62gxpxros@platinum> References: <20170814151537.29454-1-santosh.shukla@caviumnetworks.com> <20171106014141.13266-12-thomas@monjalon.net> <20171106155245.fvc7toh62gxpxros@platinum> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 11/15] mbuf: rename physical address to IOVA X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Nov 2017 16:00:20 -0000 06/11/2017 16:52, Olivier MATZ: > On Mon, Nov 06, 2017 at 02:41:37AM +0100, Thomas Monjalon wrote: > > From: Santosh Shukla > > > > Rename buf_physaddr to buf_iova. > > Keep the deprecated name in an anonymous union to avoid breaking > > the API. > > > > Signed-off-by: Santosh Shukla > > Reviewed-by: Anatoly Burakov > > Signed-off-by: Thomas Monjalon > > Just be aware that I still see some references to ->buf_physaddr. > > $ git grep buf_physaddr > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c: op->sym->aead.digest.phys_addr = mbuf->buf_physaddr; > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c: mbuf->buf_physaddr = (uint64_t)op; > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c: op = (struct rte_crypto_op *)mbuf->buf_physaddr; > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c: mbuf->buf_physaddr = op->sym->aead.digest.phys_addr; > drivers/crypto/dpaa_sec/dpaa_sec.c: src_start_addr = sym->m_src->buf_physaddr + sym->m_src->data_off; > drivers/crypto/dpaa_sec/dpaa_sec.c: dst_start_addr = sym->m_dst->buf_physaddr + sym->m_dst->data_off; > lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h: uint64_t buf_physaddr; > lib/librte_eal/linuxapp/kni/kni_net.c: (unsigned long)m->buf_physaddr); > lib/librte_eal/linuxapp/kni/kni_net.c: return phys_to_virt(m->buf_physaddr + m->data_off); > lib/librte_eal/linuxapp/kni/kni_net.c: (unsigned long)m->buf_physaddr)); > lib/librte_mbuf/rte_mbuf.h: rte_iova_t buf_physaddr; /**< deprecated */ Yes, it is on purpose. KNI is known to work only with physical addresses for now. I am not sure about NXP buses, but I had the feeling that it deserves a separate work.