From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06BF6A034F; Tue, 1 Mar 2022 09:35:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C4AAD40DF6; Tue, 1 Mar 2022 09:35:34 +0100 (CET) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id A53FC407FF for ; Tue, 1 Mar 2022 09:35:33 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 469533201DB9; Tue, 1 Mar 2022 03:35:32 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 01 Mar 2022 03:35:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=psk5zUpspMi914 rVPni54xroLHYFmciX2rJEykjqWXU=; b=H9JiFYXxfnXNTRftYY40sRbI5q1Hn7 r3a/8pIwDcunBM3KN0ZCHY563Dq+A3e/mLnDNOkJ0DW0LBbNMjf3rsAzG3zyV0Nc z5GztdlZN+ymYJ2V13W8Do1h71Pp83nNsUYfgZv7/bQlMi3nqcNZ5SudBnUy45re fvgVYyKM1zT47pKc1TsIDtcKNgGV1VYenpzDDzu7p7a8DdwIiss1W5GoZVkmOSiZ J0MySvGYEBEx3dFddX7NdYbOTum/e85Qzind2Dc2LlRxGda8QjjxsyNOS1/YWD1J xHZ4/guSSbpDBt7YeosnLnhRqZLyReeihhwsnfakMv5cVhD58rSsnDsw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=psk5zUpspMi914rVPni54xroLHYFmciX2rJEykjqW XU=; b=MJQdcPnl2ZRkKay34LzYpgGUG2Esc6mLHK146dCt58+4u3UtHfxwTLoAW 0DUFTFAjGoagq7EgPTLw5eOXRcH43uWtLa4znPhU+US1t+1x+7DNEw/B8ekwekWD Q6XKeQYmBfnqlGP+IkANfDEiVURjQhREv/L7dZB/EUg1+LUmuU2ZdhU/OI/xXdvY cfBqOPRGBkISk5GLVxjl0BpNPXWvOcbCTeUoR1nO3WZgpO2Hl+/pHEHgqMkaFsoT w4RT8v2euTrwrxoAVLv+qK1ocpQPtvykcUqSQyt5Eg+5+vAo156xpOFCAeJlcdyw d4nmfOlcJYAVrE5wvRS+9NrAmQlNQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddruddtuddguddvudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpefgvddutdfgieffkeejueeltefhfeefudffveeluefhtdffvdeu hfefledvteejgfenucffohhmrghinhepghgvthdqmhgrihhnthgrihhnvghrrdhshhenuc evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgr shesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 1 Mar 2022 03:35:30 -0500 (EST) From: Thomas Monjalon To: "Min Hu (Connor)" Cc: dev@dpdk.org, ferruh.yigit@intel.com Subject: Re: [PATCH v2] app/testpmd: add help messages for multi-process Date: Tue, 01 Mar 2022 09:35:28 +0100 Message-ID: <6212978.1IzOArtZ34@thomas> In-Reply-To: <20220301033930.16275-1-humin29@huawei.com> References: <20220228032617.46618-1-humin29@huawei.com> <20220301033930.16275-1-humin29@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 01/03/2022 04:39, Min Hu (Connor): > From: Huisong Li > > This patch adds help messages for multi-process. > > Fixes: a550baf24af9 ("app/testpmd: support multi-process") > Cc: stable@dpdk.org > > Signed-off-by: Huisong Li > --- > v2: > * adjust the position of parameters. > --- > app/test-pmd/parameters.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c > index daf6a31b2b..3e6a2e88b5 100644 > --- a/app/test-pmd/parameters.c > +++ b/app/test-pmd/parameters.c > @@ -92,6 +92,8 @@ usage(char* progname) > printf(" --max-pkt-len=N: set the maximum size of packet to N bytes.\n"); > printf(" --max-lro-pkt-size=N: set the maximum LRO aggregated packet " > "size to N bytes.\n"); > + printf(" --num-procs: the number of processes which will be used\n"); > + printf(" --proc-id : the id of the current process (id < num-procs)\n"); > #ifdef RTE_LIB_CMDLINE > printf(" --eth-peers-configfile=name: config file with ethernet addresses " > "of peer ports.\n"); Why adding the multiprocess options in the middle of packet and Ethernet config? I think it would fit better before --nb-cores. Why no testpmd maintainer is Cc'ed? Do you know the command --cc-cmd devtools/get-maintainer.sh ?