From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF485A00C2; Wed, 24 Aug 2022 02:45:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8ACC140DDE; Wed, 24 Aug 2022 02:45:46 +0200 (CEST) Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by mails.dpdk.org (Postfix) with ESMTP id CFC29406A2 for ; Wed, 24 Aug 2022 02:45:44 +0200 (CEST) Received: from localhost.localdomain (unknown [10.20.42.60]) by localhost.localdomain (Coremail) with SMTP id AQAAf8AxFeK1dAVjsUoIAA--.37683S3; Wed, 24 Aug 2022 08:45:42 +0800 (CST) Subject: Re: [PATCH v1] vhost: fix build To: chenbo.xia@intel.com Cc: dev@dpdk.org, maobibo@loongson.cn References: <20220822074233.209414-1-zhoumin@loongson.cn> From: zhoumin Message-ID: <62171ecb-0f39-dd08-5dbb-110ede344a9f@loongson.cn> Date: Wed, 24 Aug 2022 08:45:41 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20220822074233.209414-1-zhoumin@loongson.cn> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-CM-TRANSID: AQAAf8AxFeK1dAVjsUoIAA--.37683S3 X-Coremail-Antispam: 1UD129KBjvdXoW7GF1rKw1DKFWDCw4rtr1fWFg_yoWkKFXEk3 WagF17ZF4kCFn0yayrAr4xtrW2vw4IqF1xGFyFyr1xur1kX3W3Zwn5tr18tF17Xrs7tr4D CrsIvr1jkw1S9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb4AYjsxI4VWkCwAYFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I 6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM2 8CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW8JVW5JwA2z4x0Y4vE2Ix0 cI8IcVCY1x0267AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIE14v26r4j6F4UM28EF7xvwVC2z2 80aVCY1x0267AKxVW8JVW8Jr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IE w4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMc vjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI62AI1cAE67vIY487MxkI ecxEwVCm-wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F4 0E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jrv_JF1l IxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxV AFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j 6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU8P5r7 UUUUU== X-CM-SenderInfo: 52kr3ztlq6z05rqj20fqof0/ X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Ping. On Mon, Aug 22, 2022 at 15:42, Min Zhou wrote: > This patch fixes the following build failure seen on CentOS 8 > with gcc 12.1 because of uninitialized struct variable: > > [..] > ../lib/vhost/virtio_net.c:1159:18: warning: 'buf_vec[0].buf_addr' may be used uninitialized [-Wmaybe-uninitialized] > 1159 | buf_addr = buf_vec[vec_idx].buf_addr; > | ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ > [..] > > Fixes: 873e8dad6f49 ("vhost: support packed ring in async datapath") > > Signed-off-by: Min Zhou > --- > lib/vhost/virtio_net.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c > index 35fa4670fd..4878bb2d8a 100644 > --- a/lib/vhost/virtio_net.c > +++ b/lib/vhost/virtio_net.c > @@ -1837,6 +1837,7 @@ virtio_dev_rx_async_packed(struct virtio_net *dev, struct vhost_virtqueue *vq, > { > struct buf_vector buf_vec[BUF_VECTOR_MAX]; > > + memset(buf_vec, 0, sizeof(buf_vec)); > if (unlikely(vhost_enqueue_async_packed(dev, vq, pkt, buf_vec, > nr_descs, nr_buffers) < 0)) { > VHOST_LOG_DATA(dev->ifname, DEBUG, "failed to get enough desc from vring\n"); -- Thanks, Min Zhou