From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 776F6A00C5; Thu, 14 Jul 2022 10:09:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 555B34282B; Thu, 14 Jul 2022 10:09:00 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id CD2AC41156 for <dev@dpdk.org>; Thu, 14 Jul 2022 10:08:58 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 41ADB5C0162; Thu, 14 Jul 2022 04:08:57 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 14 Jul 2022 04:08:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1657786137; x= 1657872537; bh=Yw5guKaSy4YgLtXMu8LwxJu63ESkChl3xmbeZyBgm5U=; b=e xgCqigpq0IQ5EoQ9WLi8z15gVl66vXbARxvSwpI/hCgiRTsRs7/Hjr3O8TscZ9CA jwPGz86WxAe07A90oOTUUZ3A0qEHN5UBkrpEu3qRtamXDJgGYvAmy2n0eW9AQIdi wdRkR3vfMmss3BHnN0n6Q9cl+6g85WsxHaqh0TpX5BUGQClTdpS+zfAjrf5skhXu k4xuXtCSLtbFBuCM95QpYP1o4zGyJY7p3zzqv1k9pHKmkXRiUAhJReJkkOPdyfk3 QxllmNfS63BvIV0Te099f549oZJvCQS0s5Z3MbloKmulZX7AMVPfoVrMy9u4CcJ4 Tr9CRcrnDQbIWSJpxBhhA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1657786137; x= 1657872537; bh=Yw5guKaSy4YgLtXMu8LwxJu63ESkChl3xmbeZyBgm5U=; b=n kiX9DQja0uxmJZ0TJhDN55XZ40wgFca+nbRnE/VH0IJKyeHdZJog/w5NSYJ1P9zi gYTVYsO8Ic3AVh6zpPh5yqNufZdsRIvGCriGQXTipRcJuQlW/LXPTuSigu1KOTRu mMHAx2oo5jTDLV6DUD43GTVm1o75vVPsSU7Pwj8n+52laXlm6VKzhRA19htUNarp fdGVgtPivBup3TLDB1tDzN5/XWqzHohNocMzwno5gPfujqYHUnGvY0TF0VIlfHdu 0oUTiDZxc7Mq/aZCrVFApx7NciM1HdwQC1KTOMU2XyH+M5tunyuXsJwcMTOM7e8H ho4d9aEze+lA1NpqTd10Q== X-ME-Sender: <xms:GM_PYkwKPyJU-dBiuBLnFPViTRv8YVT5BxdvxZUN2QFSIhNOwb16kg> <xme:GM_PYoTGHeZ5VZbcpcu425kEGK9BS7z_8ZLndxrpCNRQmzBi1ZLGvdhpECNPR-wpo wnuK1DUfMxYLcKsHQ> X-ME-Received: <xmr:GM_PYmV2GCypHWRLwmHZFz3x7eofYFZZqbN3NvuaCYlPR_i0iBJ-KLrmAP9bnxXzdBOUU5RK8oI1yfGxi_esPKXVyQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudejlecutefuodetggdotefrodftvfcurf hrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcu ofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuggftrf grthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieekgfek udehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: <xmx:GM_PYiiTyMCsB3c72S718YTKD4jkOUd3zbbfAjsHEXafcywOevs0Ag> <xmx:GM_PYmBcwN4hOGAHE3xwKWjsMBLbX6ObGSynXYRUpFAk4bRprNaxqg> <xmx:GM_PYjIxTJTcRg9PpyvTzLbJa5Shqq9QKJZqCXAcRiYFpZW2fkR5nA> <xmx:Gc_PYq7Gdns3i6vVqGj1_e-FTVKbiYB5tWNtLmAkj8_VMpCfdZWA1A> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 14 Jul 2022 04:08:54 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: "Ding, Xuan" <xuan.ding@intel.com> Cc: "andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>, "mdr@ashroe.eu" <mdr@ashroe.eu>, "dev@dpdk.org" <dev@dpdk.org>, "stephen@networkplumber.org" <stephen@networkplumber.org>, "mb@smartsharesystems.com" <mb@smartsharesystems.com>, "dev@dpdk.org" <dev@dpdk.org>, "Zhang, Qi Z" <qi.z.zhang@intel.com>, "asekhar@marvell.com" <asekhar@marvell.com>, "pbhagavatula@marvell.com" <pbhagavatula@marvell.com>, "ferruh.yigit@xilinx.com" <ferruh.yigit@xilinx.com>, "grive@u256.net" <grive@u256.net> Subject: Re: [PATCH] doc: announce header split deprecation Date: Thu, 14 Jul 2022 10:08:52 +0200 Message-ID: <6226385.mzcYPaeBD7@thomas> In-Reply-To: <BN9PR11MB5513622FEE159BFE8D1C2CC0E7889@BN9PR11MB5513.namprd11.prod.outlook.com> References: <20220523142016.44451-1-xuan.ding@intel.com> <11233520.IZOipudI63@thomas> <BN9PR11MB5513622FEE159BFE8D1C2CC0E7889@BN9PR11MB5513.namprd11.prod.outlook.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 14/07/2022 07:50, Ding, Xuan: > From: Thomas Monjalon <thomas@monjalon.net> > > 23/05/2022 16:20, xuan.ding@intel.com: > > > From: Xuan Ding <xuan.ding@intel.com> > > > > > > RTE_ETH_RX_OFFLOAD_HEADER_SPLIT offload was introduced some time > > ago > > > to substitute bit-field header_split in struct rte_eth_rxmode. It > > > allows to enable header split offload with the header size controlled > > > using split_hdr_size in the same structure. > > > > > > Right now, no single PMD actually supports > > > RTE_ETH_RX_OFFLOAD_HEADER_SPLIT with above definition. Many examples > > > and test apps initialize the field to 0 explicitly. The most of > > > drivers simply ignore split_hdr_size since the offload is not advertised, but > > some double-check that its value is 0. > > > > > > So the RTE_ETH_RX_OFFLOAD_HEADER_SPLIT and split_header_size field > > > will be removed in DPDK 22.11. > > > > > > Signed-off-by: Xuan Ding <xuan.ding@intel.com> > > > --- > > > doc/guides/rel_notes/deprecation.rst | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/doc/guides/rel_notes/deprecation.rst > > > b/doc/guides/rel_notes/deprecation.rst > > > index 4e5b23c53d..b8114f29ed 100644 > > > --- a/doc/guides/rel_notes/deprecation.rst > > > +++ b/doc/guides/rel_notes/deprecation.rst > > > @@ -125,3 +125,7 @@ Deprecation Notices > > > applications should be updated to use the ``dmadev`` library instead, > > > with the underlying HW-functionality being provided by the ``ioat`` or > > > ``idxd`` dma drivers > > > + > > > +* ethdev: After bit-field header split was removed, the > > > +``RTE_ETH_RX_OFFLOAD_HEADER_SPLIT`` > > > +offload and the ``split_hdr_size`` field in structure > > > +``rte_eth_rxmode`` to enable header split offload are not supported in any > > PMDs. They will be removed in DPDK 22.11. > > > > It would have been good to talk about rte_eth_rxseg_split which is similar and > > configured per-queue. > > Thanks for your suggestion. > > But I'm a little confused, are you referring that I need to involve protocol based buffer split? > About the deprecation of header split, I haven't realized its connection to rte_eth_rxseg_split. What??? In old versions of your patch "ethdev: introduce protocol type based header split" you wrote: " A new proto field is introduced in the rte_eth_rxseg_split structure reserved field to specify header protocol type. With Rx offload flag RTE_ETH_RX_OFFLOAD_HEADER_SPLIT enabled and protocol type configured, PMD will split the ingress packets into two separate regions. " > Currently there are 2 acks, add more PMD maintainers to help review this deprecation notice > for header split, thanks a lot! I cannot say my feeling strong enough.