From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42])
 by dpdk.org (Postfix) with ESMTP id B0DC5212
 for <dev@dpdk.org>; Wed, 15 Oct 2014 13:57:20 +0200 (CEST)
Received: by mail-wg0-f42.google.com with SMTP id z12so1167639wgg.25
 for <dev@dpdk.org>; Wed, 15 Oct 2014 05:05:09 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=rpEJ41JvXi8Y03bWKyCWTfGAqQiIARz4Z2UXKNbpLGQ=;
 b=Etyg6tf2uAt+hhgCFs60mZbWWH9qWkI4pFybtJKqbNImgIflPjvX7ju9jkYZzF/p3j
 oK6l9/l9ffTp9mFBvpAA83ugiG+3yQPGAlQ4tWWNfMt/EaRiLbPq3Phq2h/8mtV8fKiV
 SJueUiNqX2lddn8PppQ2mHSv8Mp/HGCV7PmIzbE88UwNq1PkWMlAj0FboznZfLJhroag
 OHHy9P8RzM7CQdmUxK2vFJ9UnrdAmKmb9CqmG4NDr2+Y9EJBi23Jq95qsA4Z4O4xmlzl
 n/7AI98JxfexeBH4R1fnL47kvGcNBOa47Dg51Nrpl43cy3lnumBDlUbUfDhcWshC8Oyd
 nCoA==
X-Gm-Message-State: ALoCoQlwA2YEidBW9fSZon99XO6P4AyBVl71c2cdlrZ6PCQWgJtMjc+Ur3o0tDsZdATOA1mMPktk
X-Received: by 10.194.201.70 with SMTP id jy6mr11925769wjc.67.1413374709373;
 Wed, 15 Oct 2014 05:05:09 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id u8sm24893754wjq.1.2014.10.15.05.05.07
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 15 Oct 2014 05:05:08 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>, "Gonzalez Monroy,
 Sergio" <sergio.gonzalez.monroy@intel.com>
Date: Wed, 15 Oct 2014 14:04:52 +0200
Message-ID: <6226905.S8oySLlmRr@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.1 (Linux/3.16.4-1-ARCH; KDE/4.14.1; x86_64; ; )
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8972262B7FB@IRSMSX108.ger.corp.intel.com>
References: <1412611749-7901-1-git-send-email-sergio.gonzalez.monroy@intel.com>
 <E115CCD9D858EF4F90C690B0DCB4D8972262B7FB@IRSMSX108.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Pass verbose flag to kernel module
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Oct 2014 11:57:21 -0000

Sergio,

I'd like to see a v2 patch with your explanations in commit log
and with a Signed-off-by.

> > -		CROSS_COMPILE=$(CROSS)
> > +		V=$(if $(V),1,0) CROSS_COMPILE=$(CROSS)

Minor nits:
- paren is not needed for one letter variable
- V option should go to the end to keep things sorted by importance

-               CROSS_COMPILE=$(CROSS)
+               CROSS_COMPILE=$(CROSS) V=$(if $V,1,0)

> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Please Pablo, do not give your ack if there is no Signed-off-by.
It's mandatory.

Thanks
-- 
Thomas