From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 286432B9E for ; Tue, 28 Nov 2017 13:01:57 +0100 (CET) Received: from pure.maildistiller.com (unknown [10.110.50.29]) by dispatch1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTP id C2E6D207EE; Tue, 28 Nov 2017 12:01:56 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.110.49.251]) by pure.maildistiller.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 2E2A54006F; Tue, 28 Nov 2017 12:01:56 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id DB4B1B00055; Tue, 28 Nov 2017 12:01:55 +0000 (UTC) Received: from [192.168.239.128] (193.34.186.16) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Tue, 28 Nov 2017 12:01:50 +0000 To: Ferruh Yigit , CC: Andy Moreton References: <1510819481-6809-1-git-send-email-arybchenko@solarflare.com> <1510819481-6809-37-git-send-email-arybchenko@solarflare.com> <97b17ccf-ce79-5196-240d-d77eda9f684c@intel.com> From: Andrew Rybchenko Message-ID: <62327f95-f511-a4df-f2d0-8105d45d4baf@solarflare.com> Date: Tue, 28 Nov 2017 15:01:47 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <97b17ccf-ce79-5196-240d-d77eda9f684c@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [193.34.186.16] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23496.003 X-TM-AS-Result: No--16.387300-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1511870516-JkLbtnjLi5GL Subject: Re: [dpdk-dev] [PATCH 36/53] net/sfc/base: run mkconfig.py to add a new sensors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Nov 2017 12:01:57 -0000 On 11/27/2017 10:58 PM, Ferruh Yigit wrote: > On 11/16/2017 12:04 AM, Andrew Rybchenko wrote: >> From: Andy Moreton > We don't know what mkconfig.py is and most probably not interested in :) This > looks like your internal detail, more interesting is the effect of this change, > like "add new sensors". Yes. I'll adjust similar patches in the future. > btw, just out of curiosity, what sensors are they? It is current (mA) sensors for 1.8 V and 2.5 V power supplies used on some boards. Andrew. >> Signed-off-by: Andy Moreton >> Signed-off-by: Andrew Rybchenko >> --- >> drivers/net/sfc/base/efx.h | 4 +++- >> drivers/net/sfc/base/efx_mon.c | 4 +++- >> 2 files changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/sfc/base/efx.h b/drivers/net/sfc/base/efx.h >> index df1594e..b809819 100644 >> --- a/drivers/net/sfc/base/efx.h >> +++ b/drivers/net/sfc/base/efx.h >> @@ -627,7 +627,7 @@ efx_mon_init( >> #define EFX_MON_STATS_PAGE_SIZE 0x100 >> #define EFX_MON_MASK_ELEMENT_SIZE 32 >> >> -/* START MKCONFIG GENERATED MonitorHeaderStatsBlock 5d4ee5185e419abe */ >> +/* START MKCONFIG GENERATED MonitorHeaderStatsBlock aa0233c80156308e */ >> typedef enum efx_mon_stat_e { >> EFX_MON_STAT_2_5V, >> EFX_MON_STAT_VCCP1, >> @@ -706,6 +706,8 @@ typedef enum efx_mon_stat_e { >> EFX_MON_STAT_CONTROLLER_TDIODE_TEMP, >> EFX_MON_STAT_BOARD_FRONT_TEMP, >> EFX_MON_STAT_BOARD_BACK_TEMP, >> + EFX_MON_STAT_I1V8, >> + EFX_MON_STAT_I2V5, >> EFX_MON_NSTATS >> } efx_mon_stat_t; >> >> diff --git a/drivers/net/sfc/base/efx_mon.c b/drivers/net/sfc/base/efx_mon.c >> index c2f1e97..6074760 100644 >> --- a/drivers/net/sfc/base/efx_mon.c >> +++ b/drivers/net/sfc/base/efx_mon.c >> @@ -123,7 +123,7 @@ efx_mon_init( >> >> #if EFSYS_OPT_NAMES >> >> -/* START MKCONFIG GENERATED MonitorStatNamesBlock 5daa2a5725ba734b */ >> +/* START MKCONFIG GENERATED MonitorStatNamesBlock d92af1538001301f */ >> static const char * const __mon_stat_name[] = { >> "value_2_5v", >> "value_vccp1", >> @@ -202,6 +202,8 @@ static const char * const __mon_stat_name[] = { >> "controller_tdiode_temp", >> "board_front_temp", >> "board_back_temp", >> + "i1v8", >> + "i2v5", >> }; >> >> /* END MKCONFIG GENERATED MonitorStatNamesBlock */ >>