From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC885A0542; Wed, 26 Oct 2022 07:14:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E107E42C64; Wed, 26 Oct 2022 07:14:35 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 27EFF42C64 for ; Wed, 26 Oct 2022 07:14:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666761273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XRsjrHZrkfek9KbXEWgBLDidWflw6ylQK3Ihw98F1HU=; b=H417D7+KrCKseSNFCvibaEyRHxJc0MiN4uf66DOVpAg3JVM3yUXRxePppxdUSVei692bM0 u4sku4AwZACbObAn1aYNcwQgdzPmHXyyCC4IMy4cm1TutkrzoPhpNIZKUSecZ1ZKami+s+ 34w5hx8tXSKijAS1+V3jiDI7+jq3MRY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-374-4xAzOkq0PYCb5EsLi0oIdw-1; Wed, 26 Oct 2022 01:14:28 -0400 X-MC-Unique: 4xAzOkq0PYCb5EsLi0oIdw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4F48D3C025D3; Wed, 26 Oct 2022 05:14:22 +0000 (UTC) Received: from [10.39.208.48] (unknown [10.39.208.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1662A4B3FC6; Wed, 26 Oct 2022 05:14:14 +0000 (UTC) Message-ID: <623d9951-b0c1-f8cb-f0ac-33a83dbb157d@redhat.com> Date: Wed, 26 Oct 2022 07:14:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v8 2/2] examples/vhost: unconfigure DMA vchannel To: xuan.ding@intel.com, chenbo.xia@intel.com Cc: dev@dpdk.org, jiayu.hu@intel.com, xingguang.he@intel.com, weix.ling@intel.com, cheng1.jiang@intel.com, yuanx.wang@intel.com, wenwux.ma@intel.com References: <20220814140442.82525-1-xuan.ding@intel.com> <20221025082540.100618-1-xuan.ding@intel.com> <20221025082540.100618-3-xuan.ding@intel.com> From: Maxime Coquelin In-Reply-To: <20221025082540.100618-3-xuan.ding@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/25/22 10:25, xuan.ding@intel.com wrote: > From: Xuan Ding > > This patch applies rte_vhost_async_dma_unconfigure() to manually free > DMA vChannels. Before unconfiguration, make sure the specified DMA > vChannel is no longer used by any vhost ports. > > Signed-off-by: Xuan Ding > --- > examples/vhost/main.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/examples/vhost/main.c b/examples/vhost/main.c > index ac78704d79..42e53a0f9a 100644 > --- a/examples/vhost/main.c > +++ b/examples/vhost/main.c > @@ -2066,6 +2066,14 @@ main(int argc, char *argv[]) > RTE_LCORE_FOREACH_WORKER(lcore_id) > rte_eal_wait_lcore(lcore_id); > > + for (i = 0; i < dma_count; i++) { > + if (rte_vhost_async_dma_unconfigure(dmas_id[i], 0) < 0) { > + RTE_LOG(ERR, VHOST_PORT, > + "Failed to unconfigure DMA %d in vhost.\n", dmas_id[i]); > + rte_exit(EXIT_FAILURE, "Cannot use given DMA device\n"); > + } > + } > + > /* clean up the EAL */ > rte_eal_cleanup(); > Reviewed-by: Maxime Coquelin Thanks, Maxime