From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id DCDD823C for ; Fri, 20 Jul 2018 11:37:21 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6E98E21AF1; Fri, 20 Jul 2018 05:37:21 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 20 Jul 2018 05:37:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=8VUMAzespSbzrqVMupGP2V5jp4 AKwgEOTNR3BDc5tgQ=; b=MRFJ7SpxBChNwPMcmNERyIw4CGuAFtKllqSqZba4Xk 9RBLBGNou2DgreSgJnm8ObHqFYbruU+Kf4hu2XhWXC0AIf6DAw9B7eDkUkJSWl5W 7VOg/sLv46JGLOLcd9WnWRC/R++NqdYQcvvA7eW88dKeaSMvSVJuWS3EY8YNZZJB I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=8VUMAz espSbzrqVMupGP2V5jp4AKwgEOTNR3BDc5tgQ=; b=ZkVGNHptcfeIp/zvYuziuf eT7INamYWAg2b+OamBaIIACDumnNkhsGOHK//OQxDjoo60pOY0mE9ubN86HjcKH7 n7N73ehDa4kj+f6Eah5hpIcj/iveKE5Fxut4KJxBB1JrCnQoWoWG7T2sKuZcuFJm AU/ADNpgDbJ0/xRL4WKPB8C4WbfijqZSCqnchfYqlpmwtzKQDGKTQXMRo/ljhVdl EEiNSKG1B50PM2cSoeQ4MxCoaof1epLMglqPMj5EBOGj5sKVTOCFOe97ol8rRV/i BIsSu+9ShaTcqE4RJfvJMWZNuCFA+DrZ0mJIOJznpKk+uZ5ENSAdfNjuzmfi8HOA == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (unknown [207.232.18.42]) by mail.messagingengine.com (Postfix) with ESMTPA id 1F309E405D; Fri, 20 Jul 2018 05:37:19 -0400 (EDT) From: Thomas Monjalon To: Neil Horman Cc: dev@dpdk.org Date: Fri, 20 Jul 2018 11:37:17 +0200 Message-ID: <6254214.EYsJdl83bz@xps> In-Reply-To: <20180719153726.GB20362@hmswarspite.think-freely.org> References: <20180718210609.32547-1-thomas@monjalon.net> <1556161.F30VP9S7cZ@xps> <20180719153726.GB20362@hmswarspite.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] devtools: fix symbol check for filename with space X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jul 2018 09:37:22 -0000 19/07/2018 17:37, Neil Horman: > On Thu, Jul 19, 2018 at 02:09:47PM +0200, Thomas Monjalon wrote: > > 19/07/2018 13:14, Neil Horman: > > > On Wed, Jul 18, 2018 at 11:26:58PM +0200, Thomas Monjalon wrote: > > > > If the patch filename or the temporary file path have a space > > > > in their name, the script check-symbol-change.sh does not work. > > > > The variables for the filenames must be enclosed in quotes > > > > in order to preserve spaces. > > > > > > > > Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") > > > > Cc: nhorman@tuxdriver.com > > > > > > > > Signed-off-by: Thomas Monjalon > > > > --- > > > > v2: one occurence of "$mapfile" was missed in v1 > > > I don't have any issue with this change, but the only way I see to introduce a > > > space into the tempfile name is to set $TMPDIR to '/path/with silly spaces' or > > > something simmilar. I think we discussed this before, but it would alsmot make > > > sense to, instead of quoting everything, instead specify -p ./ to ensure the > > > tempfile has no spaces. > > > > When I save patches from my inbox, the filename has some spaces. > > > > I think quoting variables is mandatory. > > > > > Sure, it doesn't hurt anything really > > Acked-by: Neil Horman Applied