From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 5531F2BBE for ; Mon, 15 Jan 2018 22:52:57 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DAE7920977; Mon, 15 Jan 2018 16:52:56 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 15 Jan 2018 16:52:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=aFg2sbpu0AWXE2SGfH5gb5JiV2 cMES+gCPXw3yef3Mc=; b=eW9TuPjDGMXJEo63kAGYWClal//qSE9VeiewECLnbR kVjMu9YA//jZ222Dn0DrfL5HCAJJleq/JIOQI0TEfIMfZnvd0oUaYw9wvsam4Bqc SJa1ECpR4z+bseetzfHc8ehLrWGlvR6i7ORA9SC3JU0d3FLasG9yu0ZCxdAVWlir g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=aFg2sb pu0AWXE2SGfH5gb5JiV2cMES+gCPXw3yef3Mc=; b=VpI1wv9MvQH8jdF0wQ9DwS vR3BDn/I5z6hrLfzKi3Q2mI+Fs5MsBv4QlGqLqE5xDdknrdpresJVA9pV7FMG1u3 LyyzTYIMiDn0L5Ik7024zem0lHahigIPXSOMZBX8aGdT52Jl+caAQllElpPnupRr QqyJQvSAh5E6AKPDzYMMEK6bA9GFXWcQ2+Lxu74g2cclQiKud+Nz08EpONO5oFkG NKy8vgsdNSFa9TwPqZgxKulm1M6GcaCDUN4cyN3SlYzt2eJRfxEIVIjkSybtEBIK aD+cnLVETak/m62MxQEuJzkh/3nOOIYOJKSYHikdqc4eoW4G6Cvfx6OxYHdhwoWw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8F4B17E353; Mon, 15 Jan 2018 16:52:56 -0500 (EST) From: Thomas Monjalon To: Neil Horman Cc: dev@dpdk.org, john.mcnamara@intel.com, bruce.richardson@intel.com, Ferruh Yigit Date: Mon, 15 Jan 2018 22:52:25 +0100 Message-ID: <6261725.cSDxTUqfeb@xps> In-Reply-To: <20180115190545.25687-1-nhorman@tuxdriver.com> References: <20180115190545.25687-1-nhorman@tuxdriver.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] checkpatches.sh: Add checks for ABI symbol addition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 21:52:57 -0000 15/01/2018 20:05, Neil Horman: > Recently, some additional patches were added to allow for programmatic > marking of C symbols as experimental. The addition of these markers is > dependent on the manual addition of exported symbols to the EXPERIMENTAL > section of the corresponding libraries version map file. The consensus > on review is that, in addition to mandating the addition of symbols to > the EXPERIMENTAL version in the map, we need a mechanism to enforce our > documented process of mandating that addition when they are introduced. > To that end, I am proposing this change. It is an addition to the > checkpatches script, which scan incoming patches for additions and > removals of symbols to the map file, and warns the user appropriately Thanks for working on this. I won't pretend that I understand anything in this awk script :) I think it would be better to put this code in a new script, let's say check-symbol-change.sh, and call it in checkpatches.sh. It would be just moving functions, add your copyright, and list the new script in your MAINTAINERS section "ABI versioning".