From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-we0-f180.google.com (mail-we0-f180.google.com
 [74.125.82.180]) by dpdk.org (Postfix) with ESMTP id F004A6A7F
 for <dev@dpdk.org>; Fri, 20 Jun 2014 16:08:13 +0200 (CEST)
Received: by mail-we0-f180.google.com with SMTP id x48so3850128wes.39
 for <dev@dpdk.org>; Fri, 20 Jun 2014 07:08:31 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=qB23XoLHn2YgeDmwYEd9QP4sJsgfmvc08xyLh4k2Vhc=;
 b=OEiN87J2OFdumsjSZqourRf0JvAyhdTgcNiqQ6iGiOF4RoXrWKXTYjhpUXv4jkElSd
 XzDluz/TeyBsWgd4iLHgv6znLXs14+V3/e5pEDfC96QUxiNjdxCGBcDlNE7NVfL81PGm
 f8l4N0bex2N9O1E9q9CwVSk2QJL3PsDhiMHniNaaO1XMWgJNpeTHO6yu8aEH7MI6FQWy
 qPNHG1iubIcp1AXOAWUtyR2Fv+MrZjMcYs3LEOodIAMroCtQmwJHUn9J+ip5O3Sw55xo
 iYBf2FYRQkm9CCoGnAmatkMa9bQlcSiAO0l3qj7tludNAh9EXCmp7F4SoQBoNr/6fPpQ
 mhTw==
X-Gm-Message-State: ALoCoQno6ZZsA7nemBF7T5eMko8wm7V7nfGjgjZBI14/3uc11flWtqSfSMF1labfn9HD0o2Juwxq
X-Received: by 10.180.99.166 with SMTP id er6mr4513291wib.48.1403273311404;
 Fri, 20 Jun 2014 07:08:31 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id gd5sm15838425wjb.40.2014.06.20.07.08.30
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 20 Jun 2014 07:08:30 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Helin Zhang <helin.zhang@intel.com>
Date: Fri, 20 Jun 2014 16:08:28 +0200
Message-ID: <6265238.1xJbmmqJzt@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; )
In-Reply-To: <1403244889-21358-3-git-send-email-helin.zhang@intel.com>
References: <1403244889-21358-1-git-send-email-helin.zhang@intel.com>
 <1403244889-21358-3-git-send-email-helin.zhang@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/7] i40evf: support configuring crc
	stripping hw offload
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Jun 2014 14:08:14 -0000

Hi Helin,

2014-06-20 14:14, Helin Zhang:
> In VF driver, crc stripping hw offload is enabled or not, according
> to the configurations in config file.
> 
> Signed-off-by: Helin Zhang <helin.zhang@intel.com>
> Acked-by: Cunming Liang <cunming.liang@intel.com>
> Acked-by: Jing Chen <jing.d.chen@intel.com>
[...]
>  static int
> -i40evf_dev_configure(__rte_unused struct rte_eth_dev *dev)
> +i40evf_dev_configure(struct rte_eth_dev *dev)
>  {
> +	struct rte_eth_conf* conf = &dev->data->dev_conf;
> +
> +#ifdef RTE_LIBRTE_I40E_PF_DISABLE_STRIP_CRC
> +	if (conf->rxmode.hw_strip_crc) {
> +		conf->rxmode.hw_strip_crc = 0;
> +		PMD_DRV_LOG(INFO, "VF can not enable hw CRC stripping\n");
> +	}
> +#else
> +	if (!conf->rxmode.hw_strip_crc) {
> +		conf->rxmode.hw_strip_crc = 1;
> +		PMD_DRV_LOG(INFO, "VF can not disable hw CRC stripping\n");
> +}
> +#endif
> +
>  	return 0;
>  }

Please, I don't understand why CRC stripping must be configured at build time.
I understand VF capability depends of the PF configuration, but we should be 
able to configure it at run time.

-- 
Thomas