From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1B92A04DB; Wed, 9 Dec 2020 20:05:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 18F90BE79; Wed, 9 Dec 2020 20:05:55 +0100 (CET) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by dpdk.org (Postfix) with ESMTP id 93B60BE77 for ; Wed, 9 Dec 2020 20:05:51 +0100 (CET) Received: by mail-pl1-f171.google.com with SMTP id j1so1454131pld.3 for ; Wed, 09 Dec 2020 11:05:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=ZXVr5oht+X6bgje22vtITra2dq9xWESX3BD24mu9AgU=; b=1zRbgt79r9Wzp2ztqkWwHE2EKz/8axL3VOm0WJ/319O1z9IJtun1eqfSS391xE1cc4 D2l3x9/vzdSxNalBm4APA6x6qLWXmoTG29t+Eq9MO/NULBYhljukcNjdiVZXRPTcIEKS vk15J9eDj49LHxwOipckvBg6yYpTPBPK4uk+bWr/oEmWzfOqqjQkHHtiMLPEBXGeCycS cTXL08bbZl7VDGlkjP8aAcAiWdzYyYAXWbNoiEWPyfi4dWze5I5pNRDIMERAZjdFP5zj 5Nrxwy/OhC+ADIb2WLcKtHDjvcjSyJChJUd0CNn2x6gz4ATGl4PPMlg+xDX6K+GeAnNu sE9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=ZXVr5oht+X6bgje22vtITra2dq9xWESX3BD24mu9AgU=; b=bSgDs+PWlXOZX35MGayNyh5Vo7dwdblfiSVnB6J/NQI8mad0mFfh8a8jqW8QVknX01 DV3S0kU+fcZZ8BzxNaGrWJ5uzaSOYyV0Ig3bOQFaODlkN/1ss4xAu+/3WjkOZnYaDJef Leqp4+qCQsIoLYfDLjXraXji9yI9VO5TNRDtOdTaWKamUHRfJTTHYyBgbCq3sm1TQze1 Q5reim6Z1W+HCTQ0wDQgvDw0lEARUWqE2jo9vKsIW6F+ZQIqpK0Mc4KYC4+8GXlrPw2Z d/tJ7+VAyP5omd1EM8fbWuc6GmZikbSFhIOPNBGSMHVx3tdaV9p3Jrb8Ccp8vNveXkEL ErBg== X-Gm-Message-State: AOAM530ZxxJm5SB7a5GnIjuOO6HmZ/sFWJFrm63lH0hTmmyoiOskmO8F d7quCj70bRcRGMrCOoPzQ7v0sA== X-Google-Smtp-Source: ABdhPJz8E9Q+d1hiB3yGqO5g5E6Ewwxx+zJZiqnm5catYzCMOD88uYW1mMklgeCTbOLrTSeHJg3fhw== X-Received: by 2002:a17:90b:2317:: with SMTP id mt23mr3549756pjb.2.1607540749564; Wed, 09 Dec 2020 11:05:49 -0800 (PST) Received: from ?IPv6:2600:1700:6b0:fde0:38f6:904:9f94:4f03? ([2600:1700:6b0:fde0:38f6:904:9f94:4f03]) by smtp.gmail.com with ESMTPSA id d15sm3095516pjr.27.2020.12.09.11.05.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Dec 2020 11:05:48 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) From: Andrew Boyer In-Reply-To: <55dfbcec-4974-da24-8a46-adbbc57850b4@intel.com> Date: Wed, 9 Dec 2020 14:05:46 -0500 Cc: dev@dpdk.org, Alfredo Cardigliano , Thomas Monjalon , David Marchand Content-Transfer-Encoding: quoted-printable Message-Id: <6266CE88-1FCD-471D-8390-33BA77707BD7@pensando.io> References: <20201203203418.15064-1-aboyer@pensando.io> <20201204201646.51746-4-aboyer@pensando.io> <8c32bc91-6583-cd3d-a1e6-979bda122eb3@intel.com> <50603b0a-07a7-b413-b4c5-1fd535befd3f@intel.com> <55dfbcec-4974-da24-8a46-adbbc57850b4@intel.com> To: Ferruh Yigit X-Mailer: Apple Mail (2.3608.120.23.2.4) Subject: Re: [dpdk-dev] [PATCH v3 3/9] net/ionic: update documentation and MAINTAINERS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Dec 9, 2020, at 12:15 PM, Ferruh Yigit = wrote: >=20 > On 12/9/2020 4:24 PM, Andrew Boyer wrote: >>> On Dec 9, 2020, at 10:24 AM, Ferruh Yigit > wrote: >>>=20 >>> On 12/9/2020 2:36 PM, Andrew Boyer wrote: >>>> Please respond to my questions this time. I have ~70 more patches = to post by December 20. >>>>> On Dec 9, 2020, at 7:03 AM, Ferruh Yigit >> wrote: >>>>>=20 >>>>> On 12/4/2020 8:16 PM, Andrew Boyer wrote: >>>>>> The UNMAINTAINED flag will be removed in a future patch. >>>>>> Signed-off-by: Andrew Boyer >> >>>>>> --- >>>>>> MAINTAINERS | 3 ++- >>>>>> doc/guides/nics/features/ionic.ini | 2 ++ >>>>>> doc/guides/nics/ionic.rst | 13 +++++++------ >>>>>> 3 files changed, 11 insertions(+), 7 deletions(-) >>>>>> diff --git a/MAINTAINERS b/MAINTAINERS >>>>>> index eafe9f8c4..6534983c1 100644 >>>>>> --- a/MAINTAINERS >>>>>> +++ b/MAINTAINERS >>>>>> @@ -841,7 +841,8 @@ F: drivers/net/pfe/ >>>>>> F: doc/guides/nics/features/pfe.ini >>>>>> Pensando ionic - UNMAINTAINED >>>>>> -M: Alfredo Cardigliano >> >>>>>> +M: Andrew Boyer = >> >>>>>> +M: Pensando Drivers >> >>>>>=20 >>>>> Same comment from previous version, please don't add group as = maintainer, only actual people. >>>> I responded to your original comment about this back in November. = Is there an official DPDK policy against doing this? Is it your = preference? We would very much prefer to have this in the file as a = fallback. As long as there is still at least one person listed, what is = the harm? >>>=20 >>> There is no official policy against it as far as I know. >>>=20 >>> The problem with the groups is we don't know who is behind it, it = blurs who is the owner/responsible of the component. Actual people makes = it clear that who is responsible. >>>=20 >>> Why do you prefer to add a group as maintainer? >> Because if I am on leave for some reason, one of the other handful of = maintainers might be able to help someone with a problem or a question. >> If I am listed specifically, doesn=E2=80=99t that make clear =E2=80=9Cw= ho is the owner/responsible=E2=80=9D for ionic PMD? What harm does = having drivers@ listed do? >=20 > If you want backups, pick and list a few of those handful maintainers = and add to the list, so we can know who they are. >=20 > As already said problem is we don't know who is behind a group, if = they are reliable or not, or is there really someone or not, what = happens if group become silent? > You can cc that group in your patches, that is commonly done, so they = can be part of the development process, but the maintainers file is to = define responsible people, adding a group is hiding actual responsible = people. Fine. Perhaps you could document somewhere that this requirement exists = to save future people the trouble. >>>>>> F: drivers/net/ionic/ >>>>>> F: doc/guides/nics/ionic.rst >>>>>> F: doc/guides/nics/features/ionic.ini >>>>>> diff --git a/doc/guides/nics/features/ionic.ini = b/doc/guides/nics/features/ionic.ini >>>>>> index 083c7bd99..dd29dbed6 100644 >>>>>> --- a/doc/guides/nics/features/ionic.ini >>>>>> +++ b/doc/guides/nics/features/ionic.ini >>>>>> @@ -8,6 +8,7 @@ Speed capabilities =3D Y >>>>>> Link status =3D Y >>>>>> Link status event =3D Y >>>>>> Queue start/stop =3D Y >>>>>> +Lock-free Tx queue =3D Y >>>>>=20 >>>>> Are you sure this is supported? >>>>> Since it is not advertised as capability, I think this can't be = claimed as supported, but still even after this is added as capability, = can you please confirm your device supports multiple core enqueue to = same queue without locks? >>>> I misunderstood the meaning of this flag, will remove. >>>>>> MTU update =3D Y >>>>>> Jumbo frame =3D Y >>>>>> Scattered Rx =3D Y >>>>>> @@ -19,6 +20,7 @@ Unicast MAC filter =3D Y >>>>>> RSS hash =3D Y >>>>>> RSS key update =3D Y >>>>>> RSS reta update =3D Y >>>>>> +SR-IOV =3D Y >>>>>=20 >>>>> Can you please explain what is exactly supported? Like can DPDK = drive both PF & VF? >>>> Yes. The PMD does not distinguish between PFs and VFs. >>>>>=20 >>>>> <...> >>>>>=20 >>>>>> @@ -7,15 +7,16 @@ IONIC Driver >>>>>> The ionic driver provides support for Pensando server adapters. >>>>>> It currently supports the below models: >>>>>> -- `Naples DSC-25 = = >= >`_ >>>>>> -- `Naples DSC-100 = = = = >>`_ >>>>>> +- DSC-25 dual-port 25G Distributed Services Card >>>>>> +- DSC-100 dual-port 100G Distributed Services Card >>>>>>=20 >>>>>=20 >>>>> Same comment from previous version, can you provide link for these = devices, it is hard to find the devices from the main site. >>>> And my same response from your previous comment. I do not control = the website and do not wish to put stale PDF links in this document, = which will live forever. The text includes the URL of the page = containing links to the PDFs. Why is this not acceptable? >>>=20 >>> The request is to put links to the products that you are providing = the driver for. This is to help people that are already interested your = driver and reading your driver document, to reach to the product = information easily. >>>=20 >>> The request is NOT to provide pdf etc, just a reference to the = product. Don't you advertise your product in your official web site? If = your product information is not visible/hidden, why you are providing = the open source drivers for it? >> Does this line in the doc not satisfy your request? >> +The `Documents >`_ page contains Product Briefs and = other product information. >=20 > No it doesn't, it is not clear which document/product you are = referring to. > Why it is hard to provide the link of products that your driver is = for? >=20 Fine. These links will become stale next time the files are updated, = just like the links in the 20.02-20.11 releases are stale. = https://pensando.io/wp-content/uploads/2020/03/Pensando-DSC-25-Product-Bri= ef.pdf = https://pensando.io/wp-content/uploads/2020/03/Pensando-DSC-100-Product-Br= ief.pdf -Andrew