From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id 95CEA1F5 for ; Tue, 16 Dec 2014 12:23:02 +0100 (CET) Received: by mail-wi0-f177.google.com with SMTP id l15so12131997wiw.10 for ; Tue, 16 Dec 2014 03:23:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=ivVpMjd6IGDAyqMEZp61oQ1h0KRqtd3kexalDMh36fc=; b=culfgJynBaIOoHRy9Wr+zWxnPhECTqHkR5FyCWCDCn/K98wHXFDJo3dFk/cgZYy3h/ 7lMXRF4oTMqGncxIRPSM1zLCdFVr7+fPd+seyilWKgDbT9HOpe6ZwKNpf1MtiXK4vqpe BpgB+BkGkWAcjBWoAVEbU7BSlpGJ+wPBLH/7Vcpt4VTy5QXUExlD8SVIBv91P06FOPWG VSdlOIIOVdvIJJl0qJA90yO4aD30Kwp2K3TkokPHgX4b/+PsegQvtexRjHaKJkbQOCbK VIMuoo1hr/bESAbARbt2FxfUDS1JoYMRX56QQGCNJcr8t8junWoUuzDe6bCztOp/PcQc soKA== X-Gm-Message-State: ALoCoQm+Hv782Yo+jsvr+tQccoay/S2qxNOcktiryg2Zz0X5LSa/Hay3hWByv+RVKHYcK5f+3oQF X-Received: by 10.180.75.199 with SMTP id e7mr3926956wiw.21.1418728982380; Tue, 16 Dec 2014 03:23:02 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id dv9sm1766496wib.14.2014.12.16.03.23.00 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Dec 2014 03:23:01 -0800 (PST) From: Thomas Monjalon To: Declan Doherty Date: Tue, 16 Dec 2014 12:22:36 +0100 Message-ID: <6278160.abDBhLteg6@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1418728549-31244-1-git-send-email-declan.doherty@intel.com> References: <1418728549-31244-1-git-send-email-declan.doherty@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] bond: vlan flags misinterpreted in xmit_slave_hash function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Dec 2014 11:23:02 -0000 Hi Declan, 2014-12-16 11:15, Declan Doherty: > - Split transmit hashing function into separate functions to reduce branching > and to make code clearer. > - Add IPv4 IHL parameters to rte_ip.h > - Fixed VLAN tag support in hashing functions and add support for TCP > in layer 4 header hashing. > - Fixed incorrect flag set in test application packet generator. You forgot to describe the problem you are solving. You seem fixing something but I'm afraid this patch is too big to be safely integrated in 1.8.0. Was it your goal? > Signed-off-by: Declan Doherty > --- > app/test/packet_burst_generator.c | 2 +- > lib/librte_net/rte_ip.h | 2 + > lib/librte_pmd_bond/rte_eth_bond_api.c | 8 ++ > lib/librte_pmd_bond/rte_eth_bond_pmd.c | 161 ++++++++++++++++------------- > lib/librte_pmd_bond/rte_eth_bond_private.h | 15 +++ > 5 files changed, 115 insertions(+), 73 deletions(-) > [...] > --- a/lib/librte_net/rte_ip.h > +++ b/lib/librte_net/rte_ip.h > @@ -109,6 +109,8 @@ struct ipv4_hdr { > (((b) & 0xff) << 16) | \ > (((c) & 0xff) << 8) | \ > ((d) & 0xff)) > +#define IPV4_HDR_IHL_MASK (0x0f) > +#define IPV4_FIELD_WIDTH (4) These new definitions require some doxygen comments. Thanks -- Thomas