DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] raw/ifpga/base: fix a return error value in ifpga_fme_pr
@ 2018-05-16  8:49 Xu, Rosen
  2018-05-21 14:13 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Xu, Rosen @ 2018-05-16  8:49 UTC (permalink / raw)
  To: dev, thomas
  Cc: rosen.xu, roy.fan.zhang, declan.doherty, bruce.richardson,
	shreyansh.jain, ferruh.yigit, konstantin.ananyev, tianfei.zhang,
	song.liu, hao.wu, gaetan.rivet, stable

From: "Zhang, Tianfei" <tianfei.zhang@intel.com>

fix a return error value by DPDK Coverity static code analysis

Fixes: 56bb54ea1bdf ("raw/ifpga/base: add Intel FPGA OPAE share code")
Coverity issue: 279448
Cc: stable@dpdk.org

Signed-off-by: Zhang, Tianfei <tianfei.zhang@intel.com>
---
 drivers/raw/ifpga_rawdev/base/ifpga_fme_pr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/raw/ifpga_rawdev/base/ifpga_fme_pr.c b/drivers/raw/ifpga_rawdev/base/ifpga_fme_pr.c
index 49d8cc5..ec0beeb 100644
--- a/drivers/raw/ifpga_rawdev/base/ifpga_fme_pr.c
+++ b/drivers/raw/ifpga_rawdev/base/ifpga_fme_pr.c
@@ -139,7 +139,7 @@ static int fme_pr_write(struct ifpga_fme_hw *fme_dev,
 			pr_credit--;
 		} else {
 			WARN_ON(1);
-			return -EINVAL;
+			ret = -EINVAL;
 			goto done;
 		}
 	}
-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH] raw/ifpga/base: fix a return error value in ifpga_fme_pr
  2018-05-16  8:49 [dpdk-dev] [PATCH] raw/ifpga/base: fix a return error value in ifpga_fme_pr Xu, Rosen
@ 2018-05-21 14:13 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2018-05-21 14:13 UTC (permalink / raw)
  To: tianfei.zhang
  Cc: Xu, Rosen, dev, roy.fan.zhang, declan.doherty, bruce.richardson,
	shreyansh.jain, ferruh.yigit, konstantin.ananyev, song.liu,
	hao.wu, gaetan.rivet

16/05/2018 10:49, Xu, Rosen:
> From: "Zhang, Tianfei" <tianfei.zhang@intel.com>
> 
> fix a return error value by DPDK Coverity static code analysis
> 
> Fixes: 56bb54ea1bdf ("raw/ifpga/base: add Intel FPGA OPAE share code")
> Coverity issue: 279448
> Cc: stable@dpdk.org

Not for stable, ifpga was introduced in 18.05.

> Signed-off-by: Zhang, Tianfei <tianfei.zhang@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-05-21 14:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-16  8:49 [dpdk-dev] [PATCH] raw/ifpga/base: fix a return error value in ifpga_fme_pr Xu, Rosen
2018-05-21 14:13 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).