From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2A0AA00BE; Tue, 15 Mar 2022 18:35:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3493B40395; Tue, 15 Mar 2022 18:35:45 +0100 (CET) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id 09F3C4014F for ; Tue, 15 Mar 2022 18:35:43 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 7C0043201FC9; Tue, 15 Mar 2022 13:35:42 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 15 Mar 2022 13:35:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; bh=yER5gdQqJJ2H3h 84ZuEuqJsU6IH6OoDpFuASLtqXuXs=; b=ao5SLWK3w3FnhP0X2M7e/XjG3hb4cc OAG1oKvVAwWLmP5JTzOP6UX+/6NppHS71Xk/x3oBt7lxtA59bRj4ZGuuuMOkjbqv xQTCnrbCWIUEiGZEA7k47Iw5H9DLoMmfqTbOGEIaA+DEUxi7mV4ImF4qE9P0URTZ MByyy4IVatMyYcFQNhCeIWGO9cYAyNCf52Z4G+QuGutKgG6j+5BZ2x3dWSpSONd5 EZXAoKiN6QezJbkAR+BFGglBtFaSGRWigHUEyY+n4HPKvrhr3VY3gLcSIdOh/euG CdBXSnn4H7luk6Fxc9lvJtop/GK4ClpZOxtImrJ9d/jlEBAZk5Qs9AoA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=yER5gdQqJJ2H3h84ZuEuqJsU6IH6OoDpFuASLtqXu Xs=; b=hUlJ5a6dLPpJ2f2E17/0g9XXZysOu75X96a8AtvzWM5nr7togwRYgmZoA bHvoRG7WDuHMY7ivn1nyPakPk+YofEgWBBjxT9TRrg/i2qBIkKPb5ouG+edSTap4 2C9SrVu3FoJbbhljDYfstsEI21Oe9RCykbgg6z9yLdw31RyaZkw8YqD1jiq561tX aXufm0hodlJGdUNv6B9tACTwpXAXnXdF8t4bPQlZq4fOtBGb72SO+RLrlreZ5AO+ R1h4/4PX3tq8EC8do+k8W9e5EC8SzU/G6zKlDlbOomkGzRoDLUdREA8p1kOqffN/ 9M7ZCnImsMfl3dDUSucBw9nG2XEWw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeftddguddtvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 15 Mar 2022 13:35:40 -0400 (EDT) From: Thomas Monjalon To: "Dumitrescu, Cristian" , "Ajmera, Megha" , "Singh, Jasvinder" Cc: "dev@dpdk.org" , "Mcnamara, John" , "Thakur, Sham Singh" , "david.marchand@redhat.com" Subject: Re: [PATCH v2] Revert "sched: enable traffic class oversubscription unconditionally" Date: Tue, 15 Mar 2022 18:35:39 +0100 Message-ID: <6289676.K2JlShyGXD@thomas> In-Reply-To: References: <4dfde108-70ff-d916-4b42-5048d1a82042@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 15/03/2022 18:25, Singh, Jasvinder: > From: Dumitrescu, Cristian > > From: Thomas Monjalon > > > 14/03/2022 13:27, Megha Ajmera: > > > > This reverts commit d91c4b1bb5a938734fe8e66da8f965304919f38e. > > > > > > > > When enabling TC OV unconditionally, it is observed the performance > > > > drops by ~20% hence reverting this commit. > > > > > > > > Fixes: d91c4b1bb5a9 ("sched: enable traffic class oversubscription > > > > unconditionally") > > > > > > > > Signed-off-by: Megha Ajmera > > > > > > Repeating what was suggested yesterday in a private email. > > > Sorry Megha, I don't know why you were not Cc'ed by your Intel > > colleagues. > > > > > > David and I suggested to drop the code which was enabled by the > > > compilation flag RTE_SCHED_SUBPORT_TC_OV, which was kind of dead > > code > > > before enabling it unconditionally. > > > This way you maintain the performance of the default compilation, and > > > you can re-introduce the feature, if proven useful, in the next > > > release with a runtime option. > > > > > > > > > > After talking with Jasvinder and a few other folks, we think the best option at > > this point is to keep the code as it is now in the repository, so no further > > change at this point. > > > > There is a small performance glitch that we plan to fix shortly after the 22.03 > > release by making the Traffic Class Oversubscription feature conditionally > > enabled at run-time as opposed to enabled unconditionally. Megha already > > sent a patch on this, which is under review. > > > > Is this OK with you? > > > > Thank you for your help, we don't want to delay the release in any way! > > +1 OK so I mark this revert as rejected. Thanks.