From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 3E4981041 for ; Mon, 15 Jan 2018 12:15:08 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E4B5F20BBD; Mon, 15 Jan 2018 06:15:07 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 15 Jan 2018 06:15:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=F6uh+u2T7nDjzXtPoQP/2Uy3dZ lJapP4r2546ZH9lc4=; b=B/q7o9flDm6XIUUFnV/jFeuMOrUQpvyTRlqzCzcEZv M7GxqXr9uObS/M9DPe9KX21O3iFxwgKf4iIjWBKi+lWlO+ClR4C5GC9CJhGwJfcs yyU32Jcd4nEMtn/XI1l3Ten55c1/SfB3t4SZKnVzUTHKPn6eraEoKYhHDi0eQvld Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=F6uh+u 2T7nDjzXtPoQP/2Uy3dZlJapP4r2546ZH9lc4=; b=V1k9rgWPfrmsFhXrPSJEoO cDyWVWm4KxIGVGTABmpw3+4vhkQdKB+ASMwyZ37g0lIinXOJjP4NDs9ECZXnhArK Xqqle+GAi0T/8Piq5GOivudfi6/wi4ZhE3DX/hRCRl9vX/i2sczxXzcJR4Ajb8Pc /4ynkx9LFpOLnEWIUp/qMjAhJ8gzzg/pqyQUwE/hvV/rLaJetvew3TdIuj7qpbQ+ W417+j1JXM2j19dv5XVcyLJpxCaNMDyTTPDaMpldfPCffYtMq93QbacUL27SX+QP AFe0H50VE9vjC5+U/rE4fEEuw75IfO1s6o/TyUXO89x/qnoFuiYh3+U5KW7YwzYw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 95CF87E4C6; Mon, 15 Jan 2018 06:15:07 -0500 (EST) From: Thomas Monjalon To: Prashant Bhole Cc: dev@dpdk.org, Ferruh Yigit , Pablo de Lara Date: Mon, 15 Jan 2018 12:14:36 +0100 Message-ID: <6297491.ryl7qXoRam@xps> In-Reply-To: <8ac37bf5-0fa7-ebb9-6b56-1247ed972e0b@intel.com> References: <20171211073129.4176-1-bhole_prashant_q7@lab.ntt.co.jp> <8ac37bf5-0fa7-ebb9-6b56-1247ed972e0b@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] examples: remove unnecessary function calls X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 11:15:08 -0000 11/12/2017 19:12, Ferruh Yigit: > On 12/10/2017 11:31 PM, Prashant Bhole wrote: > > Removed rte_eth_dev_info_get() calls and declaration of struct rte_eth_dev_info > > where info is not used anymore > > > > Signed-off-by: Prashant Bhole > > Reviewed-by: Ferruh Yigit > > At any point in the history were they used? If so, can you please add the commit > making them unnecessary with "Fixes" tag? Maybe some were used. The first one I've checked was never used. Not worth spending time on it in my opinion. Applied, thanks