From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id B6446DED for ; Tue, 21 Aug 2018 09:21:14 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 1689140006C; Tue, 21 Aug 2018 07:21:13 +0000 (UTC) Received: from [192.168.1.16] (85.187.13.33) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 21 Aug 2018 08:21:00 +0100 To: Jeff Guo , , , , , , , , , , , , , CC: , , , References: <1534503091-31910-1-git-send-email-jia.guo@intel.com> <1534503091-31910-3-git-send-email-jia.guo@intel.com> <55ba4160-33e4-86a3-d5e3-4a414d9c5a8b@solarflare.com> <518f0c92-0faf-4791-2737-c764e20bba7c@intel.com> From: Andrew Rybchenko Message-ID: <62a597e9-a5a9-d21e-d075-777c68c2a59e@solarflare.com> Date: Tue, 21 Aug 2018 10:20:54 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <518f0c92-0faf-4791-2737-c764e20bba7c@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [85.187.13.33] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24044.003 X-TM-AS-Result: No-13.490000-8.000000-10 X-TMASE-MatchedRID: nVQUmLJJeyYOwH4pD14DsPHkpkyUphL9MZm0+sEE9mtnnK6mXN72m1mB Y2oLO+3hR5KBY5usn0yNsQYXWuFqRHAvdl/gU+kWoMfp2vHck9W4vBuE2X0HlZbCaSvAFLPvT85 +SH/4Avg0sdOKlXfQa4I5EZoyXQOrGY3jQI0kXUejrlYm3WTU7yu3H/wZaHmbmyiLZetSf8my5/ tFZu9S3Ku6xVHLhqfxIAcCikR3vq9fZq4Yg8lQkQZ3UYKvf36hgJJxO3LrhLJlmuC5eYRuk5N03 DnoOzjN X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--13.490000-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24044.003 X-MDID: 1534836074-5jKpsYFAua1n Subject: Re: [dpdk-dev] [PATCH v1 2/5] eal: add a new req event to device event X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2018 07:21:15 -0000 On 21.08.2018 09:56, Jeff Guo wrote: > hi, andrew > > > On 8/20/2018 6:37 PM, Andrew Rybchenko wrote: >> On 17.08.2018 13:51, Jeff Guo wrote: >>> Add a new req event in eal device event for vfio hotplug. When the req >>> request send from the vfio kernel module be detected, vfio userpace >>> driver could use this event to notify the app to handler it. >>> >>> Signed-off-by: Jeff Guo >>> --- >>>   lib/librte_eal/common/include/rte_dev.h | 1 + >>>   1 file changed, 1 insertion(+) >>> >>> diff --git a/lib/librte_eal/common/include/rte_dev.h >>> b/lib/librte_eal/common/include/rte_dev.h >>> index ff580a0..0324c84 100644 >>> --- a/lib/librte_eal/common/include/rte_dev.h >>> +++ b/lib/librte_eal/common/include/rte_dev.h >>> @@ -30,6 +30,7 @@ extern "C" { >>>   enum rte_dev_event_type { >>>       RTE_DEV_EVENT_ADD,    /**< device being added */ >>>       RTE_DEV_EVENT_REMOVE,    /**< device being removed */ >>> +    RTE_DEV_EVENT_REQ,    /**< device being removed */ >> >> Comment is the copy of previous one. >> > > You are right here, even we process these type in the same way but > should be considered it as the different type if we exactly want to > add new one. > so base on the interpret from the vfio kernel driver, this req event > is used to require the user space to release the device resources, so > it should be > interpret it by "device release request". If you object and have other > better idea, let me know. If so, may be it should be RTE_DEV_EVENT_RELEASE_REQ, since just _REQ is really misleading. > >>>       RTE_DEV_EVENT_MAX    /**< max value of this enum */ >>>   }; >>