From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, David Wilder <dwilder@us.ibm.com>,
stable@dpdk.org, chaozhu@linux.vnet.ibm.com
Subject: Re: [dpdk-dev] [PATCH v3] mem: Fix anonymous mapping on Power9.
Date: Wed, 20 Feb 2019 16:44:07 +0000 [thread overview]
Message-ID: <62bd3fe6-a3f4-8874-d49f-47703c364d65@intel.com> (raw)
In-Reply-To: <1920329.P3yoKYTqQv@xps>
On 20-Feb-19 4:27 PM, Thomas Monjalon wrote:
> 20/02/2019 17:04, Burakov, Anatoly:
>> On 16-Nov-18 5:35 PM, David Wilder wrote:
>>> Removed the use of MAP_HUGETLB for anonymous mapping on ppc64. The
>>> MAP_HUGETLB had previously been added to workaround issues on IBM Power8
>>> systems when mapping /dev/zero (see: commit
>>> 284ae3e9ff9a92575c28c858efd2c85c8de6d440). In the current code the
>>> MAP_HUGETLB flag will cause the anonymous mapping to fail on Power9.
>>> Note, Power8 is currently failing to correctly mmap Hugepages, with and
>>> without this change.
>>>
>>> Signed-off-by: David Wilder <dwilder@us.ibm.com>
>>> Reviewed-by: Pradeep Satyanarayana <pradeep@us.ibm.com>
>>> ---
>>
>> The changes are contained entirely to POWER9 code paths/docs, so while i
>> cannot verify them working for obvious reasons, i have no objections to
>> this patch.
>>
>> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
>
> It was applied a long time ago :)
>
I can see that now :) Someone replied to it and it bubbled up my inbox...
--
Thanks,
Anatoly
prev parent reply other threads:[~2019-02-20 16:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 17:35 David Wilder
2018-11-18 13:41 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2018-11-27 10:50 ` Kevin Traynor
2019-02-18 15:46 ` Thomas Monjalon
2019-02-20 8:07 ` Chao Zhu
2019-02-20 16:04 ` [dpdk-dev] " Burakov, Anatoly
2019-02-20 16:27 ` Thomas Monjalon
2019-02-20 16:44 ` Burakov, Anatoly [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62bd3fe6-a3f4-8874-d49f-47703c364d65@intel.com \
--to=anatoly.burakov@intel.com \
--cc=chaozhu@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=dwilder@us.ibm.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).