From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id A6114271; Wed, 20 Feb 2019 17:44:10 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Feb 2019 08:44:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,391,1544515200"; d="scan'208";a="125906290" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.110]) ([10.237.220.110]) by fmsmga008.fm.intel.com with ESMTP; 20 Feb 2019 08:44:08 -0800 To: Thomas Monjalon Cc: dev@dpdk.org, David Wilder , stable@dpdk.org, chaozhu@linux.vnet.ibm.com References: <20181116173538.5321-1-dwilder@us.ibm.com> <22f8d817-c649-2770-b86e-5229559bb13b@intel.com> <1920329.P3yoKYTqQv@xps> From: "Burakov, Anatoly" Message-ID: <62bd3fe6-a3f4-8874-d49f-47703c364d65@intel.com> Date: Wed, 20 Feb 2019 16:44:07 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <1920329.P3yoKYTqQv@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] mem: Fix anonymous mapping on Power9. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Feb 2019 16:44:11 -0000 On 20-Feb-19 4:27 PM, Thomas Monjalon wrote: > 20/02/2019 17:04, Burakov, Anatoly: >> On 16-Nov-18 5:35 PM, David Wilder wrote: >>> Removed the use of MAP_HUGETLB for anonymous mapping on ppc64. The >>> MAP_HUGETLB had previously been added to workaround issues on IBM Power8 >>> systems when mapping /dev/zero (see: commit >>> 284ae3e9ff9a92575c28c858efd2c85c8de6d440). In the current code the >>> MAP_HUGETLB flag will cause the anonymous mapping to fail on Power9. >>> Note, Power8 is currently failing to correctly mmap Hugepages, with and >>> without this change. >>> >>> Signed-off-by: David Wilder >>> Reviewed-by: Pradeep Satyanarayana >>> --- >> >> The changes are contained entirely to POWER9 code paths/docs, so while i >> cannot verify them working for obvious reasons, i have no objections to >> this patch. >> >> Acked-by: Anatoly Burakov > > It was applied a long time ago :) > I can see that now :) Someone replied to it and it bubbled up my inbox... -- Thanks, Anatoly