From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6FD4A0548; Thu, 8 Sep 2022 18:25:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C2333427EC; Thu, 8 Sep 2022 18:24:55 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2054.outbound.protection.outlook.com [40.107.223.54]) by mails.dpdk.org (Postfix) with ESMTP id ECDDB42685 for ; Thu, 8 Sep 2022 18:24:53 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PWNRfzMy+pnYFT5VjiS4uRxhKoWkY8Kz4mAYvB5nHbh+3UhACsOLKPKms1trUK/BFcICjSXpF6kS6ftfFnEHLUUs3kqKDAIxhqeAO9ueUdMr9zCcjX1uAbnyoypyTMN0P3HpGYYv2+ZAWhybRA2gGFrWAb57IoYZrRok4ncYBrnwki0wMwBqw12cpt1uaXDahFHk57mJ1HU3QwZrLnLwnlWy36JY0n14MiebxlUtfSaX9miYt36GiyxOayfFLSlXZW+BNuS+any3hu9Lzym0Ovjaj++ssyMafYsM6jscPgov4NIX4jEmym8YLoUtnMS/HFbqP/xFgLszwzUf+EKvGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=02Wi6K/3IDeak+NQi0783tWC+VTJ/IbDoJTDlD0m1z8=; b=OdcwebAjaqmhua2ZVOUqdlC6va09g6+QvPv/rh7NaxA490nCPRB6dwu/Hpoj8DdVd/1O2GwiECvvUitPTPHEmqdWAFtvr8lnL5LQOb0CuV6Zj078e4CqQyPHCVYt3VotkQYu+LwoMzHqMsAH/w+USy7ADfM5ChM0pZ0j5HCpUZ0bZDUnVkzJkiCP1QQrSdnaoBNvUdSmzGBH0RBGCEGvTUePdLOG6icr7clPGF0n/Z/p+bl5m+t3hDSzdbFFUl+5a11OC1R3BMnitG0Lxo22alcvMfA+g4QOGrTXcqCKwl/V7hVTfIS5yAVk2bqikcb9qVfM53XylmQY6cLLfE37uQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=corigine.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=02Wi6K/3IDeak+NQi0783tWC+VTJ/IbDoJTDlD0m1z8=; b=Vjj/FZJS8EiOT0jbV1+cB9PbTfhoTTwXVTF3m0fsPchLcrfU+gaUXGs2tifOp/DAwiV3y2Bf42yRwAil+avsQGgRDeEGwsfYUozhh7+v/GX9W+cQy03yIe19wuM3x0M/pLpmzMLFiOXAOFau5k3jXey4Kyq5JSYkgwPrP4vFguY= Received: from BN0PR03CA0019.namprd03.prod.outlook.com (2603:10b6:408:e6::24) by DM6PR02MB7065.namprd02.prod.outlook.com (2603:10b6:5:25a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Thu, 8 Sep 2022 16:24:52 +0000 Received: from BN1NAM02FT033.eop-nam02.prod.protection.outlook.com (2603:10b6:408:e6:cafe::71) by BN0PR03CA0019.outlook.office365.com (2603:10b6:408:e6::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Thu, 8 Sep 2022 16:24:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; pr=C Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by BN1NAM02FT033.mail.protection.outlook.com (10.13.3.186) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Thu, 8 Sep 2022 16:24:51 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 8 Sep 2022 17:24:50 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2375.24 via Frontend Transport; Thu, 8 Sep 2022 17:24:50 +0100 Envelope-to: chaoyong.he@corigine.com, dev@dpdk.org, oss-drivers@corigine.com, niklas.soderlund@corigine.com, heinrich.kuhn@corigine.com Received: from [10.71.194.74] (port=62285) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1oWKKf-00074E-Je; Thu, 08 Sep 2022 17:24:50 +0100 Message-ID: <62c7afa8-9ab9-3491-fd66-fbd0cd60eccf@xilinx.com> Date: Thu, 8 Sep 2022 17:24:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v8 04/12] net/nfp: add initial flower firmware support Content-Language: en-US To: Chaoyong He , CC: , , Heinrich Kuhn References: <1662626702-17254-1-git-send-email-chaoyong.he@corigine.com> <1662626702-17254-5-git-send-email-chaoyong.he@corigine.com> From: Ferruh Yigit In-Reply-To: <1662626702-17254-5-git-send-email-chaoyong.he@corigine.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN1NAM02FT033:EE_|DM6PR02MB7065:EE_ X-MS-Office365-Filtering-Correlation-Id: 88069cb7-a2a1-4b7c-2da2-08da91b6a820 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OVPxgA6QeepjOkEfdaztLhom+dd++qqMOKbgNhs4pz0QkGWXl2Wa2ftAF/2k/YpQVDG+PirTf7CWtF07WLvIM5FDA5RY+QTIjMKVgaxynlMqWlZv20IW8yJnXvSgNJhx15IrHycOfFHBNgnZvXZYRSDGq9oEpfHzZ2EtvLVq7epvueHd5KWPJdUksQ3gQ178jnZ0IhVcC/IEtx7Mzbm/+/4BdhR+R6ebd8llZK4Xkoz/o8mpVA3+lSuBETl7dE4sCCJ++L4Dmm4yES1b4TTIbjI2rcOUjPXrasuHhdt/UZs2LULTYrrK1xWDy7/fUbChEoSvlWIXQ4F6ZlkPu9SiWHYWh9Wzbfk9tlWpbNlr4v4qJuyDQBw+gvyTLfaqmurlaVQR3WokrpCARp13ySx38nrsxPnGPFi53MRh5rvKxJmApSoUucYZCMIlvnXnKdJ0jELL7HRc/R0RJ4uJ9PHzEW/S7lh2AoxE7OcZXtyh2CSaxF4WxwsGzHJ+yw1XJx1JMRJRtegh+Fv6p0+2AkRSqcpnxJj5HkdlFOtVI36VtNqEyRZiZyVcJyV9RHuTPHceImY3vIsJ7p+0R5URXlKSlePtP9VaODhWg2H8/b2vsC4/76BDHYxHlgZrru8FGHeH0EGpJhJ9GlNkE+8DOsngY6kt9A1JFeJ+KJtaoP35dBNI0Glt8TE5gJvuT9GrG3Tkv8kIeKUBD5mX01o4UKwC+CLxGMRZ5zFdH0w8VcQtWJYyq8PZ067pF2fmTGgSNWZZuecMXmqaDz/JUTutWxRWPo34BTzrkjJBhPkPJcRSaqdeK/DHukc/izv5GNpuNkYUgEgvYFg6FivHw9UMkKKnsw== X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(136003)(396003)(346002)(376002)(39860400002)(36840700001)(40470700004)(46966006)(36860700001)(40480700001)(7636003)(9786002)(2906002)(44832011)(356005)(40460700003)(5660300002)(8936002)(53546011)(478600001)(82740400003)(31696002)(41300700001)(316002)(110136005)(54906003)(8676002)(70586007)(4326008)(70206006)(82310400005)(26005)(186003)(426003)(47076005)(66574015)(336012)(2616005)(31686004)(83380400001)(36756003)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 16:24:51.5384 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 88069cb7-a2a1-4b7c-2da2-08da91b6a820 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT033.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB7065 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/8/2022 9:44 AM, Chaoyong He wrote: > Adds the basic probing infrastructure to support the flower firmware. > > Adds the basic infrastructure needed by the flower firmware to operate. > The firmware requires threads to service both the PF vNIC and the ctrl > vNIC. The PF is responsible for handling any fallback traffic and the > ctrl vNIC is used to communicate various control messages to and > from the smartNIC. rte_services are used to facilitate this logic. > > Adds the cpp service, used for some user tools. > > Signed-off-by: Chaoyong He > Signed-off-by: Heinrich Kuhn > Reviewed-by: Niklas Söderlund > --- > doc/guides/rel_notes/release_22_11.rst | 3 ++ Can you please update driver documentation too, 'doc/guides/nics/nfp.rst', to document these new features? Please update it gradually in each relevant patch, as you are already doing for release notes updates. > drivers/net/nfp/flower/nfp_flower.c | 59 +++++++++++++++++++++++ > drivers/net/nfp/flower/nfp_flower.h | 18 +++++++ > drivers/net/nfp/meson.build | 1 + > drivers/net/nfp/nfp_common.h | 1 + > drivers/net/nfp/nfp_cpp_bridge.c | 87 +++++++++++++++++++++++++++++----- > drivers/net/nfp/nfp_cpp_bridge.h | 6 ++- > drivers/net/nfp/nfp_ethdev.c | 28 ++++++++++- > 8 files changed, 187 insertions(+), 16 deletions(-) > create mode 100644 drivers/net/nfp/flower/nfp_flower.c > create mode 100644 drivers/net/nfp/flower/nfp_flower.h > > diff --git a/doc/guides/rel_notes/release_22_11.rst b/doc/guides/rel_notes/release_22_11.rst > index f601617..bb170e3 100644 > --- a/doc/guides/rel_notes/release_22_11.rst > +++ b/doc/guides/rel_notes/release_22_11.rst > @@ -55,6 +55,9 @@ New Features > Also, make sure to start the actual text at the margin. > ======================================================= > > + * **Updated Netronome nfp driver.** This is still in the section comment, need to fix the indentation to move it out of comment. And please put an empty line after this line. Please compile and verify the documentation updates. > + Added the support of flower firmware. > + Added the flower service infrastructure. In output these lines are joined, if the intentions is have them as bullets, need to add '*' prefix, like: ``` * **Updated Netronome nfp driver.** * Added the support of flower firmware. * Added the flower service infrastructure. * Added the control message interactive channels between PMD and firmware. * Added the support of representor port. ```