From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 581A2A0526; Wed, 25 Nov 2020 02:16:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 32945C942; Wed, 25 Nov 2020 02:16:43 +0100 (CET) Received: from baidu.com (mx22.baidu.com [220.181.50.185]) by dpdk.org (Postfix) with ESMTP id 69857C93E for ; Wed, 25 Nov 2020 02:16:41 +0100 (CET) Received: from BC-Mail-Ex16.internal.baidu.com (unknown [172.31.51.56]) by Forcepoint Email with ESMTPS id B882F4867DDCEE13EA09; Wed, 25 Nov 2020 09:00:46 +0800 (CST) Received: from BJHW-Mail-Ex15.internal.baidu.com (10.127.64.38) by BC-Mail-Ex16.internal.baidu.com (172.31.51.56) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2044.4; Wed, 25 Nov 2020 09:00:46 +0800 Received: from BJHW-Mail-Ex15.internal.baidu.com ([100.100.100.38]) by BJHW-Mail-Ex15.internal.baidu.com ([100.100.100.38]) with mapi id 15.01.1979.006; Wed, 25 Nov 2020 09:00:46 +0800 From: "Li,Rongqing" To: "Loftus, Ciara" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH][v3] net/af_xdp: optimize RX path by removing the unneeded allocation mbuf Thread-Index: AQHWvwSHlfQJkRCW6E+L56fsCV/NpKnXV3LQgAC3CyA= Date: Wed, 25 Nov 2020 01:00:46 +0000 Message-ID: <62cbe842acc84349ac49cded19c580f7@baidu.com> References: <1605852868-25682-1-git-send-email-lirongqing@baidu.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.22.198.15] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH][v3] net/af_xdp: optimize RX path by removing the unneeded allocation mbuf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > + if (rte_pktmbuf_alloc_bulk(umem->mb_pool, fq_bufs, nb_pkts)) { > > + AF_XDP_LOG(DEBUG, > > + "Failed to get enough buffers for fq.\n"); > > + /* rollback cached_cons which is added by > > + * xsk_ring_prod__needs_wakeup > > + */ >=20 > Thanks for adding the comment. > There's a small mistake here. > The function in which cached_cons is added is xsk_ring_cons__peek. > Could you please submit a v4 with this change? > Thanks! > Ciara >=20 Sorry, I will send V4 Thanks -Li