From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5AC9A0C50; Wed, 21 Jul 2021 14:27:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C642C40696; Wed, 21 Jul 2021 14:27:42 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id DDD3240143 for ; Wed, 21 Jul 2021 14:27:40 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10051"; a="198628418" X-IronPort-AV: E=Sophos;i="5.84,258,1620716400"; d="scan'208";a="198628418" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2021 05:27:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,258,1620716400"; d="scan'208";a="576675509" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga001.fm.intel.com with ESMTP; 21 Jul 2021 05:27:38 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Wed, 21 Jul 2021 05:27:38 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Wed, 21 Jul 2021 05:27:30 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Wed, 21 Jul 2021 05:27:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ow+ehWPG9vPI7H5z9QhAO7wYOhX4hS5ETBhRO9k+DT/UWlUQlliVYabAYdhR9dRaklUg2y95nggmyAA2rZm0hW4QFmUql3bWV7Jy2zzaXAXjIFfsI93JiMQ1D7KMmUijfcXHIUC3hqRJq7TLUfaVGwSWcLKMIPUs5rRAytR3xJWw2Nc8brzcIliKVNN+RZSLxjocmj12YJSbexM54U34D8hZivONycCE92wVaElMMlXagR+0cXqjpUexVBY3CyRZn6V3rSaneXoCvjqSPQGrUCA9jE/OqRWnaPRSsCEwOkywyr2KqzDromhN+J3WgVQxFswqj0TfJDbZ7wYP77/71g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wIMjjGgRwNjWgDmXrcMYhXZFpdreDI3lmbDNpxl/avA=; b=RmWoxtbkIwasa7jJpCg/aEE9GR5JZPVMRhwICVydFuwWItx36kHw9JUWpF36vbeeza4leUeDoDHr8hfWobu6uWkU1gqheN0thRMBFkCKXX1ujbX1Bnt2IKcrDwm32ifvKOKX6cwhnj5QEcK3uD3bZCKkxkgn2az0UZoZF+4imZrdGxlBT6cObs/D7wdFlYxDcKIf5qeH4rOLdNlj+/HXgPqK3e3CEhXoT2gj+dAW6C2HwPB5pSuRcMUlT86w3vlf11q8QDCnTKEGRjPYIHGe5Y5uTzPSHeVmY2MiEbjVsBbM4EBkMCmfnIflpAyS0O3O51Cua+ZF4h1RELZ/05MNCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wIMjjGgRwNjWgDmXrcMYhXZFpdreDI3lmbDNpxl/avA=; b=lWF1Y67fSRkK0RUE70UTw1nhQCexeEeEf0u1YIfXyjOZU9BqI4y3eX9DwvjTi0+hNV+DsHlIyFkxMpL72ZJz9QZe+NUC0xk9lnP4bpDKKJUWQGzqUgHobB3710DSXzzJcIiHH0QbpHFeFMFVg8J6STIu4yp2F+FL3dhqu5C2jnM= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com; Received: from SJ0PR11MB5005.namprd11.prod.outlook.com (2603:10b6:a03:2d3::21) by BYAPR11MB3447.namprd11.prod.outlook.com (2603:10b6:a03:1d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.25; Wed, 21 Jul 2021 12:27:13 +0000 Received: from SJ0PR11MB5005.namprd11.prod.outlook.com ([fe80::a018:c8bc:f54e:514c]) by SJ0PR11MB5005.namprd11.prod.outlook.com ([fe80::a018:c8bc:f54e:514c%7]) with mapi id 15.20.4331.034; Wed, 21 Jul 2021 12:27:13 +0000 To: Andrew Rybchenko , Jerin Jacob , Xiaoyun Li , Ajit Khaparde , Somnath Kotur , Igor Russkikh , Pavel Belous , Somalapuram Amaranath , "Rasesh Mody" , Shahed Shaikh , Chas Williams , "Min Hu (Connor)" , Nithin Dabilpuram , Kiran Kumar K , "Sunil Kumar Kori" , Satha Rao , "Rahul Lakkireddy" , Hemant Agrawal , Sachin Saxena , "Haiyue Wang" , Marcin Wojtas , "Michal Krawczyk" , Guy Tzalik , "Evgeny Schemeilin" , Igor Chauskin , "Gagandeep Singh" , John Daley , Hyong Youb Kim , Gaetan Rivet , Qi Zhang , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Yisen Zhuang , Lijun Ou , Beilei Xing , Jingjing Wu , Qiming Yang , Andrew Boyer , Rosen Xu , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , "Zyta Szpak" , Liron Himi , Heinrich Kuhn , Harman Kalra , "Nalla Pradeep" , Radha Mohan Chintakuntla , Veerasenareddy Burru , Devendra Singh Rawat , Maciej Czekaj , Jiawen Wu , Jian Wang , "Maxime Coquelin" , Chenbo Xia , Yong Wang , Konstantin Ananyev , Radu Nicolau , "Akhil Goyal" , David Hunt , John McNamara , Thomas Monjalon CC: References: <20210709172923.3369846-1-ferruh.yigit@intel.com> <20210709172923.3369846-4-ferruh.yigit@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <62d9f305-3ebd-53c0-2f32-d5c9a8228f39@intel.com> Date: Wed, 21 Jul 2021 13:26:38 +0100 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM3PR07CA0094.eurprd07.prod.outlook.com (2603:10a6:207:6::28) To SJ0PR11MB5005.namprd11.prod.outlook.com (2603:10b6:a03:2d3::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.206] (37.228.236.146) by AM3PR07CA0094.eurprd07.prod.outlook.com (2603:10a6:207:6::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.7 via Frontend Transport; Wed, 21 Jul 2021 12:26:43 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1ec63654-70b6-4512-f7ec-08d94c42de00 X-MS-TrafficTypeDiagnostic: BYAPR11MB3447: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lnzkpBcyhlnBxknlq9kYuy9kfy6KG0VlQ3Rj/3r1U7A5a4dn7T3lFIe3Ph8oaAnms1uFz3gCYYirXt9DzdxKwmW6J1Uqw9J3R0TqZtSpd5t56ZcQHDkmSM1jjJG2NmjLCnXkouBrXbcMmGr70G/FcmMASheV/nu2AxL59FSdw1C9k05vnZXuOAV9pIV3RZrPyBm1RbMrKnoMcE9fxQkmWsUhDbV9CkDQMrzSmlTT5sPUCoZUzq/XbVNMNYE9ulsE4GUTLu04//kEN8ogA8Du90mQtLifp9Od2zr20KBOF0Nnqv9tGE6W3PZMdHag/bSKP6cSWGpvXl5vLeAQIAMeZibTk7gExRtjrnpd28rzbyLCIWlG78YzHPiv8GPfXyd9pYztWC4YnXMbs22goMJ+cuk6YdXBzsxF5fZwMWwN83oSE6YGN+AI3WJFGmEBxhm+MaPOOqgPnRPKHriVjz94TZiF3sP16iCVwsIxrNjGapzinKXfQv7jcl6XHrxpZnzfAWLsCmP2kAVIMOu/Wutk1vfeMfjic4k6DYceYe7Cg/Oxz7vGLOKyfcNugZnJGQn4uozawxfkMeTiLvxwmO1oSdV/AlkZ4RWdQ6CaIFBvtlWjjPQ8eUgpVwD1AyJwHEFSesad3sDps9vYI0LRTU2cmvBB9zpYpiAeeEYCQSePZlo6guBuKioU+F8/jyZ+CAK+L+58VWHqEmYVYGljnCM3PriXaKrmcZPVxWNDrnlSnlA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5005.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(346002)(396003)(39860400002)(376002)(7416002)(26005)(6666004)(7366002)(83380400001)(2616005)(956004)(53546011)(66476007)(31686004)(66556008)(478600001)(110136005)(66946007)(4326008)(316002)(2906002)(921005)(8936002)(7406005)(5660300002)(44832011)(186003)(36756003)(38100700002)(31696002)(1191002)(86362001)(8676002)(16576012)(6486002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c2dvcjRqM0tQT3B6Z2QxZXZWMVY4QU9wMWF3SXEvSjdsZEY3WldXMjVSWlhz?= =?utf-8?B?VWpJd2tRM2VBV255aE02NWdvRjl0OGxMTVArTTAyTzI1R0s0QnNmTERkTkQ5?= =?utf-8?B?ajVJUUxkakVzVDB4OFBpUmZDQWp5YmU1SDJITDNxU2x0WnhORTVqdGlSSmo2?= =?utf-8?B?YUptb3FWY01xTTcwWTYvZ1k1Nkdzcys0cG52VEZqMzc4aG9CRFZsV0R4Y0Fk?= =?utf-8?B?OElnaVZLcEdiY2x3OTR2VUs3UWJNYjl1MUY0akVPMUdHNnhTQVZaREZxVGtj?= =?utf-8?B?dEVZdEV0Mis3NWxRVEdQRCtaeE9QMEdORHV3ZWFlbUFVR1Jza2orNzBNZWxp?= =?utf-8?B?S0RMMmZEWEIvVUJPRWplUmJVOHpVWkorVU9kVnRhWWNlUjRaU3VhYmF6NlpP?= =?utf-8?B?cHd4RHRpVTRaWjlCZnU3NFFrTG0zY2tSaXlTKzlhVjlnWUZzekpQRzVzMFZJ?= =?utf-8?B?c0FFRXpIUHR3OGExZ1ZsNHExbC9KdTUwM1MzbWY4U1BuMlNxaEl2THFqaW9a?= =?utf-8?B?THhXWEdxVzJWVHQzRlpEakMxeUk4Y0pFdkRHNTlHV1ZYZUdGbnkxM1hjUXh2?= =?utf-8?B?dmFScGdGRmlCTTllbW9uTWRtb25mN29MS0ZEeTJ5KzZzVVNLWXIzcHJpM2F6?= =?utf-8?B?T2libnM0NC9kckNwUzNUS0dXaVVwcHRmYVUyelZvNHJTeHNTMlJudW9yRHdW?= =?utf-8?B?eFdVbW41YWVOOE1WRHIvUjlyalBTQ3VQcG02U1pidHhrTGdDZStGcWFIOXdL?= =?utf-8?B?ekVQOFZ5U2NDOXZTNkd5U1M0bHV4dDJpNFNGNEllN05zcjNRMno2S0laOVA4?= =?utf-8?B?K2I2Yld3bmdsdk40SXROdExuaDNMc1k5amswY2FrZkxCVjQ1Ylc1MlRCeXUv?= =?utf-8?B?L1c2d3hma3NYSlgrcjVvbGdrWit2eFRKdG9McytjbnNFUHBKNS9TaXdlbGJn?= =?utf-8?B?SExlZk12aVliOGdRSTM2YjcrbEg1Y2RYa1VCYTFOUWhOMGtkcUUvNFFJZEVt?= =?utf-8?B?S0RNaHh0WHkzbDZYSlBrVjZuTkVGell5S0d0WGtJNjl5YVgvMThHRUdvbkhw?= =?utf-8?B?K1NxZEhUdnp1Q2R2NVNIRWZVK1FvUEFjU004NTFGaytPMlBRUVpxUU1VMWxI?= =?utf-8?B?eEVJajR1R3RFLzNYa09NV056QzdNeGZJdE5MN0NpekF2N3BiWUIzVG96OVFK?= =?utf-8?B?OEdDQ2QvNXRDNDI3U3QxMi90MzBOQUYyVC9UMXJSRUptYlF5Sk4xT2RVZEc1?= =?utf-8?B?OWZEWk5WZnNjMGloVnJiQ0trWWRvVHFoNXpDV1VOZHVYbDN2azFBQ212R3M5?= =?utf-8?B?NDQwNU1idVJrdEtwemNpVlc4ZFF4OGhRVEhYRmdHdGNOMmlQVXVja0w4YW9D?= =?utf-8?B?YlVOK09USkh6Z0ZsOEx3VlRDeG1QQUdxREZ3L2FONDhvODUzTFJRZmhWcXNP?= =?utf-8?B?V0pPbUMvSDNmbm04UGF5eHhEL2ZYaDFFVlYvWlFvcTRPZkJGd3ZOb2JxbDNt?= =?utf-8?B?L2JKZ1dUYklOKzArUnFna2V6QyszdnVEbDRSWDRKbVY3cjdidFRNaDBZNkNS?= =?utf-8?B?bEw0VDl4OThlbjZIYlZxSGc2S2hKaDdtZTgyRXJhL1BGZnVkZHNNUUxCOXFs?= =?utf-8?B?WjZEdUUyWk51dS83RDNYRitmQXNPMTVMUGJqNWF6SkpvVnU3UHhlWVlTYlc4?= =?utf-8?B?VzV1TDRKWkQ4aHgzY2w1bVdjZ05ZMlAxQkdrbnU2QVU3T3ZxdWJIUWxCWFF1?= =?utf-8?Q?M01L02hpeEWhV5U6ZKap68P0YDjFkSP45jKoNdF?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1ec63654-70b6-4512-f7ec-08d94c42de00 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5005.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2021 12:27:13.0811 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7J75Zv8CweV51kJiYah1C8SouqvyA2PxwuiVKfA0kA1RzZBnCqA1lpcsZvfF6poWX10cjneOUH+7w4SiPOKWTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3447 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 4/4] ethdev: remove jumbo offload flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/13/2021 3:07 PM, Andrew Rybchenko wrote: > On 7/9/21 8:29 PM, Ferruh Yigit wrote: >> Removing 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag. >> >> Instead of drivers announce this capability, application can deduct the >> capability by checking reported 'dev_info.max_mtu' or >> 'dev_info.max_rx_pktlen'. >> >> And instead of application explicitly set this flag to enable jumbo >> frames, this can be deducted by driver by comparing requested 'mtu' to >> 'RTE_ETHER_MTU'. > > I can imagine the case when app wants to enable jumbo MTU in > run-time, but enabling requires to know it in advance in order > to configure HW correctly (i.e. offload is needed). > I think it may be ignored. Driver should either reject MTU > set in started state or do restart automatically on request. > As far as I can see we have both implementations. Most of PMDs return error if device is started, a few tries to restart to apply the configuration. And many PMDs just record the value passed with this API and apply it in the device start, some apply the value within API. > However, driver maintainers should keep it in mind reviewing > the patch. > +1 >> >> Removing this additional configuration for simplification. >> >> Signed-off-by: Ferruh Yigit > > ethdev part: > > Acked-by: Andrew Rybchenko > > [snip] > >> diff --git a/drivers/net/e1000/e1000_ethdev.h b/drivers/net/e1000/e1000_ethdev.h >> index 3b4d9c3ee6f4..1ae78fe71f02 100644 >> --- a/drivers/net/e1000/e1000_ethdev.h >> +++ b/drivers/net/e1000/e1000_ethdev.h >> @@ -468,8 +468,8 @@ void eth_em_rx_queue_release(void *rxq); >> void em_dev_clear_queues(struct rte_eth_dev *dev); >> void em_dev_free_queues(struct rte_eth_dev *dev); >> >> -uint64_t em_get_rx_port_offloads_capa(struct rte_eth_dev *dev); >> -uint64_t em_get_rx_queue_offloads_capa(struct rte_eth_dev *dev); >> +uint64_t em_get_rx_port_offloads_capa(void); >> +uint64_t em_get_rx_queue_offloads_capa(void); > > I'm not sure that it is a step in right direction. > May be it is better to keep dev unused. > net/e1000 maintainers should decide. >