DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Salem Sol <salems@nvidia.com>, dev@dpdk.org
Cc: Jiawei Wang <jiaweiw@nvidia.com>, Ori Kam <orika@nvidia.com>,
	Xiaoyun Li <xiaoyun.li@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4 1/7] app/testpmd: store VXLAN/NVGRE encap data globally
Date: Tue, 6 Apr 2021 15:54:20 +0100
Message-ID: <62ef4d8f-75b0-20d9-fe36-d4c7c957de03@intel.com> (raw)
In-Reply-To: <20210404094910.95413-2-salems@nvidia.com>

On 4/4/2021 10:49 AM, Salem Sol wrote:
> From: Jiawei Wang <jiaweiw@nvidia.com>
> 
> With the current code the VXLAN/NVGRE parsing routine
> stored the configuration of the header on stack, this
> might lead to overwriting the data on the stack.
> 
> This patch stores the external data of vxlan and nvgre encap
> into global data as a pre-step to supporting vxlan and nvgre
> encap as a sample actions.
> 
> Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>

Hi Salem,

I put some comments on v3 of this patch, can you please check it?

And can you please use 'git send-email' '--in-reply-to' argument to send new 
version of a patch to reply to previous version, this keeps all versions in same 
email thread and makes it easy to find previous version discussions/comments for 
reviewers also for the email archives.


  reply	other threads:[~2021-04-06 14:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-04  9:49 [dpdk-dev] [PATCH v4 0/7] Add support for VXLAN and NVGRE encap as a sample actions Salem Sol
2021-04-04  9:49 ` [dpdk-dev] [PATCH v4 1/7] app/testpmd: store VXLAN/NVGRE encap data globally Salem Sol
2021-04-06 14:54   ` Ferruh Yigit [this message]
2021-04-07 11:48   ` [dpdk-dev] [v5 1/6] app/testpmd: prepare storing " Salem Sol
2021-04-07 23:13     ` Ferruh Yigit
2021-04-04  9:49 ` [dpdk-dev] [PATCH v4 2/7] net/mlx5: support VXLAN encap action in sample Salem Sol
2021-04-07 11:48   ` [dpdk-dev] [v5 2/6] " Salem Sol
2021-04-04  9:49 ` [dpdk-dev] [PATCH v4 3/7] net/mlx5: support NVGRE " Salem Sol
2021-04-07 11:49   ` [dpdk-dev] [v5 3/6] " Salem Sol
2021-04-04  9:49 ` [dpdk-dev] [PATCH v4 4/7] app/testpmd: support VXLAN encap for sample action Salem Sol
2021-04-07 11:50   ` [dpdk-dev] [v5 4/6] " Salem Sol
2021-04-04  9:49 ` [dpdk-dev] [PATCH v4 5/7] app/testpmd: support NVGRE " Salem Sol
2021-04-07 11:50   ` [dpdk-dev] [v5 5/6] " Salem Sol
2021-04-04  9:49 ` [dpdk-dev] [PATCH v4 6/7] doc: update sample actions support in testpmd guide Salem Sol
2021-04-07 11:51   ` [dpdk-dev] [v5 6/6] " Salem Sol
2021-04-04  9:49 ` [dpdk-dev] [PATCH v4 7/7] doc: update sample actions support in mlx5 guide Salem Sol
2021-04-06 14:45   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62ef4d8f-75b0-20d9-fe36-d4c7c957de03@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=jiaweiw@nvidia.com \
    --cc=orika@nvidia.com \
    --cc=salems@nvidia.com \
    --cc=xiaoyun.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git