From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47346A0546; Tue, 6 Apr 2021 16:54:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 166BA141134; Tue, 6 Apr 2021 16:54:28 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 13356141121 for <dev@dpdk.org>; Tue, 6 Apr 2021 16:54:25 +0200 (CEST) IronPort-SDR: u2ct/E5cPhdTlE7x6DNohM7Xe0fXwrlNbXy593tiH/YvtYkpuOil7CnM/MBqvblcI7QKU8i3qi mSJzIlhoprvA== X-IronPort-AV: E=McAfee;i="6000,8403,9946"; a="193122234" X-IronPort-AV: E=Sophos;i="5.81,309,1610438400"; d="scan'208";a="193122234" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2021 07:54:24 -0700 IronPort-SDR: 1+zE1qYVMnW56ghB8C+YYHaZ2vXUe4xZCO8+iZ5GMfshEGD2D5SIVe9p1w2/MMsPtRbIuP+dlq YiO/oH+E7kaA== X-IronPort-AV: E=Sophos;i="5.81,309,1610438400"; d="scan'208";a="421245847" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.250.199]) ([10.213.250.199]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2021 07:54:23 -0700 To: Salem Sol <salems@nvidia.com>, dev@dpdk.org Cc: Jiawei Wang <jiaweiw@nvidia.com>, Ori Kam <orika@nvidia.com>, Xiaoyun Li <xiaoyun.li@intel.com> References: <20210404094910.95413-1-salems@nvidia.com> <20210404094910.95413-2-salems@nvidia.com> From: Ferruh Yigit <ferruh.yigit@intel.com> X-User: ferruhy Message-ID: <62ef4d8f-75b0-20d9-fe36-d4c7c957de03@intel.com> Date: Tue, 6 Apr 2021 15:54:20 +0100 MIME-Version: 1.0 In-Reply-To: <20210404094910.95413-2-salems@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 1/7] app/testpmd: store VXLAN/NVGRE encap data globally X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 4/4/2021 10:49 AM, Salem Sol wrote: > From: Jiawei Wang <jiaweiw@nvidia.com> > > With the current code the VXLAN/NVGRE parsing routine > stored the configuration of the header on stack, this > might lead to overwriting the data on the stack. > > This patch stores the external data of vxlan and nvgre encap > into global data as a pre-step to supporting vxlan and nvgre > encap as a sample actions. > > Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com> Hi Salem, I put some comments on v3 of this patch, can you please check it? And can you please use 'git send-email' '--in-reply-to' argument to send new version of a patch to reply to previous version, this keeps all versions in same email thread and makes it easy to find previous version discussions/comments for reviewers also for the email archives.