DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
	Ori Kam <orika@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: replace bit shifts with macros
Date: Thu, 16 Sep 2021 10:55:04 +0200	[thread overview]
Message-ID: <6302489.YdC8p3pGMF@thomas> (raw)
In-Reply-To: <d99c70c4-2ecc-8676-906d-1da5cc495c78@oktetlabs.ru>

16/09/2021 08:52, Andrew Rybchenko:
> On 9/16/21 12:04 AM, Thomas Monjalon wrote:
> > The macros RTE_BIT32 and RTE_BIT64 are used to replace bit shifts.
> > The macro UINT64C is also used to replace remaining occurrences of ULL.
> > 
> > Only bit shifts of ETH_RSS_LEVEL_* are kept for aesthetic reason.
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> 
> Good cleanup, many thanks.
> 
> > diff --git a/lib/ethdev/rte_mtr.h b/lib/ethdev/rte_mtr.h
> > index dc246dd7af..babc9968d0 100644
> > --- a/lib/ethdev/rte_mtr.h
> > +++ b/lib/ethdev/rte_mtr.h
> > @@ -60,28 +60,28 @@ extern "C" {
> >   */
> >  enum rte_mtr_stats_type {
> >  	/** Number of packets passed as green by the policer. */
> > -	RTE_MTR_STATS_N_PKTS_GREEN = 1 << 0,
> > +	RTE_MTR_STATS_N_PKTS_GREEN = RTE_BIT64(0),
> 
> I think it is a bad idea to initialize enum members to
> uint64_t value.

Yes probably.
The targets are 64-bit wide so there is an inconsistency in the API I think.



  reply	other threads:[~2021-09-16  8:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-15 21:04 Thomas Monjalon
2021-09-16  6:52 ` Andrew Rybchenko
2021-09-16  8:55   ` Thomas Monjalon [this message]
2021-09-16  9:36     ` Andrew Rybchenko
2021-09-23  9:39 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2021-10-05 19:18   ` Thomas Monjalon
2021-10-07 10:07   ` Andrew Rybchenko
2021-10-07 11:07   ` Ferruh Yigit
2021-10-07 13:26 ` [dpdk-dev] [PATCH v3] " Thomas Monjalon
2021-10-07 14:11   ` Thomas Monjalon
2021-10-07 15:48 ` [dpdk-dev] [PATCH v4] " Thomas Monjalon
2021-10-07 17:32   ` Ferruh Yigit
2021-10-07 18:29     ` Thomas Monjalon
2021-10-13  7:52 ` [dpdk-dev] [PATCH v5] " Thomas Monjalon
2021-10-13 11:29   ` Ferruh Yigit
2021-10-20 14:55   ` [dpdk-dev] [PATCH v6] " Ferruh Yigit
2021-10-20 17:48     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6302489.YdC8p3pGMF@thomas \
    --to=thomas@monjalon.net \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=orika@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).