DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Shesha Sreenivasamurthy <shesha@cisco.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v8] mem: command line option to delete hugepage backing files
Date: Wed, 04 Nov 2015 02:03:26 +0100	[thread overview]
Message-ID: <6306594.cul4fQvtrc@xps13> (raw)
In-Reply-To: <5631590F.9040606@intel.com>

2015-10-28 23:23, Sergio Gonzalez Monroy:
> On 28/10/2015 22:04, Shesha Sreenivasamurthy wrote:
> > When an application using huge-pages crash or exists, the hugetlbfs
> > backing files are not cleaned up. This is a patch to clean those files.
> > There are multi-process DPDK applications that may be benefited by those
> > backing files. Therefore, I have made that configurable so that the
> > application that does not need those backing files can remove them, thus
> > not changing the current default behavior. The application itself can
> > clean it up, however the rationale behind DPDK cleaning it up is, DPDK
> > created it and therefore, it is better it unlinks it.
> >
> > Signed-off-by: Shesha Sreenivasamurthy <shesha@cisco.com>
> > Acked-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>

> Patch looks good!
> 
> Just a couple of things for the next time ;)
> You might be aware of them, but it doesn't hurt to remind them:
> - When sending new version, use --in-reply-to to the last version of the 
> patch sent, it's easier to have all patches on the same thread (if your 
> email client supports it)
> - Also when sending new versions it's useful to add what has changed 
> from the previous to the new version.
>    (add such info after the three dashes as shown above)

+1

Other things:
Some lists like EAL options are alphabetically sorted.
When adding a new line, please try to keep the order.

Applied with orders fixed, thanks.

      reply	other threads:[~2015-11-04  1:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-28 22:04 Shesha Sreenivasamurthy
2015-10-28 23:23 ` Sergio Gonzalez Monroy
2015-11-04  1:03   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6306594.cul4fQvtrc@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=shesha@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).