From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 869FDA0577; Wed, 15 Apr 2020 15:14:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 161A81D6FE; Wed, 15 Apr 2020 15:14:20 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id DC2491D6FC for ; Wed, 15 Apr 2020 15:14:18 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 5C51B5C014B; Wed, 15 Apr 2020 09:14:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 15 Apr 2020 09:14:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=3f5FHjJUPh6nVb1QaVpUB35BIKmQcF6ywk4RKEGXSuo=; b=PXUhBjgFACxj zKrVmMTuj4bm4vzsOxXTtZ0vKUgY0iRPb/Y6q9x/6sxff/Fv6T7+kA/W5juqT87w TBl88e1ApXxuLC3/BNSxMnE2rOhk+BVPz8asC03yiIwBSZvGWMH3wISNP3RcDzZK 3V5S7joj5DOt/0+edRfx0IkSqyFIgeg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=3f5FHjJUPh6nVb1QaVpUB35BIKmQcF6ywk4RKEGXS uo=; b=4jNJ/AiBPDx6xLCnWkDTYQJAwMCtZLcD2UbJ9eX7+aosxRHTLg2omYYDt 7pd5vqTW8q2WuDY1iovpYRPIAF/fXTrlOIzDf1XAZ5GNaTTRBYKC4j7gpGya0DKn U5fdR0FokxmTmX8TxpBpYk76n7w+dQE3pV/j5rSLGdb6Uvyiw3V3M7kX0HyaImc9 Ecy80/nWtyTvhPcg7q9+I8QQmDENzWd+ll2HrTFA586D3+AHP3rPL7rpT2uiynDV RFSEyQjaaET2ypdl04MX3wLbL6iVyeKpSuiUDK9Uk8quYSKjsmVWcy2QHmJsHmIH Y61gS3j4J1TpjdRJ35jRr/N5cZTMA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrfeefgdehtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 219413280060; Wed, 15 Apr 2020 09:14:16 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson , Lukasz Wojciechowski Cc: dev@dpdk.org, dev@dpdk.org, Aaron Conole , Ruifeng Wang , David Marchand , Gavin Hu Date: Wed, 15 Apr 2020 15:14:15 +0200 Message-ID: <6315806.6fTUFtlzNn@thomas> In-Reply-To: References: <20200409180332.592074-1-thomas@monjalon.net> <1933780.kXSN5OTJKJ@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] test: remove meson dependency on /proc file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/04/2020 22:47, Lukasz Wojciechowski: > W dniu 10.04.2020 o 16:41, Thomas Monjalon pisze: > > 10/04/2020 15:25, Bruce Richardson: > >> On Fri, Apr 10, 2020 at 02:27:30PM +0200, Thomas Monjalon wrote: > >>> 10/04/2020 12:42, Bruce Richardson: > >>>> On Fri, Apr 10, 2020 at 12:29:50PM +0200, Thomas Monjalon wrote: > >>>>> --- a/app/test/meson.build > >>>>> +++ b/app/test/meson.build > >>>>> has_hugepage = true > >>>>> if is_linux > >>>> Since you check for linux in the script, you can drop these two lines, > >>> The issue is for Windows. > >>> I am not sure how we will skip shell scripts > >>> when adding Windows support for this application. > >>> So there are two options now: > >>> a) remove Linux check before calling the script and ignore Windows support for now > >>> b) keep Linux check without knowing whether it will be useful for Windows support > >>> > >>> We vote a? > >>> > >> c) Write all such scripts in python, to allow them to run everywhere. :-) > >> > >> Given that windows is the problem, having the is_linux check in the > >> meson.build file makes most sense - in which case I don't think we need the > >> check for linux in the script. > > Yes, let's make it simple for now. > > > > a) is ok as the current meson.build won't work in Windows environment at > all. > c) would be best, but I guess it's a little bit to much for this patch > and the whole build system could be adjusted to windows in separate thread. > > And I agree with Bruce, that the check for Linux in script is not needed. I decide to go with initial Bruce's suggestion: check OS in script and remove check from meson. The reasons: - the script is standalone and can be extended for FreeBSD - if Windows support is required, converting to python is better than a check in meson