From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51896A0547; Tue, 9 Feb 2021 15:35:18 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E531F4014E; Tue, 9 Feb 2021 15:35:17 +0100 (CET) Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by mails.dpdk.org (Postfix) with ESMTP id 5C82140147 for ; Tue, 9 Feb 2021 15:35:16 +0100 (CET) Received: by mail-pg1-f181.google.com with SMTP id m2so5833156pgq.5 for ; Tue, 09 Feb 2021 06:35:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=zuwkf5aew69gYxSYJoH1ANppzzqhDqcp4DtDzZIuWHA=; b=lflpuvI9XdLyUMYTJoDYmslzSVv9owc8r3IxtkwYEOwoSFLP5FLh+uo+bdkqXlOz4O ZCXMubRXNjWlgWMNSIMvAisRjrLBZvXmS37u6hXVFMRbpj7BnOp4jW3oSmvEQcDVJsn6 BhmGKb1dgyTla2ur91KNJ/IOqMCGXUvnO4msSUUgkvgC9P9eBJjxbAtf8VzBwusEvtQ8 jJQYe1gddTcP13up1N8v8Uw9ezrD+GwilP+ninjcyt8gHs0j9U2TI/IigJ4z3krwLB38 84ael+sNlyouS+Xl1D6RjzUycQM6Ubazn4TXANgDWNJaYIdyVfCGX1zbATXC51YL4daH 2AmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=zuwkf5aew69gYxSYJoH1ANppzzqhDqcp4DtDzZIuWHA=; b=afu8tK2IGxlvQ8JyCtNH75aKqG3RxMcg3zqLnTtKFvg2lz5V1JqpM0WapUvwVlz6WF lEc5HN/kh7Fpy4v70hPtT/42CtnnLnNtb5iU8UW3+U2IylpwXdPicsWkCvqPZr2SBOpf 9vIH1XOct+GrleGfl2DolNKHh90I0hJJN9Y/0rHhT/q1z2S1BGRoq7P01aAvJi6kzXgQ rOFWr30UhjhU3d9ZsxpRyc81feBdDebyMV8cmhZiycf23NntzaCWowZaR2gtSspZjaK1 rDNx1X14lPsDf6t5AWZ8B1bIc3FtLEwqbFtUOJlHBiIZXVaZzbYNY1Vm+FmF0NB8EaDX blpg== X-Gm-Message-State: AOAM533RrF+nEMbSFY9HsgYWkjxo2EqChK5MZuTXiDzh5smV+E6NsrZ2 Muhlu0kGnZmJcww4aMbRNvtOmw== X-Google-Smtp-Source: ABdhPJy+eHHEz7vetrBwWHTCfvSq2O6fJZM0aLXQCK2D9eaoUWFMU1U91zjX1wi+OPFBPOtO7qv77g== X-Received: by 2002:a65:68ce:: with SMTP id k14mr22376953pgt.401.1612881315541; Tue, 09 Feb 2021 06:35:15 -0800 (PST) Received: from ?IPv6:2600:1700:6b0:fde0:d8a2:13ff:a428:8029? ([2600:1700:6b0:fde0:d8a2:13ff:a428:8029]) by smtp.gmail.com with ESMTPSA id v19sm2847484pjh.37.2021.02.09.06.35.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Feb 2021 06:35:14 -0800 (PST) From: Andrew Boyer Message-Id: <631D0A59-4851-4D4B-8131-FC9DB1D99334@pensando.io> Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Date: Tue, 9 Feb 2021 09:35:12 -0500 In-Reply-To: Cc: "Burakov, Anatoly" , dev , dpdk stable To: David Marchand References: <20201211170615.32827-1-aboyer@pensando.io> X-Mailer: Apple Mail (2.3608.120.23.2.4) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: don't log uninitialized string X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Jan 6, 2021, at 4:35 AM, David Marchand = wrote: >=20 > On Fri, Dec 11, 2020 at 6:07 PM Andrew Boyer > wrote: >>=20 >> Our Coverity scan pointed out that path[] is never initialized. >> The official DPDK Coverity has not reported this so there is >> no public CID for it. >>=20 >> Fixes: c44d09811b40 ("eal: add shared indexed file-backed array") >> Cc: anatoly.burakov@intel.com >> Cc: stable@dpdk.org >>=20 >> Signed-off-by: Andrew Boyer >> --- >> lib/librte_eal/common/eal_common_fbarray.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >>=20 >> diff --git a/lib/librte_eal/common/eal_common_fbarray.c = b/lib/librte_eal/common/eal_common_fbarray.c >> index 1220e2bae..6ce89af83 100644 >> --- a/lib/librte_eal/common/eal_common_fbarray.c >> +++ b/lib/librte_eal/common/eal_common_fbarray.c >> @@ -83,11 +83,10 @@ get_used_mask(void *data, unsigned int elt_sz, = unsigned int len) >> static int >> resize_and_map(int fd, void *addr, size_t len) >> { >> - char path[PATH_MAX]; >> void *map_addr; >>=20 >> if (eal_file_truncate(fd, len)) { >> - RTE_LOG(ERR, EAL, "Cannot truncate %s\n", path); >> + RTE_LOG(ERR, EAL, "Cannot truncate fd %d\n", fd); >=20 > Logging a fd number won't help much, but I guess this was not really > helpful with path[] either :-). > If we keep this log, I would move it to the callers of the functions, > where the filename is available. >=20 >=20 > --=20 > David Marchand Can this be taken for 21.02? I realize the log isn=E2=80=99t that = useful, but it doesn=E2=80=99t seem worth it (to me at least) to do much = more work on it. -Andrew=