From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 84A094CC7 for ; Tue, 16 Oct 2018 12:52:16 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id F316E220CA; Tue, 16 Oct 2018 06:52:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 16 Oct 2018 06:52:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=GRZgguxHMRZBAUV0ai1EXf9Kv3SyM1L6+VtmC2tm2Dc=; b=rOlH0LoF/XQD rWZOg1NA/CIhimr/T66dEoEH4cxfQlTbC7FGWMHwMNk/mQfcnQIly91g1UX8RBOb fvsf9u8SGfDYhb5WT1F9LD4rQ4Ayh2MY1BjqluiW+7SoJja/FTx498psX3WE///G FhMMoomQXAAei+LVQDmCWhYlEIfAyVk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=GRZgguxHMRZBAUV0ai1EXf9Kv3SyM1L6+VtmC2tm2 Dc=; b=JEqE7ZhhCIRhzom2BBYbG5stWBNKwruE00/PpItr2w6lKZ9IFUyh8FLVs vCjkZOk3swCgG59wyE+8tq52wBo7A6gGQE6ZHQ/DOR1hqHIirHSx2EK+rz5EROGs n4Ptmvg1XBifGRtlmVX8QBZfThsV1K1OdysrwXLP0YH9a6pUQuOuDRo3CHOydQK6 EeLKZrHBet4h/aGybwvGaT1jBsKBA3Kio3MQrnOrxCxsjm4RAdX/ea9h3DUH9s6l bT4xPhS94C6EyOmtmN03nZveMWFeTw4jpgyUdRPjvABqeTpjNvElvMfNn3Gnsi6X 4yroNFyYRtlEWm+v8wH2MDygIyTBg== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0E7D6E4240; Tue, 16 Oct 2018 06:52:13 -0400 (EDT) From: Thomas Monjalon To: Qi Zhang Cc: dev@dpdk.org, gaetan.rivet@6wind.com, anatoly.burakov@intel.com, arybchenko@solarflare.com, konstantin.ananyev@intel.com, bruce.richardson@intel.com, ferruh.yigit@intel.com, benjamin.h.shelton@intel.com, narender.vangati@intel.com Date: Tue, 16 Oct 2018 12:52:16 +0200 Message-ID: <6323427.7gbbtosImR@xps> In-Reply-To: <20181016001632.65357-1-qi.z.zhang@intel.com> References: <20180607123849.14439-1-qi.z.zhang@intel.com> <20181016001632.65357-1-qi.z.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v17 0/6] enable hotplug on multi-process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2018 10:52:16 -0000 > Qi Zhang (6): > ethdev: add function to release port in secondary process > eal: enable hotplug on multi-process > eal: support attach or detach share device from secondary > drivers/net: enable hotplug on secondary process > drivers/net: enable device detach on secondary > examples/multi_process: add hotplug sample > > doc/guides/rel_notes/release_18_11.rst | 13 + > drivers/net/af_packet/rte_eth_af_packet.c | 6 +- > drivers/net/bnxt/bnxt_ethdev.c | 6 +- > drivers/net/bonding/rte_eth_bond_pmd.c | 6 +- > drivers/net/ena/ena_ethdev.c | 2 +- > drivers/net/kni/rte_eth_kni.c | 6 +- > drivers/net/liquidio/lio_ethdev.c | 2 +- > drivers/net/null/rte_eth_null.c | 6 +- > drivers/net/octeontx/octeontx_ethdev.c | 8 + > drivers/net/pcap/rte_eth_pcap.c | 6 +- > drivers/net/tap/rte_eth_tap.c | 8 +- > drivers/net/vhost/rte_eth_vhost.c | 6 +- > drivers/net/virtio/virtio_ethdev.c | 2 +- > examples/multi_process/Makefile | 1 + > examples/multi_process/hotplug_mp/Makefile | 23 ++ > examples/multi_process/hotplug_mp/commands.c | 214 ++++++++++++++ > examples/multi_process/hotplug_mp/commands.h | 10 + > examples/multi_process/hotplug_mp/main.c | 41 +++ > lib/librte_eal/bsdapp/eal/Makefile | 1 + > lib/librte_eal/common/eal_common_dev.c | 254 ++++++++++++++-- > lib/librte_eal/common/eal_private.h | 22 ++ > lib/librte_eal/common/hotplug_mp.c | 426 +++++++++++++++++++++++++++ > lib/librte_eal/common/hotplug_mp.h | 46 +++ > lib/librte_eal/common/include/rte_dev.h | 12 + > lib/librte_eal/common/include/rte_eal.h | 9 + > lib/librte_eal/common/meson.build | 1 + > lib/librte_eal/linuxapp/eal/Makefile | 1 + > lib/librte_eal/linuxapp/eal/eal.c | 6 + > lib/librte_ethdev/rte_ethdev.c | 17 +- > lib/librte_ethdev/rte_ethdev_driver.h | 16 +- > lib/librte_ethdev/rte_ethdev_pci.h | 10 +- > lib/librte_ethdev/rte_ethdev_version.map | 7 + > 32 files changed, 1151 insertions(+), 43 deletions(-) Applied, thanks. Note: some PMDs are updated to support multi-process hotplug, but not all of them. I think you focused on the generic ones (af_packet, pcap, tap, bonding), but you forgot failsafe. Please, could you follow-up in -rc2? Thank you