Re: [dpdk-dev] [PATCH 0/2] introduce dev_ops to get extended statistics of a device

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2014-07-23 18:41, Richardson, Bruce:
> > The generic statistics structure is getting bigger as new statistics are
> > added in specific devices. For instance, fdir, tx_pause or loopback
> > stats do not apply on virtual devices. It won't be possible to add every
> > specific statistics in this generic stats structure, but on the other
> > hand these specific statistics are useful for debugging purpose.
> > 
> > This 2 patches introduces xstats_get() and xstats_reset() in
> > dev_ops. When registered by a device, it can be used to provide
> > arbitrary statistics that are identified by a name, as done by eththool
> > in kernel.
> > 
> > After that, some statistics could be moved from the generic structure to
> > this new framework, but it will be part of another patch series as it
> > should be discussed first.
> 
> I like the idea, so Ack on the concept. :-)

Applied with some minor fixes in the comments.

Next step is to move some fields from rte_eth_stats to extended stats.
First candidates to move are the VF-only counters.

Thanks
-- 
Thomas