From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f182.google.com (mail-we0-f182.google.com [74.125.82.182]) by dpdk.org (Postfix) with ESMTP id 00EC9137D for ; Tue, 23 Sep 2014 17:43:22 +0200 (CEST) Received: by mail-we0-f182.google.com with SMTP id u57so2948206wes.41 for ; Tue, 23 Sep 2014 08:49:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=b+qVprSz4UdfMnCaKymcTrJS7m6D9gysB2ogxuvwYog=; b=I07ds432dBnAeT2X+hM6MAjtbuylLRx/TxehX9urCqK80B8nknC7xN8sj6et/11ceq efl9MnHw/L5Sx5vV9xfXWXFNYIn+dtohjfGsuPUzp9eyIvpzuoU2ymHzU1+8b81+IVCT IzMc13fMOBgT37XZvBw3HcACHagF1nI9qKEAqtXevW0tXWibXwM4+IR4ekIA4BxmWuH7 7TgS4wF36cVn+mgBD6VVewVxvlLOZCGSmhdsuLiskF+hTuCMYWM1TLNt7zz3AFUez2fn oPkbpQ4D87ueqHxEMaq27ooQWGWkp1HVjTi97KR/NZlln6u9oeKSYmogZ/Aj3lXRolOD H1Kg== X-Gm-Message-State: ALoCoQl3QzVQhL3RADc3YcspRDL64QnZl+7dbiusc5el7ovwOsWzb1P7s512hklLfGHdND+klud7 X-Received: by 10.194.76.195 with SMTP id m3mr571193wjw.136.1411487371964; Tue, 23 Sep 2014 08:49:31 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id u5sm2705295wia.17.2014.09.23.08.49.30 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Sep 2014 08:49:31 -0700 (PDT) From: Thomas Monjalon To: Olivier Matz Date: Tue, 23 Sep 2014 17:49:22 +0200 Message-ID: <6332355.DEeBjUGxto@xps13> Organization: 6WIND User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; ) In-Reply-To: <59AF69C657FD0841A61C55336867B5B0343B1737@IRSMSX103.ger.corp.intel.com> References: <1406118534-6169-1-git-send-email-olivier.matz@6wind.com> <59AF69C657FD0841A61C55336867B5B0343B1737@IRSMSX103.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/2] introduce dev_ops to get extended statistics of a device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Sep 2014 15:43:23 -0000 2014-07-23 18:41, Richardson, Bruce: > > The generic statistics structure is getting bigger as new statistics are > > added in specific devices. For instance, fdir, tx_pause or loopback > > stats do not apply on virtual devices. It won't be possible to add every > > specific statistics in this generic stats structure, but on the other > > hand these specific statistics are useful for debugging purpose. > > > > This 2 patches introduces xstats_get() and xstats_reset() in > > dev_ops. When registered by a device, it can be used to provide > > arbitrary statistics that are identified by a name, as done by eththool > > in kernel. > > > > After that, some statistics could be moved from the generic structure to > > this new framework, but it will be part of another patch series as it > > should be discussed first. > > I like the idea, so Ack on the concept. :-) Applied with some minor fixes in the comments. Next step is to move some fields from rte_eth_stats to extended stats. First candidates to move are the VF-only counters. Thanks -- Thomas