From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC3D542A0A; Wed, 26 Apr 2023 20:15:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6937F410FA; Wed, 26 Apr 2023 20:15:56 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2046.outbound.protection.outlook.com [40.107.92.46]) by mails.dpdk.org (Postfix) with ESMTP id C53864068E for ; Wed, 26 Apr 2023 20:15:54 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jjL3hZeurh1AL10j+c55ts1wPV4fKkNRmxSvg9UNmWbOztsY3vY0rAuHdgVvh5yxi8DVqjgDQ4NnC84JgGBVYjVxMZtBTncyzv/xFzI4mo187bhl8rQOlHyWDv+UaXWjLgNvZLQ9r8R4JdPPCkgTDje+3qGu4TtOIshVpZj6EGpY4ioRmXGqFQxRgTHh/7k9Gd5ng9sGlowXA/TXdA+C0xsxFzNb6jI5CV55wtAGdK5ERsE4iY9ZijEHlauJKZl4Rx4Y2HDcciQEc3ZFVc3kaOr4S6rFTBGeI/PgvPHfvIBa+CQKlenQHUgiSdmtyDSQ2vfr0F8l9uTP3R/G978Z8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qw1a85osyW5dwY4X//avZD9paUMw7ljkD1Yz2Qm+GZc=; b=QBThqRcK/XoV/5a+FUACEfBN2BwtW5ZXuJP97NdUXBV1dxdnHF2DK/Kz5/9qQ8KBywQxalyihUz7I5vS3iPRWBWVPSl52OXNkCcpdPXE4sMSptGhSG3KIckTRFvE0l5/Zw6SLR9JR+UCvPRAn8o88yRroan3wdQL0HaRA9hLbnOeE9HizQ5cwVrwsWP5gU++NxV7DTWEKQchrZ95fLMiYyGx3EIhBLxtuAH9gd/bzOniBDT8UYV87OOrxvLmucU7JgJEAzkPHI2iUNbg8t1kPQB3XYRY/+aU9meHP6ZfccDknlLv7hrft/WhxL2q0MqIl9nhN9ERpxETWjcpNEHu7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qw1a85osyW5dwY4X//avZD9paUMw7ljkD1Yz2Qm+GZc=; b=iRKjSuhY/YrfeG+2T/cJt/TNHtA6s7Yq2XOohptyk6i546UcJLgOJM5ubHdFBsZNfHQdP6H6pn4JIp4n90GSyajitNhRRotHE3E65AGVDN5Imb5WF6RrrgwnUTAnIsMMaWFzm6BtTTkNGzn39d4hAMYD+uKDj1DGHrtPhq0fYHk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) by PH8PR12MB8429.namprd12.prod.outlook.com (2603:10b6:510:258::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.34; Wed, 26 Apr 2023 18:15:52 +0000 Received: from MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::6f2d:9990:c8b5:714a]) by MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::6f2d:9990:c8b5:714a%6]) with mapi id 15.20.6340.021; Wed, 26 Apr 2023 18:15:52 +0000 Message-ID: <63332095-0139-3428-5b72-ff8394ccba67@amd.com> Date: Wed, 26 Apr 2023 19:15:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH next 0/7] vmxnet3: upgrade to version 7 Content-Language: en-US From: Ferruh Yigit To: Ronak Doshi Cc: dev@dpdk.org References: <20230412162636.30843-1-doshir@vmware.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0003.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:150::8) To MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB4301:EE_|PH8PR12MB8429:EE_ X-MS-Office365-Filtering-Correlation-Id: 1aae667e-f6fe-475b-d33a-08db46824525 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xOxzx5u0Agn9dYNB68781rfqKmYf/evRaa72P/g3UMH0wIwC+/3TNh5owzqxzxw4k3FsLGwpA7iAr4yHZ4dbydXtgdI433Ujs1NE5rdzMGZdF72dYi0jK5RcH6fFsijOG7UXv0kFkjfBJqFrpQHhz/6MMhEUygSAyGG5AH+YF6s2Lw2nX/7kRyHPo1b4ZAH2CWjOJWlu16IQC6t4hu1f0QVrc4SaI03zXb0EEfjqacnrDyEbZ+fgYHwrkxNkX5hHN01bEZ15yiOeBPc2LSTJJkjqDymFr/0pM4ptr7hg2v1DmaxvPMIm7sjAAfKu767GXMYdPyCNXAOxJZlmuOqj78rIyEkKjNbHraWH20903maPPktxrMipiaXFRCCbie1dNDgxD97jHvqwGfK/nPji6xB110ecaKzarNMBul0dJ3KnIjMTTrTIKe9yk+TgCnIk7OTYzb3hZee1dygvAv7WWQKYTur1sZ7aOctv/64UsibPg5JuCaPiSAII0g+QOI+1UiZgVDjBuitaxPzF7quSTy1nqx1kIecRc9toVuOjXDXzz+SvQhJFm5SLWxf4R6qRTOSY4R6f7z17GiS0rftWejZmGB8TgRgZs4ZO50470OZcUdefwUwK5etZcqafrimk18GlPh3bjNeBbG3DHoMB6g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4301.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(136003)(346002)(366004)(396003)(39860400002)(451199021)(83380400001)(186003)(6486002)(478600001)(6666004)(2616005)(26005)(6512007)(6506007)(53546011)(5660300002)(44832011)(36756003)(86362001)(38100700002)(66556008)(66946007)(2906002)(41300700001)(6916009)(66476007)(31696002)(4326008)(316002)(8676002)(8936002)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RytBcWdsUFBDa0RHc0VIYVdHU0N4RTdhQ3VsZ2o5bUlSRnNaTmhGNUhUZWo0?= =?utf-8?B?bExNSW52ZXhhOEgrbWwrbG9NZ0NGRVpoZVBvTndnRmdVcVVoK2lxV1BDSFM0?= =?utf-8?B?ZGR6NTZYcGhDUWRESEI5STRBbWY4K1RXNGFLY25xZU5pUXphT3Fsb0s0TjlI?= =?utf-8?B?bnQ4NTBUczZzYUpXWEc1SHBVUzdmOWc1NzNHZ0o5K1RBRmlJbkRXRG13dUMy?= =?utf-8?B?SG9xcXFBYjJmMTM3NjdKRjk5MnR1M2EyYmpMdURKWS8xN1graHBHVUc3enh5?= =?utf-8?B?Tm1pbXpaZmc1MlBsM1pxUDdGcm9jcVoybWtnbUlWdnJCeWdsaXQ3Tm5PNU9x?= =?utf-8?B?RFVQaXNPelZjZlBTOEFtM2ZwS0ZqamdiVkoxdVpYZnhtbXhiL1NnUzhiekox?= =?utf-8?B?TEVFVnhVZ3ducnJ2UkRRb0dIcVh2SjM5NnhsZyt5VGVnSkRMRXlnSnZvbzdx?= =?utf-8?B?TXdmU01US3d4a3lQNTdzV2Q4cmxuMkcxTnhkMCtOekJTNkhlWXZaLzNEZG5X?= =?utf-8?B?dGVOMGpxMXN4STZmYjlaOGtuODJoM3RQRmhNRWMvY0RqZHFVWUIwTkhPamFa?= =?utf-8?B?SWhqekhKdU5Za1ppaGxsOHlxVUNYb2ZTT1MrUXpvTXpGaGpCNFR0V1lsSGxh?= =?utf-8?B?bjVmaGkvQ0hRVksvWlE0QXFOQ3kvVGFqOVFHNUFYWTg2Nmw3WmhhODNtd2lC?= =?utf-8?B?NXgrUDU5Y0QrcjVKR2hBQXlOeWV4bWNyVVBuNG1qM2lJeG1jSldNVVZkMUpp?= =?utf-8?B?aXowV2R4bjR2T29leDBCRnhxZkxYMHIwVE0zNVpnUnkzbUZ3TFh6S3FQQldo?= =?utf-8?B?eUZkY3dWdTAzN25mTEUzSXNoZnpDUFFsZ1cxOFdsSitSeGpqK3RPUXZDSVBS?= =?utf-8?B?OWtjTUc2SElGTHZCWkdxTXFkaGl6dUNuR2o2NDBHYUdTN2x2RldYZTdwTERq?= =?utf-8?B?RCtVZWtFNm5KazhZb3lUWVBPbmlsZFQxZUNQaUJ1VmtuY0lrZkVrdDlEeVJ3?= =?utf-8?B?STlhQnJiUkJyRGVBZjFRZHBTWElSQ3FoMjYxdzdqZUlRYUh3MkF1RHdMcjVx?= =?utf-8?B?WnBhUG5ZME84bDMzNnd1bkRuVnhZbENNZFVzOWc0TVBob3JYWGFaeWJhbVpQ?= =?utf-8?B?ZFI4OHJVdWRpTG84V2dUaWFqSlFMbHUveENwbGsvK25LZFFVaHNVbFhadXJk?= =?utf-8?B?S1RKWjdNT3JLVS82eW41Q1l1enlXOEV0eUxrM3JIbmdoU3FEb0FycXZ2ZDlP?= =?utf-8?B?aUt2Zmg3Mm9paSsxcDlVN3BVczltMlp4Umx0b3puUm44YTN0bGRPeUVPRTVH?= =?utf-8?B?elRJbThITlR5a1JONFltQ0Vxa0FDRGJDQUZwb2ZTaTdmS1BhMDdnMWxlY3Fs?= =?utf-8?B?TXZSeUpkS211M05PbnlFVVdDc0ExMmdEV3pnaDU4ZkR0SFg2NXJkL0pxTjh3?= =?utf-8?B?T3VRcUFxYVQyMDZraDlySUM5M3NMMGtMeWF2N2xYYkk4MzJRSmdvVWdnMGtB?= =?utf-8?B?VWRaWlJVSmQ5UkVSalBEV0tYSmFPTHUxQjkwSjR0T0RTQ05aR0Jjb2hpTnJJ?= =?utf-8?B?Qm00WWRrWEhmN25PSlcvYW9POXh4QnViZy9pL0txcWkvYmNvQUt3V285NVBR?= =?utf-8?B?dG80K1p6ditZaUxYUzN3eTdQZTBkdm1rQnZtckpHUHM2LzR0VEJ1cGlDUVNz?= =?utf-8?B?Q1dLOG9lb29McFJnZUo4K0hScVFCQVhaSVdyYzNEWWVWamhRUXR3WTlueS9i?= =?utf-8?B?ajZReW85UUVyNmczbTR6UXlpWVduMWhMSFNRcjZQcExhM01CRjNkV01OME5m?= =?utf-8?B?V3RJRGtXQTMrRW9Na21kU25lZEJIdjdoOUdxV2xDdkxaYVVRS3p3TitwV1Vh?= =?utf-8?B?a1Y3cGlNVDduVFcwL1I1dC9KVjlDOGdmUzVnektSVmRLMmNYSUViUktHOU8x?= =?utf-8?B?VW0xc2VORFZNSWVabzloMzFmUHlVSGNLc2h5OS9YV3FPLysyTGVncFZTYlI0?= =?utf-8?B?S0puaGUvSHMvTmE3Y2ZkdjZTUG9xTE5acjAvMjkwcXY5bVBBZXdOaGREWCs5?= =?utf-8?B?UjdGeWJuRXpGZjBQT3pKakhVVGRyV2FZdFB6b0RHUWMrbW92Uy90ZHYyRENi?= =?utf-8?Q?ZEmLRsTfCcveu+ufPMfVwDfqc?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1aae667e-f6fe-475b-d33a-08db46824525 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4301.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2023 18:15:52.5421 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cpEBqk7fhacxcjG4t9gjHxPmMcG1QBhNJGyZlZQAhBX4wqfimydJSxKTeaE2ZYHY X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB8429 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/26/2023 5:54 PM, Ferruh Yigit wrote: > On 4/12/2023 5:26 PM, Ronak Doshi wrote: >> vmxnet3 emulation has recently added several new features including >> support for uniform passthrough(UPT). To make UPT work vmxnet3 has >> to be enhanced as per the new specification. This patch series >> extends the vmxnet3 driver to leverage these new features. >> >> Compatibility is maintained using existing vmxnet3 versioning mechanism as >> follows: >> - new features added to vmxnet3 emulation are associated with new vmxnet3 >> version viz. vmxnet3 version 7. >> - emulation advertises all the versions it supports to the driver. >> - during initialization, vmxnet3 driver picks the highest version number >> supported by both the emulation and the driver and configures emulation >> to run at that version. >> >> In particular, following changes are introduced: >> >> Patch 1: >> This patch introduces utility macros for vmxnet3 version 7 comparison >> and updates Copyright information. >> >> Patch 2: >> This patch adds new capability registers to fine control enablement of >> individual features based on emulation and passthrough. >> >> Patch 3: >> This patch adds support for large passthrough BAR register. >> >> Patch 4: >> This patch introduces new command to set ring buffer sizes to pass this >> information to the hardware. >> >> Patch 5: >> For better performance, hardware has a requirement to limit number of TSO >> descriptors. This patch adds that support. >> >> Patch 6: >> Avoid updating rxprod register when in UPT for performance reasons. >> >> Patch 7: >> With all vmxnet3 version 7 changes incorporated in the vmxnet3 driver, >> with this patch, the driver can configure emulation to run at vmxnet3 >> version 7. >> >> Ronak Doshi (7): >> vmxnet3: prepare for version 7 changes >> vmxnet3: add support for capability registers >> vmxnet3: add support for large passthrough BAR register >> vmxnet3: add command to set ring buffer sizes >> vmxnet3: limit number of TXDs used for TSO packet >> vmxnet3: avoid updating rxprod register frequently >> vmxnet3: update to version 7 >> > > Can you please start the patch title with component: "net/vmxnet3: ..." > >> drivers/net/vmxnet3/base/vmxnet3_defs.h | 74 +++++++++++++++++++--- >> drivers/net/vmxnet3/vmxnet3_ethdev.c | 106 +++++++++++++++++++++++++++++++- >> drivers/net/vmxnet3/vmxnet3_ethdev.h | 16 +++++ >> drivers/net/vmxnet3/vmxnet3_ring.h | 2 +- >> drivers/net/vmxnet3/vmxnet3_rxtx.c | 48 +++++++++++---- >> lib/ethdev/rte_ethdev.h | 2 + >> 6 files changed, 226 insertions(+), 22 deletions(-) >> > > Can you please update release notes to document the driver update? > > Also what do you think to update driver documentation to document > uniform passthrough(UPT) support, how to use it etc? Or other features > coming with V7? > btw, while checking the driver documentation, it seems it is not updated for a while, the paper it refers is old. Do you have any newer version of documentation to reference?