From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35963A0548; Fri, 9 Jul 2021 17:57:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1AFD6416E0; Fri, 9 Jul 2021 17:57:47 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 876E8410F9 for ; Fri, 9 Jul 2021 17:57:44 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10039"; a="295363593" X-IronPort-AV: E=Sophos;i="5.84,226,1620716400"; d="scan'208";a="295363593" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2021 08:56:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,226,1620716400"; d="scan'208";a="458314786" Received: from silpixa00399498.ir.intel.com (HELO silpixa00399498.ger.corp.intel.com) ([10.237.223.53]) by orsmga008.jf.intel.com with ESMTP; 09 Jul 2021 08:56:00 -0700 From: Anatoly Burakov To: dev@dpdk.org, David Hunt Cc: anatoly.burakov@intel.com, David Marchand Date: Fri, 9 Jul 2021 15:55:59 +0000 Message-Id: <634db86689fc6a6ff28c5e59aff340d81f711a42.1625846156.git.anatoly.burakov@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <77dc13d24d7c77526e088756784ce073bc02fe7f.1625842874.git.anatoly.burakov@intel.com> References: <77dc13d24d7c77526e088756784ce073bc02fe7f.1625842874.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 1/1] power: fix potential null dereferences X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Currently, the error paths can lead to attempts at dereferencing NULL pointers. Add the check to avoid attempts at dereferencing NULL pointers. Coverity issue: 371895 Coverity issue: 371889 Fixes: 06cffd468fdd ("power: refactor ACPI and intel_pstate support") Cc: anatoly.burakov@intel.com Signed-off-by: Anatoly Burakov Reviewed-by: David Marchand --- lib/power/power_pstate_cpufreq.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/power/power_pstate_cpufreq.c b/lib/power/power_pstate_cpufreq.c index ba28ddcfca..3b607515fd 100644 --- a/lib/power/power_pstate_cpufreq.c +++ b/lib/power/power_pstate_cpufreq.c @@ -440,8 +440,10 @@ power_get_available_freqs(struct pstate_power_info *pi) num_freqs, pi->lcore_id); out: - fclose(f_min); - fclose(f_max); + if (f_min != NULL) + fclose(f_min); + if (f_max != NULL) + fclose(f_max); return ret; } -- 2.25.1