From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id DB1805585 for ; Wed, 30 Nov 2016 16:31:47 +0100 (CET) Received: by mail-wm0-f52.google.com with SMTP id g23so272989429wme.1 for ; Wed, 30 Nov 2016 07:31:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=zHaAk6sbSioQhWhrFhBMbRh1DFxy/V72vtYrkQogsYo=; b=d8y3nhvbpIQXkiT2VilRR6IY9f49HEWSqUQt7d9WyBwDhDbrLMAZZyPcbo5wSOkPAF 8XtT6GqiE0eZiZpU0YafgDvIk8DOe6D0W2WAlGscqWwp8VWD8/zGg8Pga6Px/RKpZFC/ W+UwJ1AYTlVG6YBXBZ1HTbeuJ6sIquKzfeb6VCjkQlkj6SADnAKYLZgBAZPxueYxLs7a nO48obtXt9VUA7C+U3y3+ykPZcBgtgzjMks41Th42KgmqFCfHfAihVTT9Lt82gx2ZCTz uYFNJ19sHlfgNqxTuuizxltYKgGuXPBQzUiRLdVny80vnbf/MwhUwSCGT1OOLKb7NcDT rpFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=zHaAk6sbSioQhWhrFhBMbRh1DFxy/V72vtYrkQogsYo=; b=VywoyJ1170Ay34hrd8cyCZrcsLgsNfiBrDj9fn8tCv2f3EhetfwUzJEvWQdYL6Irh+ 6tsp6lkJ18JpNEGx+YZq2Bip6d9a/I1gbX7J9Y5aq0S2/sNwqObCOEEIv6Vuu4hg5h/q 8/00jry+q8z+3DAbxEikwp4dzIzuN9tmdnOp3JUny5t/7IKBywAS0w/IvvlBOLX/+hoS Y7HJz4JOE7zti4Kan+eDQiTrDwuwHuyTaCzc+pX0T+C6M3+sIbywFw51R7cq6q8d48AS WoMrZtnhCnAI9xbCR+ZcN6+ZdtLVrTyO8jvaIgusKoIc/fdxW3D/8EGaKMn+j9kh42IM hQjw== X-Gm-Message-State: AKaTC03TQqCq9myHktdX0hwl0zIngTeicOMMXDkRmBuz1PgYQfJtwMJQPOk3Tb3bwhveNUWi X-Received: by 10.194.104.39 with SMTP id gb7mr28534388wjb.139.1480519907588; Wed, 30 Nov 2016 07:31:47 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id pd2sm73430616wjb.31.2016.11.30.07.31.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Nov 2016 07:31:46 -0800 (PST) From: Thomas Monjalon To: Bruce Richardson Cc: Ferruh Yigit , dev@dpdk.org Date: Wed, 30 Nov 2016 16:31:46 +0100 Message-ID: <6354876.YigQL2JU2Y@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20161130152622.GA259108@bricha3-MOBL3.ger.corp.intel.com> References: <1479768194-6255-1-git-send-email-thomas.monjalon@6wind.com> <3896815.T41b2RsLT8@xps13> <20161130152622.GA259108@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] scripts: check cc stable mailing list in commit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Nov 2016 15:31:48 -0000 2016-11-30 15:26, Bruce Richardson: > On Wed, Nov 30, 2016 at 04:09:47PM +0100, Thomas Monjalon wrote: > > 2016-11-30 14:54, Ferruh Yigit: > > > On 11/21/2016 10:43 PM, Thomas Monjalon wrote: > > > > +stablefixes=$($selfdir/git-log-fixes.sh $range | sed '/(N\/A)$/d' | cut -d' ' -f2) > > > > > > This breaks the "check-git-log.sh -N" usage, since "-N" is not a valid > > > range for git-log-fixes.sh. > > > Generates warning: > > > .../scripts/git-log-fixes.sh: illegal option -- 6 > > > usage: git-log-fixes.sh [-h] > > > > Yes, good catch. > > I'm trying to fix it by converting -N to HEAD~N.. > > > > if printf -- $range | grep -q '^-[0-9]\+' ; then > > range="HEAD$(printf -- $range | sed 's,^-,~,').." > > fi > > > > > > +# check CC:stable for fixes > > > > +bad=$(for fix in $stablefixes ; do > > > > + git log --format='%b' -1 $fix | grep -qi '^CC: *stable@dpdk.org' || > > > > + git log --format='\t%s' -1 $fix > > > > +done) > > > > +[ -z "$bad" ] || printf "Should CC: stable@dpdk.org\n$bad\n" > > > > > > This is good for developer, but since "CC: xx" tags removed when patch > > > applied, this will generate warnings when run against existing history. > > > > I do not think it is a problem. > > Who runs this tool against existing history? > > > > Me for one. I prefer to run the script against the commits in the repo > before I generate the patches, rather than manually hand-editing the > patches afterward - or having to fix the repo and then regenerate them. > Also, when I was maintaining the next-net tree, I used to use pwclient git-am > to apply a patch, and then check-got-log.sh -1 to sanity check it once > build checks had passed. I am not sure to understand. You explain that you run the script for the commits you are going to send or going to push. That's the normal usage. In your cases you should have the CC: stable or you will have the warning.