From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 616EC42413;
	Thu, 19 Jan 2023 06:22:36 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 531FC410DD;
	Thu, 19 Jan 2023 06:22:36 +0100 (CET)
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by mails.dpdk.org (Postfix) with ESMTP id B295F4068E
 for <dev@dpdk.org>; Thu, 19 Jan 2023 06:22:34 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 3566261A60;
 Thu, 19 Jan 2023 05:22:34 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3ECA3C433F0;
 Thu, 19 Jan 2023 05:22:33 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
 s=k20201202; t=1674105753;
 bh=zlfFy43dnHTzIZqkCbLAFImGfNmfh0+K82LhE/0BjB4=;
 h=Subject:From:To:Cc:Date:In-Reply-To:References:From;
 b=SLubNigSR9PCvMKWyNPdeOk39FSpeCxCzBQKVLDB78OGklKN6IM5Be1umterywhP+
 saLrQ+7U2bnUdAoiOxqhqTFz5jB3H83feJ+5Q+wTloDNtdjSc3vJFMIIxjSOG+Efrr
 ZbWlzJbxZSr2nKMYFVLeBz9Sm0YEvR5m2p04CSHPgZtCjIrdBnPs5+o2rTOVtDmXZe
 dTq+rpiJDQ3UPQXZ2PwRfe62Rih6TUrt01vJ8mkdk72H8QFfP9uuRoedrcRyBYE5Po
 4NA5Uz3hU6SNq9/WdmXn0PO212jMBgeva/SPD5aqpeyDjwiIqZp/je1HpyOfQ0qH6h
 x3VmNoj8VNQEw==
Message-ID: <635a6e3bcabf6ced16eb87cd8544a11c0a576a73.camel@kernel.org>
Subject: Re: [PATCH RESEND v2 01/11] ethdev: check return result of
 rte_eth_dev_info_get
From: Sinan Kaya <okaya@kernel.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org
Date: Thu, 19 Jan 2023 00:22:31 -0500
In-Reply-To: <2581232.ECZNHGQPT7@thomas>
References: <20221122153053.1172434-1-okaya@kernel.org>
 <20221122153053.1172434-2-okaya@kernel.org> <2581232.ECZNHGQPT7@thomas>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Wed, 2023-01-18 at 09:42 +0100, Thomas Monjalon wrote:
> 22/11/2022 16:30, 
> okaya@kernel.org
> :
> 
> > rte_class_eth: eth_mac_cmp: The status of this call to
> > rte_eth_dev_info_get
> > is not checked, potentially leaving dev_info uninitialized.
> 
> [...]
> 
> >        /* Return 0 if devargs MAC is matching one of the device
> > MACs. */
> > -     rte_eth_dev_info_get(data->port_id, &dev_info);
> > +     if (rte_eth_dev_info_get(data->port_id, &dev_info) < 0)
> > +             return -1;
> > +
> >        for (index = 0; index < dev_info.max_mac_addrs; index++)
> >                if (rte_is_same_ether_addr(&mac, &data-
> > >mac_addrs[index]))
> >                        return 0;
> 
> 
> 
> Acked-by: Thomas Monjalon <
> thomas@monjalon.net
> >
> 
> 

Thanks.

> 
> You would get more attention if you Cc the maintainers.
> 
> You can use this git option: --cc-cmd devtools/get-maintainer.sh

Good to know that we have get-maintainer script.