From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Jianfeng Tan <jianfeng.tan@intel.com>,
dev@dpdk.org, santosh.shukla@caviumnetworks.com,
ferruh.yigit@intel.com
Cc: sergio.gonzalez.monroy@intel.com, thomas@monjalon.net,
Peter Xu <peterx@redhat.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] net: enable IOVA mode for PMDs
Date: Fri, 5 Jan 2018 11:32:42 +0100 [thread overview]
Message-ID: <6367d190-5d4b-71c1-5790-3b488f4dcc18@redhat.com> (raw)
In-Reply-To: <1507718028-12943-3-git-send-email-jianfeng.tan@intel.com>
Hi Jianfeng,
On 10/11/2017 12:33 PM, Jianfeng Tan wrote:
> If we want to enable IOVA mode, introduced by
> commit 93878cf0255e ("eal: introduce helper API for IOVA mode"),
> we need PMDs (for PCI devices) to expose this flag.
>
> Signed-off-by: Jianfeng Tan<jianfeng.tan@intel.com>
> ---
> drivers/net/e1000/em_ethdev.c | 3 ++-
> drivers/net/e1000/igb_ethdev.c | 5 +++--
> drivers/net/fm10k/fm10k_ethdev.c | 3 ++-
> drivers/net/i40e/i40e_ethdev.c | 3 ++-
> drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
> drivers/net/ixgbe/ixgbe_ethdev.c | 5 +++--
> 6 files changed, 13 insertions(+), 8 deletions(-)
This patch introduces a regression when doing device assignment in
guest, because current VT-d emulation only supports 39bits guest address
width [0].
In the Bz, Peter suggest we could have an IOVA allocator algorithm,
which could start to allocate IOVAs from 0. I think it could solve the
--no-huge case your series address, do you agree?
But it would be a long term solution, we need to fix this in stable.
Is the --no-huge option used in production, or is it only for testing?
If the latter do you think we could revert your patch while we find a
solution that makes all cases to work?
Ferruh, I see you also faced problems with KNI, how did you solved it?
Thanks,
Maxime
[0]: https://bugzilla.redhat.com/show_bug.cgi?id=1530957#c3
next prev parent reply other threads:[~2018-01-05 10:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 10:33 [dpdk-dev] [PATCH 0/2] enable 4KB + VFIO-PCI Jianfeng Tan
2017-10-11 10:33 ` [dpdk-dev] [PATCH 1/2] eal: honor IOVA mode for no-huge case Jianfeng Tan
2017-10-11 11:27 ` Burakov, Anatoly
2017-10-11 11:30 ` santosh
2017-10-31 21:49 ` Ferruh Yigit
2017-10-31 22:37 ` Ferruh Yigit
2017-11-01 1:10 ` Ferruh Yigit
2017-10-11 10:33 ` [dpdk-dev] [PATCH 2/2] net: enable IOVA mode for PMDs Jianfeng Tan
2017-10-11 10:43 ` Burakov, Anatoly
2017-10-11 10:56 ` Tan, Jianfeng
2017-10-11 11:30 ` Burakov, Anatoly
2017-10-11 11:33 ` santosh
2018-01-05 10:32 ` Maxime Coquelin [this message]
2018-01-05 12:04 ` Maxime Coquelin
2018-01-05 12:10 ` santosh
2018-01-05 12:57 ` Maxime Coquelin
2017-10-11 10:47 ` [dpdk-dev] [PATCH 0/2] enable 4KB + VFIO-PCI Burakov, Anatoly
2017-10-11 10:50 ` Thomas Monjalon
2017-10-12 19:57 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6367d190-5d4b-71c1-5790-3b488f4dcc18@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jianfeng.tan@intel.com \
--cc=peterx@redhat.com \
--cc=santosh.shukla@caviumnetworks.com \
--cc=sergio.gonzalez.monroy@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).