From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 98FF41B1A9 for ; Fri, 5 Jan 2018 11:32:48 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 73EDDC057F83; Fri, 5 Jan 2018 10:32:47 +0000 (UTC) Received: from [10.36.112.27] (ovpn-112-27.ams2.redhat.com [10.36.112.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D0E435D6A8; Fri, 5 Jan 2018 10:32:44 +0000 (UTC) To: Jianfeng Tan , dev@dpdk.org, santosh.shukla@caviumnetworks.com, ferruh.yigit@intel.com Cc: sergio.gonzalez.monroy@intel.com, thomas@monjalon.net, Peter Xu References: <1507718028-12943-1-git-send-email-jianfeng.tan@intel.com> <1507718028-12943-3-git-send-email-jianfeng.tan@intel.com> From: Maxime Coquelin Message-ID: <6367d190-5d4b-71c1-5790-3b488f4dcc18@redhat.com> Date: Fri, 5 Jan 2018 11:32:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1507718028-12943-3-git-send-email-jianfeng.tan@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 05 Jan 2018 10:32:47 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 2/2] net: enable IOVA mode for PMDs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jan 2018 10:32:48 -0000 Hi Jianfeng, On 10/11/2017 12:33 PM, Jianfeng Tan wrote: > If we want to enable IOVA mode, introduced by > commit 93878cf0255e ("eal: introduce helper API for IOVA mode"), > we need PMDs (for PCI devices) to expose this flag. > > Signed-off-by: Jianfeng Tan > --- > drivers/net/e1000/em_ethdev.c | 3 ++- > drivers/net/e1000/igb_ethdev.c | 5 +++-- > drivers/net/fm10k/fm10k_ethdev.c | 3 ++- > drivers/net/i40e/i40e_ethdev.c | 3 ++- > drivers/net/i40e/i40e_ethdev_vf.c | 2 +- > drivers/net/ixgbe/ixgbe_ethdev.c | 5 +++-- > 6 files changed, 13 insertions(+), 8 deletions(-) This patch introduces a regression when doing device assignment in guest, because current VT-d emulation only supports 39bits guest address width [0]. In the Bz, Peter suggest we could have an IOVA allocator algorithm, which could start to allocate IOVAs from 0. I think it could solve the --no-huge case your series address, do you agree? But it would be a long term solution, we need to fix this in stable. Is the --no-huge option used in production, or is it only for testing? If the latter do you think we could revert your patch while we find a solution that makes all cases to work? Ferruh, I see you also faced problems with KNI, how did you solved it? Thanks, Maxime [0]: https://bugzilla.redhat.com/show_bug.cgi?id=1530957#c3