From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, david.marchand@redhat.com, stable@dpdk.org,
Chengwen Feng <fengchengwen@huawei.com>
Subject: Re: [PATCH] telemetry: make socket handler typedef private
Date: Tue, 11 Nov 2025 19:14:30 +0100 [thread overview]
Message-ID: <6375554.3sPnXxR9tc@thomas> (raw)
In-Reply-To: <20251107093259.3305537-1-bruce.richardson@intel.com>
07/11/2025 10:32, Bruce Richardson:
> The socket handler typedef, just called "handler" does not belong in the
> public namespace, especially since it is unprefixed. Rename to
> "telemetry_sock_handler" and move to internal header.
>
> Doing so also clears shadowing warnings in dmadev library, when it is
> built with -Wshadow.
>
> Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality")
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Chengwen Feng <fengchengwen@huawei.com>
>
> ---
> NOTE: This patch was originally submitted as part of series[1], but I
> think this is a serious enough fix to consider taking into 25.11.
Applied, thanks.
prev parent reply other threads:[~2025-11-11 18:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-07 9:32 Bruce Richardson
2025-11-11 18:14 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6375554.3sPnXxR9tc@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).