From: Ferruh Yigit <ferruh.yigit@xilinx.com>
To: Ori Kam <orika@nvidia.com>,
"Sean Zhang (Networking SW)" <xiazhang@nvidia.com>,
Xiaoyun Li <xiaoyun.li@intel.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Jiawei(Jonny) Wang" <jiaweiw@nvidia.com>,
Alexander Kozyrev <akozyrev@nvidia.com>
Subject: Re: [v1 1/4] ethdev: add IPv4/IPv6 ECN header rewrite action
Date: Thu, 2 Jun 2022 12:44:46 +0100 [thread overview]
Message-ID: <63768d28-a53e-943d-1765-f547211d7415@xilinx.com> (raw)
In-Reply-To: <MW2PR12MB4666B88D9AE6EB57CD41E1B7D6DE9@MW2PR12MB4666.namprd12.prod.outlook.com>
On 6/2/2022 6:48 AM, Ori Kam wrote:
>
>
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@xilinx.com>
>> Sent: Wednesday, June 1, 2022 9:51 PM
>> To: Sean Zhang (Networking SW) <xiazhang@nvidia.com>; Ori Kam <orika@nvidia.com>; Xiaoyun Li
>> <xiaoyun.li@intel.com>; Aman Singh <aman.deep.singh@intel.com>; Yuying Zhang
>> <yuying.zhang@intel.com>; NBU-Contact-Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>;
>> Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>> Cc: dev@dpdk.org; Jiawei(Jonny) Wang <jiaweiw@nvidia.com>; Alexander Kozyrev
>> <akozyrev@nvidia.com>
>> Subject: Re: [v1 1/4] ethdev: add IPv4/IPv6 ECN header rewrite action
>>
>> On 4/2/2022 8:11 AM, Sean Zhang wrote:
>>> From: Jiawei Wang <jiaweiw@nvidia.com>
>>>
>>> This patch introduces the IPv4/IPv6 ECN modify field support, and
>>> adds the testpmd CLI commands support.
>>>
>>> Usage:
>>> modify_field op set dst_type ipv4_ecn src_type ...
>>>
>>> For example:
>>>
>>> flow create 0 ingress group 1 pattern eth / ipv4 / end actions
>>> modify_field op set dst_type ipv4_ecn src_type value src_value
>>> 0x03 width 2 / queue index 0 / end
>>>
>>> Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>
>>
>> cc'ed Alexander.
>>
>> Patch looks good to me, only perhaps release notes can be updated, what
>> do you think?
>>
>> @Ori, @Alex, do you have any objection/comment?
>
> Acked-by: Ori Kam <orika@nvidia.com>
Applied to dpdk-next-net/main, thanks.
next prev parent reply other threads:[~2022-06-02 11:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-02 7:11 [v1 0/4] Add support for modifying ECN in IPv4/IPv6 header Sean Zhang
2022-04-02 7:11 ` [v1 1/4] ethdev: add IPv4/IPv6 ECN header rewrite action Sean Zhang
2022-06-01 18:51 ` Ferruh Yigit
2022-06-02 5:48 ` Ori Kam
2022-06-02 11:44 ` Ferruh Yigit [this message]
2022-04-02 7:11 ` [v1 2/4] common/mlx5: add modify ECN capability check Sean Zhang
2022-06-06 8:05 ` Slava Ovsiienko
2022-04-02 7:11 ` [v1 3/4] net/mlx5: add support to modify ECN field Sean Zhang
2022-06-06 7:17 ` Slava Ovsiienko
2022-04-02 7:11 ` [v1 4/4] net/mlx5: add modify field support in meter Sean Zhang
2022-06-06 7:18 ` Slava Ovsiienko
2022-06-01 18:51 ` [v1 0/4] Add support for modifying ECN in IPv4/IPv6 header Ferruh Yigit
2022-06-02 11:44 ` Ferruh Yigit
2022-06-02 13:13 ` Sean Zhang (Networking SW)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63768d28-a53e-943d-1765-f547211d7415@xilinx.com \
--to=ferruh.yigit@xilinx.com \
--cc=akozyrev@nvidia.com \
--cc=aman.deep.singh@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=jiaweiw@nvidia.com \
--cc=orika@nvidia.com \
--cc=thomas@monjalon.net \
--cc=xiaoyun.li@intel.com \
--cc=xiazhang@nvidia.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).