From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3D0BA0548; Thu, 2 Jun 2022 13:44:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 09E5240E50; Thu, 2 Jun 2022 13:44:53 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2068.outbound.protection.outlook.com [40.107.244.68]) by mails.dpdk.org (Postfix) with ESMTP id CBA064021E for ; Thu, 2 Jun 2022 13:44:51 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IUhy1XB7e6D8Dmaz61urRC+wxT7zUQHvX717Zb7ESUqQyyLMmHGs7vD0F86AAliUEpVqF7OKvOX8FsqUMQxXHIe9Kn1WD2L/YRTOC+OV3Yx229HtPsz8QHykPK0gUq46i+ug92swOT9mtt045kkJ5sakMOul/vbEUwdnfLRwOnY78FbYvwRnLp1RxUqHqJKQ4P2PdR/+b6Kbc0y9SeK1hfdZRCzoMkhqSq+3fAvJ1coGHPPjHqIQH1MS6abn5LDWJUIGLVDgePXbA5lqDQklxAjlRKA5i6SCmeBLXI4wEC2zzXP8GU13IvIBJ8VsMFNMBLs595Ps11t5d+1WhkNH7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=04hK0+LHmBSWTm2oPnIkdvLQACZvx2UUAuqU14H7zWw=; b=TEkD/yhwTpIkOtxrtTuRTLxrtEWt30No3F4j8ZiqayCzllZWWPAzp9qWjy/+sbQoAh/wP9jAXfMdFxQ/xlc44Gq34F8OnieD1hl+mbWddLvg9Z4kVA94XED1xpDarbSjHzcZ07KJpt9zlRbAoQLMweT+MiQKanH55MFnXlFG1je9fPU0nsF6YERi3TchpBrMgXwWw19ZiVhcAd/MVgGc4YpYZg+NVbzoQRTUDUuQmnzIWhY8mK0STX0dbK9ZFji/iw+JAcnDe2rI0f2Q0lZ8uvXPYBDXb/oXBW03sBQfmGIal7e5n4nE1q+10SjETm5Awc/Y7DXBEcS8tII3rGfbuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=nvidia.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=04hK0+LHmBSWTm2oPnIkdvLQACZvx2UUAuqU14H7zWw=; b=dls8iiDyUXWiehYMQ8VuAPe8KnaxzcUSPwo1ODlKLCqBDq1zQZe67Nr6+rL9WXaxRW+xbjmPmZz2nyLstN0Vm79sDB/g3LjwKqCRk9+BhpnVXPS1xTkS6vWySxZHlUvmczHF0i4dA8W53WPVeGNY8LcpuEUCY6iMrd1xY/grJaA= Received: from BN9PR03CA0344.namprd03.prod.outlook.com (2603:10b6:408:f6::19) by BL0PR02MB6481.namprd02.prod.outlook.com (2603:10b6:208:1c5::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.13; Thu, 2 Jun 2022 11:44:49 +0000 Received: from BN1NAM02FT017.eop-nam02.prod.protection.outlook.com (2603:10b6:408:f6:cafe::65) by BN9PR03CA0344.outlook.office365.com (2603:10b6:408:f6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Thu, 2 Jun 2022 11:44:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com; pr=C Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by BN1NAM02FT017.mail.protection.outlook.com (10.13.2.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5314.12 via Frontend Transport; Thu, 2 Jun 2022 11:44:49 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Thu, 2 Jun 2022 12:44:48 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Thu, 2 Jun 2022 12:44:48 +0100 Envelope-to: orika@nvidia.com, xiazhang@nvidia.com, xiaoyun.li@intel.com, aman.deep.singh@intel.com, yuying.zhang@intel.com, thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru, dev@dpdk.org, jiaweiw@nvidia.com, akozyrev@nvidia.com Received: from [10.71.116.10] (port=64395) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nwjFu-0007D3-Ux; Thu, 02 Jun 2022 12:44:48 +0100 Message-ID: <63768d28-a53e-943d-1765-f547211d7415@xilinx.com> Date: Thu, 2 Jun 2022 12:44:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [v1 1/4] ethdev: add IPv4/IPv6 ECN header rewrite action Content-Language: en-US To: Ori Kam , "Sean Zhang (Networking SW)" , Xiaoyun Li , Aman Singh , Yuying Zhang , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Andrew Rybchenko CC: "dev@dpdk.org" , "Jiawei(Jonny) Wang" , Alexander Kozyrev References: <20220402071150.9392-1-xiazhang@nvidia.com> <20220402071150.9392-2-xiazhang@nvidia.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0ccd4dc3-f51a-4b66-64ce-08da448d4ca2 X-MS-TrafficTypeDiagnostic: BL0PR02MB6481:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZM72a8JToZoEs8gOgXYOaglDeN8Csg7xfg/FKnYIvNEUSNkCi4hqYEZg8GKwkVKo21TEob5YtFf5kx/4/I7V8Yoq2wqWlSn6BVPnDDcLoHRRPuKgIV0UtJ+i1fCaBoc6x0SA59u2v3sov/0LVymjFWo4T4XDCpsY4Ivp6W/a/L61E8pfjDtaDT18sNf1IlwuS8BxFJMHMhszawQ3siPyjcgmw5/kyBm7sB6hn97T42agjeHldhRZQSMXPm4p3OX832j1I+ffjVwLykxzEas8cfBFtER/ls+q3xJobiLCimAmZ58LTdd0cueDiOVb9i6e5zYzL2MAiezxll/rYn6eJE0aOiPuZgOuNu0kVy436S8UR8pv+luvRQm88m8T/fqYMu2DUY4gM0NtVn5cZiZpfHBycMkCmQffGxZK1BqenUxY14oqkmhF8s/mse0n/CfOMr5p9UUVx6WAWn5Fg6pUG/hUlYeZ5pFQX+BrjxfOECa/qzDl9HZWTBV8qatz1bJiDq2MOFIwQJ4TH/F3MBOqaxlyXYaag+SIHuqkT2LRnn6UkfQiNKTiazn+HOfDkriXtaRHBWBGFYF8VugGme41KIzCivkoJZ7Tb9KoTHY7lGhUvT+7lfUrl47eazLrdfsHFllyrw9kYvWF/kwmCueEF0/ZQ2NlMt97DxjlVLc/VOD9WD0qa/8C2crDzsYXOFjQ/Vnb+dR0y4ovy0M3Fh20s3M2XMdE6nzLcjRNNNMZuKQ= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(8676002)(36860700001)(54906003)(5660300002)(356005)(31696002)(186003)(110136005)(47076005)(4326008)(426003)(44832011)(336012)(36756003)(70586007)(70206006)(508600001)(40460700003)(31686004)(7636003)(316002)(2906002)(53546011)(7416002)(8936002)(9786002)(2616005)(82310400005)(26005)(83380400001)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2022 11:44:49.1416 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0ccd4dc3-f51a-4b66-64ce-08da448d4ca2 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT017.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR02MB6481 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/2/2022 6:48 AM, Ori Kam wrote: > > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Wednesday, June 1, 2022 9:51 PM >> To: Sean Zhang (Networking SW) ; Ori Kam ; Xiaoyun Li >> ; Aman Singh ; Yuying Zhang >> ; NBU-Contact-Thomas Monjalon (EXTERNAL) ; >> Andrew Rybchenko >> Cc: dev@dpdk.org; Jiawei(Jonny) Wang ; Alexander Kozyrev >> >> Subject: Re: [v1 1/4] ethdev: add IPv4/IPv6 ECN header rewrite action >> >> On 4/2/2022 8:11 AM, Sean Zhang wrote: >>> From: Jiawei Wang >>> >>> This patch introduces the IPv4/IPv6 ECN modify field support, and >>> adds the testpmd CLI commands support. >>> >>> Usage: >>> modify_field op set dst_type ipv4_ecn src_type ... >>> >>> For example: >>> >>> flow create 0 ingress group 1 pattern eth / ipv4 / end actions >>> modify_field op set dst_type ipv4_ecn src_type value src_value >>> 0x03 width 2 / queue index 0 / end >>> >>> Signed-off-by: Jiawei Wang >> >> cc'ed Alexander. >> >> Patch looks good to me, only perhaps release notes can be updated, what >> do you think? >> >> @Ori, @Alex, do you have any objection/comment? > > Acked-by: Ori Kam Applied to dpdk-next-net/main, thanks.