From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF733A04E6; Mon, 7 Dec 2020 21:34:54 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E7BB8E07; Mon, 7 Dec 2020 21:34:52 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 2F08BDE3 for ; Mon, 7 Dec 2020 21:34:51 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 9F6101384; Mon, 7 Dec 2020 15:34:48 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 07 Dec 2020 15:34:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= NL9qxXJXIj9jZzYvPHchgELTfxHSF9Y5729HH32YYnY=; b=j3iRW5w4rAcOBSNt TXw7MB20HFEha1VopP5ySiOXcoT3Q/bFyA1XlO+iYSPtDLEw7alK6FiWB28niqzc HkkxCgQBC4AXs2OuvsQkTpWJnXxyHmhHmxdwnlKp66Hzt3ugxtnBuXeb+64OqNJN jRw0aCYagMhXX2RDJECp6+07YqBVyzzZHoEyezC9XKyzJLEgI3mxZSR1Yk+2WVtw Y2oCS2lO/E7XBLfF9iQv592rtckOEvlIxekK+ntvNYAPqbhK5vGgUj0OIKBFqmYn x71RxgiNhBCXH8jQ1XJCyopPx8q3d1PhQeVZGL8SyAq4GR4oG+NndJK3rBIFoAB2 3GVimQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=NL9qxXJXIj9jZzYvPHchgELTfxHSF9Y5729HH32YY nY=; b=fFY3sEpuu2aifgcUAWbGNZWBwTyqNcj7Axl+v5T7lRc50Uoxk3DjCss1v ku3QZJM2KCMjhGv+yPWOhZ98W+uxuiOmNiLQ1HF2I2peVszUhhHFiYl1R+CZfWlQ 1es1TLL2LA/+ZpLyuUyEIcCdFvyzH+UDdjaRD6e1hm4y27HcdXQ7U+gej0ZuPCkP QQCyAJhbtZisjtAGnsqO9Ff+RURd2C2jjLu0owaRQaqpriJaoRIp7uRj/pRw3K4E Pxasgc+P/YtYcDL9JtTXoLvbe/ebW25nrxh/x4NuwoGSec4vZG+QKnZkDD4juQmi af3qxULOPY/ygcmF9yANsy3dikvXg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudejgedgudefkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeelueelvdeghedvkedvteffteduveekhfelfffhteelveegieff keetffelfeefgeenucffohhmrghinhepmhhitghrohhsohhfthdrtghomhenucfkphepje ejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 79B7D108005C; Mon, 7 Dec 2020 15:34:46 -0500 (EST) From: Thomas Monjalon To: Nick Connolly Cc: dev@dpdk.org, Bruce Richardson , David Marchand , Dmitry Kozlyuk , pallavi.kadam@intel.com Date: Mon, 07 Dec 2020 21:34:45 +0100 Message-ID: <6379652.DfeunkggAM@thomas> In-Reply-To: <20201203030215.0e7c6fce@sovereign> References: <20201127113623.26707-1-nick.connolly@mayadata.io> <20201129160024.879-1-nick.connolly@mayadata.io> <20201203030215.0e7c6fce@sovereign> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] windows: build warnings with clang X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/12/2020 01:02, Dmitry Kozlyuk: > On Sun, 29 Nov 2020 16:00:24 +0000, Nick Connolly wrote: > > Microsoft CRT defines Windows-specific secure alternatives to > > standard library functions and triggers warnings when "insecure" > > functions are used [1]. However, calling code already has all > > necessary checks around those functions, so these warnings are not > > useful for DPDK. MinGW provides its own CRT without this issue. > > > > [1]: > > https://docs.microsoft.com/en-us/cpp/c-runtime-library/security-features-in-the-crt?view=msvc-160 > > > > Disable this by defining -D_CRT_SECURE_NO_WARNINGS. > > > > Signed-off-by: Nick Connolly > > --- > > v2: > > * Adjust commit wording as per Dmitry Kozlyuk > > > > Note: It is unclear exactly which commit this fixes. It is probably a > > consequence of building more libraries for Windows. > > Acked-by: Dmitry Kozlyuk Applied, thanks