From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id CBF4FADF9 for ; Thu, 12 Feb 2015 16:29:09 +0100 (CET) Received: by mail-wg0-f43.google.com with SMTP id n12so10861482wgh.2 for ; Thu, 12 Feb 2015 07:29:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=fTlJcg5p6ZOtyL7ME2IVRF6WTuN72YQU7wifLpDxmO0=; b=Z7ek5iLoLRxrGh3A649LG0AP42U2S5hy0pAvZAQvia3iGsq52jHm3O4gfoDGmyLFY/ 0pf8/em8ENOpaggOdoYJnGFPFsOJPvI88RMtJ9pYKGdvzkWu7naaK2/9WDkAo2mzf932 Zwf/VEQ7mS3C6PoTzaSJKZhlDv8mhE91xZ5WKKACeoh2pGH7KBVXuK1OVN+zNT9+tApN H2nhpdffx7vvH91ESyQdumJ4Cr3ZCBbq0B4nk5N2OrimpltLvvlLBKm5Co/W6q55+2wq VIJG+oTQcrDX105hUMA4SQ09kiTqaP9csdWZEpfgWHQg7kvsaPSDKbeo2NzyIJw4jKr7 IJ4Q== X-Gm-Message-State: ALoCoQk1gfDVI26e43sfOAidTDRmqXl/7o1KwevMcWu9NE0j8dAKQFA40fCkbpHlg4Fwidi4kJ/M X-Received: by 10.195.12.35 with SMTP id en3mr8366011wjd.129.1423754949596; Thu, 12 Feb 2015 07:29:09 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id fo17sm6120610wjc.19.2015.02.12.07.29.08 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Feb 2015 07:29:08 -0800 (PST) From: Thomas Monjalon To: "Gonzalez Monroy, Sergio" Date: Thu, 12 Feb 2015 16:28:40 +0100 Message-ID: <6385204.sJsWr1ttol@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <54DCC452.5010905@intel.com> References: <1423661455-27540-1-git-send-email-sergio.gonzalez.monroy@intel.com> <1762724.29i33vs4dM@xps13> <54DCC452.5010905@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] eal: add rte_eal_iopl_init to version map X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Feb 2015 15:29:10 -0000 2015-02-12 15:18, Gonzalez Monroy, Sergio: > On 12/02/2015 15:12, Thomas Monjalon wrote: > > 2015-02-11 13:30, Sergio Gonzalez Monroy: > >> Common rte_eal_iopl_init function is missing from eal version map. > > How did you see it? > > Thanks > Building shared libraries and using virtio PMD would result in undefined > reference symbol. > Should I add it to the commit log? Yes please. > >> rte_eal_hpet_init; > >> + rte_eal_iopl_init; > >> rte_eal_init; > > You missed the alphabetical order, you were not so far ;) > Oh, I did not realize it was alphabetical order, I'll send v2. Thanks