From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id C096B1094
 for <dev@dpdk.org>; Wed, 18 Jan 2017 00:31:38 +0100 (CET)
Received: by mail-wm0-f52.google.com with SMTP id r144so247856443wme.1
 for <dev@dpdk.org>; Tue, 17 Jan 2017 15:31:38 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=uNWX814AQWJKs3JBJ8YkJ2dVD6rGHy5EEnVrX3fq1FI=;
 b=jhksGSJQu9uJqa4DIpGEhszDn75WQda4LkXfQBxc2ZmLGB1ngt/oxzuvuWT1CIhLwL
 uk8gZ5b15j2qAOShS9LEepjjLbLrXsAlVnQfmYqcuw3u23YyC46Z9CpxgKrjis299Ql1
 pzylCAj7nl7US5Gq2pUWLZmIrOzOT+hsht225Pu3wYJJJlkGtgaAVuAZjwFbzmzMtl8K
 GraF8Q+EHZTPJFhKoX9H1Pxtyozhi4tRjcbYE37XRZOAc/fVMD5zXxk9HsezDXZrSUgT
 wdW9CiUM2fSsWiuv71i7AS29YDuuE2898jy3uG3ATZsayqShUfzao7u8Nv0s16mOgrZw
 ZHCA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=uNWX814AQWJKs3JBJ8YkJ2dVD6rGHy5EEnVrX3fq1FI=;
 b=GU7sQRndnn2mcGXjIDoZSR1dNhOgEp68oQr8s1ZNApUMwANDBO+cUA+AQl6WfD69TB
 AVEBf5G1/fFIzgIhV3ag1cKiEa1yT5DtVyaCUvhmO8w/CEQn0sTr4wJZDx19cXSZgkCU
 F2BX30XsRF5V4FdlVvdbGgMUUzjHhYf8QuEDj0zNXmMIL2UOsLl5lVySexLwSbFV1vEE
 PFLEFfsMcSamdPKEyrWf6VYvFScPFrWFjAXT1xGNfpzDfqZTn7BhtyrbDJWqmCDQme7h
 AIDk9HyrcjRvsuY1IKsG4+f5+VPeINmRAn92f/at8aAf/iYpVZ99TS+mikomkE1lYbqd
 NORA==
X-Gm-Message-State: AIkVDXJU159vNPEbt0S1F9eEynWhKCx3vlzdeYDYB5U0BH1t1AI5CrDRZvCgku1rEeQYVwtr
X-Received: by 10.28.29.141 with SMTP id d135mr514047wmd.108.1484695898484;
 Tue, 17 Jan 2017 15:31:38 -0800 (PST)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id y127sm75902wmg.12.2017.01.17.15.31.37
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 17 Jan 2017 15:31:37 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Cc: dev@dpdk.org
Date: Wed, 18 Jan 2017 00:31:36 +0100
Message-ID: <6385545.1JoApMrEe4@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1484660264-6531-4-git-send-email-shreyansh.jain@nxp.com>
References: <1484647774-28984-1-git-send-email-shreyansh.jain@nxp.com>
 <1484660264-6531-1-git-send-email-shreyansh.jain@nxp.com>
 <1484660264-6531-4-git-send-email-shreyansh.jain@nxp.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v8 3/9] pci: split match and probe function
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Jan 2017 23:31:38 -0000

2017-01-17 19:07, Shreyansh Jain:
> +static int
> +rte_eal_pci_detach_dev(struct rte_pci_driver *dr,
> +               struct rte_pci_device *dev)
> +{
> +       int ret;
> +       struct rte_pci_addr *loc;
> +
> +       if ((dr == NULL) || (dev == NULL))
> +               return -EINVAL;
> +
> +       ret = rte_pci_match(dr, dev);

I do not understand this function.
The driver should be known by the device at this stage.
Why specifying a driver as parameter?

I know it is not new in this series, but
pci_detach_all_drivers(struct rte_pci_device *dev) makes no sense to me.