Re: [dpdk-dev] [PATCH] i40e: Fix a vlan bug

[Thomas Monjalon <thomas.monjalon@6wind.com>]

Hi Huawei,

2014-12-05 04:56, Xie, Huawei:
> Hi Thomas:
> I will continue work on this fix.
> Do you have comments to the v4 patch?
> For Bruce's comment, I add some descriptive commit message for the commit.
> For the constant number, I define a macro as the wrapper for the VFA array index and value.
> 
> One question is it isn't based on latest commit, but I tried applying the patch, there is no problem.
> +/*
> + * vlan_id is a 12 bit number.
> + * The VFTA array is actually a 4096 bit array, 128 of 32bit elements.
> + * 2^5 = 32. The val of lower 5 bits specifies the bit in the 32bit element.
> + * The higher 7 bit val specifies VFTA array index.
> + */
> +#define I40E_VFTA_BIT(vlan_id)    (1 << ((vlan_id) & 0x1F))
> +#define I40E_VFTA_IDX(vlan_id)    ((vlan_id) >> 5)

If you replace the values by constants, it's ok for me.
Note that I won't check the i40e datasheet so you need a reviewer
who will do :)

-- 
Thomas