From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DBE08A0561; Wed, 17 Mar 2021 23:00:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 91501140F72; Wed, 17 Mar 2021 23:00:51 +0100 (CET) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by mails.dpdk.org (Postfix) with ESMTP id B0492140F6F for <dev@dpdk.org>; Wed, 17 Mar 2021 23:00:50 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id F323E580A20; Wed, 17 Mar 2021 18:00:49 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 17 Mar 2021 18:00:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= m/KKM69eBirn9Yut/GIiGPGGhlQPpO6roXQtwhtaQ58=; b=B4cAbUqhd9JI8hKV Ft6eimWHLvKMVhTeV40xQTybxxj95nSIhszOVGAbPMEPmQSoBdUTNU+PAQEJSbIi dVe5f7M+tiegyDAXx25tmOOz9ysNkCskPMXTHF2eBraGnEn5i+JMtRf+Ghi2qDvN NyRpw0A4awdjJ3/n8hq5OKtdYMarAeSpfbbYDCJcvqlaak7Ea2VAefsvqP0NF7fT YuWyA+OSkq8sRgsYH0uYRJfgDnIZ/YVlcw8xXFJqsJCOL2Pbsfilt7kRR1kNkTw3 r197ue/eo8w370ehpgZeptKkpMtx5Jqp2c9mHzcnhh7QPPEYBzp6NnpNP0COQpIQ zZEBDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=m/KKM69eBirn9Yut/GIiGPGGhlQPpO6roXQtwhtaQ 58=; b=M++xbhOugm3tNmV9FKDK8s3i4Vz7Zg2qWtb1BojqZ1NfywmGS4UtVww92 5Lt1sNdLwyKFUyvKc8nJGFHws+lFgVTQdQV48XR5uPzV31ywkIBSQ+uOi9CjwEHI sMIbFLftwvmmVZwpsspzJpPQOEVxJ7xLsTDgAmmEyFYFKgHdgtPZFk+0EDRSgN/R zO30OC5F/ikVbdBmmdr+33ircUXWdMyu3SXyStoQRgmSVlPJcODRBe8BmDf5WsAV KMP6fMhD8WiDEaJFcu5rnHPi+2PcnshTcoEKRgb+PqMZLqMVkyo0HYfyw3uNVO0z Ufz8rswrJW4On2QCLJ2B9z414BCog== X-ME-Sender: <xms:EXxSYLBpxbfA8IDfjgINUbj4Ygs-E7YFUzd_XNyagSe0gbipMNUFQw> <xme:EXxSYCTvtxAXXgpvbq1H9GE74GFpJVrlhcs0cwWt-rHM7HUUy4Nx2CyWTpD5mFVwV 6NYFUl055TBnEPZ6g> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudefgedgudeitdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: <xmx:EXxSYCtJi5unBg9CoGmRoUUiEHfTTE9wJ88XyAy0DedyiRM-49k9Jg> <xmx:EXxSYO0_tykJrmLq8roEcM5YKw6jDAA2xfN-W-3ppy2fM_Z48m1u8A> <xmx:EXxSYDUqv9nqaFO50luThWscCVE2QzYq2CXt-pnArbVLj4Bkm4s9rA> <xmx:EXxSYH6W5YMUN5lrZYG34iZfq2y3E6awpg_W3YBBlblNmd45mgvQ0A> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EDF8E1080057; Wed, 17 Mar 2021 18:00:47 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Qi Zhang <qi.z.zhang@intel.com>, Andrew Rybchenko <arybchenko@solarflare.com>, Ferruh Yigit <ferruh.yigit@intel.com> Cc: dev@dpdk.org, bruce.richardson@intel.com, xiao.w.wang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com, jia.guo@intel.com, qiming.yang@intel.com, haiyue.wang@intel.com Date: Wed, 17 Mar 2021 23:00:45 +0100 Message-ID: <6388516.0yhbR63jCu@thomas> In-Reply-To: <eeb6fe9d-7947-e25c-19fc-12b953952073@intel.com> References: <20210310121626.2019863-1-qi.z.zhang@intel.com> <20210317111551.2215332-3-qi.z.zhang@intel.com> <eeb6fe9d-7947-e25c-19fc-12b953952073@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 2/9] net: replace build option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 17/03/2021 22:47, Ferruh Yigit: > On 3/17/2021 11:15 AM, Qi Zhang wrote: > > Replace RTE_LIBRTE_ETHDEV_DEBUG with RTE_ETHDEV_DEBUG. > > > > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com> > > Hi Qi, Thomas, > > I see Thomas mentioned 'LIBRTE_' is redundant but not sure about renaming the > existing compile time flag without notice. > > The flag is to be used for users, it is not internal, and it may be already used > in some scripts and automation etc, this rename can break them. > > 'LIBRTE_' is already used commonly, I think all library flags has it, do we > really need to drop it from this current one? Even if we drop it, what about > keeping it as alias for backward compatibility? Yes I did not ask for removing now :) Let's keep old name as alias and start using the new name (if you agree with the new name without LIBRTE_).