From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5C04A0562; Tue, 23 Mar 2021 11:42:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7B2284014D; Tue, 23 Mar 2021 11:42:40 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id EC2A640143 for ; Tue, 23 Mar 2021 11:42:38 +0100 (CET) IronPort-SDR: tG+AzVQU6OZ1KizyF85SmTwSUHVF3aEseJ1pm83xtaFmAmmLw8qq64zAS6S9mlq47PCk8c1bL9 08Meaa5hoMJQ== X-IronPort-AV: E=McAfee;i="6000,8403,9931"; a="170415768" X-IronPort-AV: E=Sophos;i="5.81,271,1610438400"; d="scan'208";a="170415768" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2021 03:42:38 -0700 IronPort-SDR: 9GJjsIymFpgsHV9Xm7A/2Ri+NLV5EfO5wWgs+jHEemgex5EPtVhStposnF7UKGHjzVW6s68vVH IiTf7vmsUB5g== X-IronPort-AV: E=Sophos;i="5.81,271,1610438400"; d="scan'208";a="604261199" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.14.45]) ([10.252.14.45]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2021 03:42:36 -0700 To: "Li, Xiaoyun" , oulijun , "Tu, Lijuan" , Andrew Rybchenko Cc: "dev@dpdk.org" , "linuxarm@openeuler.org" References: <1614939741-63927-1-git-send-email-oulijun@huawei.com> <1614939741-63927-4-git-send-email-oulijun@huawei.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <638fa10e-47bb-b2b5-4cb4-ef304a64f7d2@intel.com> Date: Tue, 23 Mar 2021 10:42:33 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 3/3] app/testpmd: use of Rx/Tx in testpmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/23/2021 7:58 AM, Li, Xiaoyun wrote: > > >> -----Original Message----- >> From: oulijun >> Sent: Tuesday, March 23, 2021 15:52 >> To: Tu, Lijuan ; Andrew Rybchenko >> ; Li, Xiaoyun ; Yigit, >> Ferruh >> Cc: dev@dpdk.org; linuxarm@openeuler.org >> Subject: Re: [dpdk-dev] [PATCH 3/3] app/testpmd: use of Rx/Tx in testpmd >> >> >> >> 在 2021/3/23 15:46, Tu, Lijuan 写道: >>> >>> >>>> -----Original Message----- >>>> From: Andrew Rybchenko >>>> Sent: 2021年3月23日 15:25 >>>> To: Li, Xiaoyun ; Lijun Ou >>>> ; Yigit, Ferruh ; Tu, >>>> Lijuan >>>> Cc: dev@dpdk.org; linuxarm@openeuler.org >>>> Subject: Re: [dpdk-dev] [PATCH 3/3] app/testpmd: use of Rx/Tx in >>>> testpmd >>>> >>>> On 3/23/21 6:17 AM, Li, Xiaoyun wrote: >>>>> Hi >>>>> >>>>>> -----Original Message----- >>>>>> From: Lijun Ou >>>>>> Sent: Friday, March 5, 2021 18:22 >>>>>> To: Yigit, Ferruh >>>>>> Cc: Li, Xiaoyun ; dev@dpdk.org; >>>>>> linuxarm@openeuler.org >>>>>> Subject: [PATCH 3/3] app/testpmd: use of Rx/Tx in testpmd >>>>>> >>>>>> From: Hongbo Zheng >>>>>> >>>>>> In testpmd, when we input "show config rxtx", we can see like this: >>>>>> >>>>>> 1: testpmd> show config rxtx >>>>>> 2: io packet forwarding packets/burst=32 >>>>>> 3: nb forwarding cores=1 - nb forwarding ports=1 >>>>>> 4: port 0: RX queue number: 1 Tx queue number: 1 >>>>>> 5: Rx offloads=0x0 Tx offloads=0x10000 >>>>>> 6: RX queue: 0 >>>>>> 7: RX desc=1024 - RX free threshold=32 >>>>>> 8: RX threshold registers: pthresh=0 hthresh=0 wthresh=0 >>>>>> 9: RX Offloads=0x0 >>>>>> 10: TX queue: 0 >>>>>> 11: TX desc=1024 - TX free threshold=928 >>>>>> 12: TX threshold registers: pthresh=0 hthresh=0 wthresh=0 >>>>>> 13: TX offloads=0x10000 - TX RS bit threshold=32 >>>>>> >>>>>> We can see RX/Rx/TX/Tx is mixed used. Also in other places in >>>>>> testpmd, RX/Rx/TX/Tx is mixed used. >>>>>> >>>>>> This patch fix the mixed use of RX/Rx/TX/Tx in testpmd by change to >>>>>> unified use Rx/Tx. >>>>> >>>>> The commit log is too redundant. The following is enough to explain >>>>> what this >>>> patch does: >>>>> RX/TX and Rx/Tx are mixed used in testpmd print and comments. This >>>>> patch >>>> unifies them as Rx/Tx. >>>>> >>>>> Except this, the patch looks good to me. >>>>> >>>>> But one big concern, this patch will break all of the CI tests >>>>> because the DTS >>>> scripts check if the results are the same as expected and this patch >>>> change a lot of the print. >>>>> So I think the DTS maintainer needs to be aware of this. >>>> >>>> I think test dpdk-testpmd output is a part of API. Of course, it is >>>> not an API, but such cosmetic changes in output will be much more painful >> than API changes. >>>> Output parsers will simply stop to work. I think such changes should >>>> go through the deprecation process. >>>> >>>> Of course, it would be useful to change comments and may be even >>>> error log messages right now, but not commands output. >>>> >>>>> >>>>> +Lijuan DTS maintainer >>> >>> It has big impact with CI system, most of test cases depended on the testpmd >> output, if changed, our CI system will be broken, Is it really worth it ? >>> >> I think it's necessary to keep the style consistent and to constrain everyone to do >> so in the future.However, if the DTS changes greatly, I think it is possible to >> require the new print to be consistent and the historical part to remain >> unchanged.Because the uniform change is also Xiaoyun's suggestion, we think >> the opinion is reasonable, but we are not sure how much it will affect DTS. > > I think we should drop this patch. But we'll keep consistent for future print when reviewing. > What do you think? > +1 to have consistency on the new code, and as the old code changed by time. Instead of big syntax cleanup. As well as output parsing problem, this also can cause trouble on backporting patches for stable trees because of conflicts it will create. >>>>> >>>>> And please separate this patch with the other twos. Don't mix them >>>>> in one >>>> patchset. It's not for the same purpose. >>>>> >>>>>> >>>>>> Signed-off-by: Hongbo Zheng >>>>>> Signed-off-by: Lijun Ou >>>>>> --- >>>>>> V1->V2: >>>>>> - fix all RX/TX >>>>>> - rename patch title >>>>>> --- >>>>>> app/test-pmd/cmdline.c | 104 ++++++++++++++++++------------------ >>>>>> app/test-pmd/config.c | 128 ++++++++++++++++++++++------------------ >> --- >>>> -- >>>>>> app/test-pmd/csumonly.c | 22 ++++---- >>>>>> app/test-pmd/icmpecho.c | 2 +- >>>>>> app/test-pmd/ieee1588fwd.c | 18 +++---- >>>>>> app/test-pmd/parameters.c >>>>>> | 50 +++++++++--------- >>>>>> app/test-pmd/testpmd.c | 120 +++++++++++++++++++++------------------ >> --- >>>>>> app/test-pmd/testpmd.h | 28 +++++----- >>>>>> app/test-pmd/txonly.c | 2 +- >>>>>> 9 files changed, 237 insertions(+), 237 deletions(-) >>>>>> -- >>>>>> 2.7.4